New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 816370 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Mar 2018
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 3
Type: Feature



Sign in to add a comment

factory: Add additional fields in the probe statement to record component status.

Project Member Reported by yhong@chromium.org, Feb 26 2018

Issue description

To deprecate the "components" part of HWID databases, we have to find another place, which must be also included in HWID bundles, to record the status of each component.  As the source of the probe statement will eventually become the AVL, it's reasonable to record the component status in the probe statement.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Mar 1 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform/factory/+/aa4fe63a81503cadd2baaab3860842337ac6ae40

commit aa4fe63a81503cadd2baaab3860842337ac6ae40
Author: Yong Hong <yhong@chromium.org>
Date: Thu Mar 01 07:54:16 2018

probe: Add an new field "information" in the probe statement.

This CL revises the syntax of the probe statement and the probed
results to let the user be able to add additional information in
the probe statement and let the probe tool will forward that
information to the probed results.

To deprecate the "components" part of HWID databases, we have to find
another place, which must be also included in HWID bundles, to record
the status of each component.  As the source of the probe statement
will eventually become the AVL, it's reasonable to record the
component status in the probe statement.

BUG= chromium:816370 
TEST=make test

Change-Id: Ieaa4cbedd974d717f7dfdd46e2490d7d1f1b32d1
Reviewed-on: https://chromium-review.googlesource.com/938867
Commit-Ready: Yong Hong <yhong@google.com>
Tested-by: Yong Hong <yhong@google.com>
Reviewed-by: Yilun Lin <yllin@chromium.org>
Reviewed-by: Wei-Han Chen <stimim@chromium.org>

[modify] https://crrev.com/aa4fe63a81503cadd2baaab3860842337ac6ae40/py/hwid/v3/builder_unittest.py
[modify] https://crrev.com/aa4fe63a81503cadd2baaab3860842337ac6ae40/py/probe/probe_cmdline_unittest.py
[modify] https://crrev.com/aa4fe63a81503cadd2baaab3860842337ac6ae40/py/probe/statement.schema.json
[modify] https://crrev.com/aa4fe63a81503cadd2baaab3860842337ac6ae40/py/hwid/v3/testdata/TEST_PROJECT_probed_results
[modify] https://crrev.com/aa4fe63a81503cadd2baaab3860842337ac6ae40/py/hwid/v3/probe.py
[modify] https://crrev.com/aa4fe63a81503cadd2baaab3860842337ac6ae40/py/hwid/v3/probe_unittest.py
[modify] https://crrev.com/aa4fe63a81503cadd2baaab3860842337ac6ae40/py/test/pytests/probe/probe.py
[modify] https://crrev.com/aa4fe63a81503cadd2baaab3860842337ac6ae40/py/probe/probe_utils_unittest.py
[modify] https://crrev.com/aa4fe63a81503cadd2baaab3860842337ac6ae40/py/hwid/v3/builder.py
[modify] https://crrev.com/aa4fe63a81503cadd2baaab3860842337ac6ae40/py/probe/probe_utils.py
[modify] https://crrev.com/aa4fe63a81503cadd2baaab3860842337ac6ae40/py/hwid/v3/hwid_utils_unittest.py

Comment 2 by yhong@chromium.org, Mar 1 2018

Status: Fixed (was: Started)

Sign in to add a comment