New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 816366 link

Starred by 1 user

Issue metadata

Status: Available
Owner: ----
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 3
Type: Task

Blocked on:
issue 810205



Sign in to add a comment

Maintain mount source path in VolumeManager

Project Member Reported by yamaguchi@chromium.org, Feb 26 2018

Issue description

While discussing about https://chromium-review.googlesource.com/c/chromium/src/+/896765, we've got to a question why the JS side cannot stop calling the fileManagerPrivate.addMount when the file is already mounted as a volume.

VolumeInfo (in js) doesn't contain source file location currently.
It makes it impossible to know if an archive file (given by URL) is already mounted or not.

https://cs.chromium.org/chromium/src/ui/file_manager/file_manager/background/js/volume_manager_impl.js?q=VolumeManager+volumemetadata+event&sq=package:chromium&l=78

volumeManager does receive 'mount' event containing VolumeMetadata, which contains source_path. However the field is currently not stored.
 
Not stated clearly, but seems FileManagerPrivate.addMount does:
- reply with success regardless of if mounting was successful or not. The return result contains VolumeInfo.
- lately 'mount' event will be issued with VolumeMetadata (if success) or error otherwise.

https://cs.chromium.org/chromium/src/third_party/closure_compiler/externs/file_manager_private.js?q=file:file_manager+addmount&sq=package:chromium&l=386

If this is correct, I think we should state it in the function's comment as it's not obvious what happens upon getting the callback from addMount.
Blocking: -798024
Components: Platform>Apps>FileManager
Labels: -Pri-1 -Type-Bug Pri-3 Type-Task
Status: Available (was: Assigned)
Changing this to Pri-3, Task, as this is now not blocking the issue.

I think we can resolve Issue 798024 by https://chromium-review.googlesource.com/c/chromium/src/+/896765, which just avoids error.

This is a proposal to cleanup the logic by these changes:
- store mount source path in VolumeManager (or somewhere in JS side)
- stop invoking fileManagerPrivate.addMount when duplicated mount attempt was detected
- Files app should trigger folder navigation, to the mounted volume. (currently it is done by receiving 'mount' event which notifies mount completion event.)


Owner: ----
Cc: yamaguchi@chromium.org

Comment 5 by sashab@chromium.org, Feb 28 2018

Blockedon: 810205
Labels: CrOS-FilesApp-Zip
I think this is blocked by (if not a duplicate of) issue 810205.

I have an idea on how to fix this, but it is low priority at the moment.

I'll put more details on the other bug.

Comment 6 by sashab@chromium.org, Feb 28 2018

Labels: -CrOS-FilesApp-Zip CrOSFilesFeature-Zip

Sign in to add a comment