Maintain mount source path in VolumeManager |
||||||
Issue descriptionWhile discussing about https://chromium-review.googlesource.com/c/chromium/src/+/896765, we've got to a question why the JS side cannot stop calling the fileManagerPrivate.addMount when the file is already mounted as a volume. VolumeInfo (in js) doesn't contain source file location currently. It makes it impossible to know if an archive file (given by URL) is already mounted or not. https://cs.chromium.org/chromium/src/ui/file_manager/file_manager/background/js/volume_manager_impl.js?q=VolumeManager+volumemetadata+event&sq=package:chromium&l=78 volumeManager does receive 'mount' event containing VolumeMetadata, which contains source_path. However the field is currently not stored.
,
Feb 27 2018
Changing this to Pri-3, Task, as this is now not blocking the issue. I think we can resolve Issue 798024 by https://chromium-review.googlesource.com/c/chromium/src/+/896765, which just avoids error. This is a proposal to cleanup the logic by these changes: - store mount source path in VolumeManager (or somewhere in JS side) - stop invoking fileManagerPrivate.addMount when duplicated mount attempt was detected - Files app should trigger folder navigation, to the mounted volume. (currently it is done by receiving 'mount' event which notifies mount completion event.)
,
Feb 27 2018
,
Feb 27 2018
,
Feb 28 2018
I think this is blocked by (if not a duplicate of) issue 810205. I have an idea on how to fix this, but it is low priority at the moment. I'll put more details on the other bug.
,
Feb 28 2018
|
||||||
►
Sign in to add a comment |
||||||
Comment 1 by yamaguchi@chromium.org
, Feb 26 2018