New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 816353 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Mar 2018
Cc:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug

Blocking:
issue 816350



Sign in to add a comment

Show the message center on lock screen behind flag

Project Member Reported by yoshiki@chromium.org, Feb 26 2018

Issue description

Show the message center on lock screen behind flag

As the first step, let's add a flag to show the message center on lock screen.

We don't launch this feature as for now, but this is useful as a testbed to show notification lockscreen to implement the surrounded part including ARC-side.
 
Components: UI>Shell>LockScreen UI>Shell>Notifications
Status: Started (was: Assigned)
Components: -UI>Shell>Notifications -UI>Shell>LockScreen
Project Member

Comment 3 by bugdroid1@chromium.org, Mar 6 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5a0d4181b538c577b034233bde90f4aa1a446aa2

commit 5a0d4181b538c577b034233bde90f4aa1a446aa2
Author: Megumi Hattori <megumihattori@google.com>
Date: Tue Mar 06 11:09:50 2018

Show Message Center on lock screen behind flag.

This is a test bed for Lock Screen Notification
(go/notification-on-lock-screen).

This CL adds a new flag enable-lock-screen-notification. Behind this
flag, Message Center with notifications for the selected user is shown
on the lock screen.

Compared with Message Center on the non-locked screen, Message Center
on the lock screen does not have a settings button, which means it does
not have a separator between the settings button and a quiet mode button
either.

BUG= 816353 
TEST=ash_unittests

Change-Id: I27094a8a2c3c8b5f3b48f3ae5c8dccce4bfe78ab
Reviewed-on: https://chromium-review.googlesource.com/939223
Reviewed-by: Tetsui Ohkubo <tetsui@chromium.org>
Reviewed-by: James Cook <jamescook@chromium.org>
Commit-Queue: Megumi Hattori <megumihattori@google.com>
Cr-Commit-Position: refs/heads/master@{#541067}
[modify] https://crrev.com/5a0d4181b538c577b034233bde90f4aa1a446aa2/ash/message_center/message_center_button_bar.cc
[modify] https://crrev.com/5a0d4181b538c577b034233bde90f4aa1a446aa2/ash/message_center/message_center_button_bar.h
[modify] https://crrev.com/5a0d4181b538c577b034233bde90f4aa1a446aa2/ash/message_center/message_center_view.cc
[modify] https://crrev.com/5a0d4181b538c577b034233bde90f4aa1a446aa2/ash/message_center/message_center_view_unittest.cc
[modify] https://crrev.com/5a0d4181b538c577b034233bde90f4aa1a446aa2/ash/public/cpp/ash_features.cc
[modify] https://crrev.com/5a0d4181b538c577b034233bde90f4aa1a446aa2/ash/public/cpp/ash_features.h
[modify] https://crrev.com/5a0d4181b538c577b034233bde90f4aa1a446aa2/ash/system/web_notification/session_state_notification_blocker.cc
[modify] https://crrev.com/5a0d4181b538c577b034233bde90f4aa1a446aa2/chrome/browser/about_flags.cc
[modify] https://crrev.com/5a0d4181b538c577b034233bde90f4aa1a446aa2/chrome/browser/flag_descriptions.cc
[modify] https://crrev.com/5a0d4181b538c577b034233bde90f4aa1a446aa2/chrome/browser/flag_descriptions.h
[modify] https://crrev.com/5a0d4181b538c577b034233bde90f4aa1a446aa2/tools/metrics/histograms/enums.xml

Status: Fixed (was: Started)

Sign in to add a comment