Some IDL files contain wrong type names; bool, int and Dictionary |
|||||
Issue descriptionSome IDL files uses wrong type names. i.e. bool for boolean, and int for short/long. We should fix these usages, and probably IDL compiler should detect and warn them.
,
Feb 26 2018
"Dictionary" is also abused in some IDL files. We have to use dictionary definitions instead. https://cs.chromium.org/search/?q=%22+Dictionary+%22+file:%5C.idl+case:yes+file:WebKit&type=cs Here are current usages; core/fetch/Request.idl core/fetch/WindowFetch.idl core/fetch/WorkerFetch.idl core/testing/Internals.idl modules/mediastream/MediaTrackConstraintSet.idl modules/payments/AndroidPayTokenization.idl modules/peerconnection/RTCPeerConnection.idl modules/serviceworkers/ServiceWorkerGlobalScope.idl
,
Feb 27 2018
,
Jul 18
Update: RequestInit became a dictionary, so now we have "Dictionary" objects in core/testing/dictionary_test.idl core/testing/internals.idl modules/peerconnection/rtc_peer_connection.idl modules/permissions/permissions.idl and them seem to be replaceable with "object" or removable.
,
Jul 19
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/83361f47040ea6253ee1b528160a6af03309ab24 commit 83361f47040ea6253ee1b528160a6af03309ab24 Author: Hitoshi Yoshida <peria@chromium.org> Date: Thu Jul 19 02:14:34 2018 bindings: Replace Dictionary with object in permissions.idl "Dictioary" is not a type in spec, and it is replaceable with "object". Bug: 816352 Change-Id: I745000e7ce0ef82959870ef40e44f20029acbdd6 Reviewed-on: https://chromium-review.googlesource.com/1141559 Reviewed-by: Kentaro Hara <haraken@chromium.org> Commit-Queue: Hitoshi Yoshida <peria@chromium.org> Cr-Commit-Position: refs/heads/master@{#576327} [modify] https://crrev.com/83361f47040ea6253ee1b528160a6af03309ab24/third_party/blink/renderer/modules/permissions/permissions.cc [modify] https://crrev.com/83361f47040ea6253ee1b528160a6af03309ab24/third_party/blink/renderer/modules/permissions/permissions.h [modify] https://crrev.com/83361f47040ea6253ee1b528160a6af03309ab24/third_party/blink/renderer/modules/permissions/permissions.idl
,
Aug 22
,
Aug 23
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/aaced754ef52b05d284b0d97bb2b312ca7acd27a commit aaced754ef52b05d284b0d97bb2b312ca7acd27a Author: Hitoshi Yoshida <peria@chromium.org> Date: Thu Aug 23 10:31:01 2018 bindings: Replace IDL Dictionary with 'object' in test internals Dictionary is not a speced type, and these values are actually unused in implementation. This CL changes Dictionary arguments to 'object' types. Bug: 816352 Change-Id: I73c31204e0f63d8cb51a425f7de10daf97f9d620 Reviewed-on: https://chromium-review.googlesource.com/1143666 Reviewed-by: Kentaro Hara <haraken@chromium.org> Reviewed-by: Yuki Shiino <yukishiino@chromium.org> Commit-Queue: Hitoshi Yoshida <peria@chromium.org> Cr-Commit-Position: refs/heads/master@{#585446} [modify] https://crrev.com/aaced754ef52b05d284b0d97bb2b312ca7acd27a/third_party/blink/renderer/core/testing/internals.cc [modify] https://crrev.com/aaced754ef52b05d284b0d97bb2b312ca7acd27a/third_party/blink/renderer/core/testing/internals.h [modify] https://crrev.com/aaced754ef52b05d284b0d97bb2b312ca7acd27a/third_party/blink/renderer/core/testing/internals.idl
,
Nov 30
|
|||||
►
Sign in to add a comment |
|||||
Comment 1 by bugdroid1@chromium.org
, Feb 26 2018