New issue
Advanced search Search tips

Issue 816352 link

Starred by 2 users

Issue metadata

Status: WontFix
Owner:
Closed: Nov 30
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug

Blocked on:
issue 696011
issue 876608

Blocking:
issue 674593



Sign in to add a comment

Some IDL files contain wrong type names; bool, int and Dictionary

Project Member Reported by peria@chromium.org, Feb 26 2018

Issue description

Some IDL files uses wrong type names.
i.e. bool for boolean, and int for short/long.

We should fix these usages, and probably IDL compiler should detect and warn them.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Feb 26 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/569e04d3ae7a639826124feb5bc7b8dd5d125b63

commit 569e04d3ae7a639826124feb5bc7b8dd5d125b63
Author: Hitoshi Yoshida <peria@chromium.org>
Date: Mon Feb 26 07:56:18 2018

IDL: Replace bool/int with boolean/long in IDL files

Web IDL has no definition of bool/int.
We should use boolean and long instead.


Bug:  816352 
Change-Id: Icf55c6adda4898e0490b51a46e2755dd432f4552
Reviewed-on: https://chromium-review.googlesource.com/936347
Reviewed-by: Yuki Shiino <yukishiino@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Reviewed-by: Kenichi Ishibashi <bashi@chromium.org>
Commit-Queue: Hitoshi Yoshida <peria@chromium.org>
Cr-Commit-Position: refs/heads/master@{#539087}
[modify] https://crrev.com/569e04d3ae7a639826124feb5bc7b8dd5d125b63/third_party/WebKit/Source/bindings/tests/idls/core/TestInterface.idl
[modify] https://crrev.com/569e04d3ae7a639826124feb5bc7b8dd5d125b63/third_party/WebKit/Source/bindings/tests/idls/core/TestInterfacePartial2.idl
[modify] https://crrev.com/569e04d3ae7a639826124feb5bc7b8dd5d125b63/third_party/WebKit/Source/bindings/tests/idls/core/TestInterfacePartialSecureContext.idl
[modify] https://crrev.com/569e04d3ae7a639826124feb5bc7b8dd5d125b63/third_party/WebKit/Source/bindings/tests/idls/core/TestInterfaceSecureContext.idl
[modify] https://crrev.com/569e04d3ae7a639826124feb5bc7b8dd5d125b63/third_party/WebKit/Source/core/testing/Internals.idl
[modify] https://crrev.com/569e04d3ae7a639826124feb5bc7b8dd5d125b63/third_party/WebKit/Source/core/testing/SequenceTest.idl
[modify] https://crrev.com/569e04d3ae7a639826124feb5bc7b8dd5d125b63/third_party/WebKit/Source/modules/background_fetch/BackgroundFetchRegistration.idl
[modify] https://crrev.com/569e04d3ae7a639826124feb5bc7b8dd5d125b63/third_party/WebKit/Source/modules/webmidi/MIDIOptions.idl

Comment 2 by peria@chromium.org, Feb 26 2018

Blocking: 674593
Summary: Some IDL files contain wrong type names; bool, int and Dictionary (was: Some IDL files contain wrong type names; bool and int)
"Dictionary" is also abused in some IDL files. We have to use dictionary definitions instead.
https://cs.chromium.org/search/?q=%22+Dictionary+%22+file:%5C.idl+case:yes+file:WebKit&type=cs

Here are current usages;
core/fetch/Request.idl
core/fetch/WindowFetch.idl
core/fetch/WorkerFetch.idl
core/testing/Internals.idl
modules/mediastream/MediaTrackConstraintSet.idl
modules/payments/AndroidPayTokenization.idl
modules/peerconnection/RTCPeerConnection.idl
modules/serviceworkers/ServiceWorkerGlobalScope.idl

Comment 3 by peria@chromium.org, Feb 27 2018

Blockedon: 696011
Update: RequestInit became a dictionary, so now we have "Dictionary" objects in

core/testing/dictionary_test.idl
core/testing/internals.idl
modules/peerconnection/rtc_peer_connection.idl
modules/permissions/permissions.idl

and them seem to be replaceable with "object" or removable.
Project Member

Comment 5 by bugdroid1@chromium.org, Jul 19

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/83361f47040ea6253ee1b528160a6af03309ab24

commit 83361f47040ea6253ee1b528160a6af03309ab24
Author: Hitoshi Yoshida <peria@chromium.org>
Date: Thu Jul 19 02:14:34 2018

bindings: Replace Dictionary with object in permissions.idl

"Dictioary" is not a type in spec, and it is replaceable with "object".


Bug:  816352 
Change-Id: I745000e7ce0ef82959870ef40e44f20029acbdd6
Reviewed-on: https://chromium-review.googlesource.com/1141559
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Commit-Queue: Hitoshi Yoshida <peria@chromium.org>
Cr-Commit-Position: refs/heads/master@{#576327}
[modify] https://crrev.com/83361f47040ea6253ee1b528160a6af03309ab24/third_party/blink/renderer/modules/permissions/permissions.cc
[modify] https://crrev.com/83361f47040ea6253ee1b528160a6af03309ab24/third_party/blink/renderer/modules/permissions/permissions.h
[modify] https://crrev.com/83361f47040ea6253ee1b528160a6af03309ab24/third_party/blink/renderer/modules/permissions/permissions.idl

Blockedon: 876608
Project Member

Comment 7 by bugdroid1@chromium.org, Aug 23

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/aaced754ef52b05d284b0d97bb2b312ca7acd27a

commit aaced754ef52b05d284b0d97bb2b312ca7acd27a
Author: Hitoshi Yoshida <peria@chromium.org>
Date: Thu Aug 23 10:31:01 2018

bindings: Replace IDL Dictionary with 'object' in test internals

Dictionary is not a speced type, and these values are actually
unused in implementation.
This CL changes Dictionary arguments to 'object' types.


Bug:  816352 
Change-Id: I73c31204e0f63d8cb51a425f7de10daf97f9d620
Reviewed-on: https://chromium-review.googlesource.com/1143666
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Reviewed-by: Yuki Shiino <yukishiino@chromium.org>
Commit-Queue: Hitoshi Yoshida <peria@chromium.org>
Cr-Commit-Position: refs/heads/master@{#585446}
[modify] https://crrev.com/aaced754ef52b05d284b0d97bb2b312ca7acd27a/third_party/blink/renderer/core/testing/internals.cc
[modify] https://crrev.com/aaced754ef52b05d284b0d97bb2b312ca7acd27a/third_party/blink/renderer/core/testing/internals.h
[modify] https://crrev.com/aaced754ef52b05d284b0d97bb2b312ca7acd27a/third_party/blink/renderer/core/testing/internals.idl

Status: WontFix (was: Started)

Sign in to add a comment