New issue
Advanced search Search tips

Issue 816328 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Feb 2018
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

Make internals.terminateServiceWorker return a promise

Project Member Reported by bashi@chromium.org, Feb 26 2018

Issue description

Currently we don't have a way to make sure a SW is actually terminated in JS. Let's make the method return a promise which is resolved when the given SW is terminated.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Feb 27 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/adccb79dd7f8545f9bec45e3e7bb54f30372f2bf

commit adccb79dd7f8545f9bec45e3e7bb54f30372f2bf
Author: Kenichi Ishibashi <bashi@chromium.org>
Date: Tue Feb 27 01:33:10 2018

service worker: Make internals.terminateServiceWorker return a promise

The promise will be resolved when the browser actually terminates the
given service worker. Returning such a promise will make layout tests
less flaky.

Bug:  816328 
Change-Id: I0c046720b2a7720c42815be7ca40cfbeb066625e
Reviewed-on: https://chromium-review.googlesource.com/936942
Commit-Queue: Kenichi Ishibashi <bashi@chromium.org>
Reviewed-by: Makoto Shimazu <shimazu@chromium.org>
Reviewed-by: Matt Falkenhagen <falken@chromium.org>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Cr-Commit-Position: refs/heads/master@{#539366}
[modify] https://crrev.com/adccb79dd7f8545f9bec45e3e7bb54f30372f2bf/content/browser/service_worker/service_worker_handle.cc
[modify] https://crrev.com/adccb79dd7f8545f9bec45e3e7bb54f30372f2bf/content/browser/service_worker/service_worker_handle.h
[modify] https://crrev.com/adccb79dd7f8545f9bec45e3e7bb54f30372f2bf/content/renderer/service_worker/service_worker_dispatcher_unittest.cc
[modify] https://crrev.com/adccb79dd7f8545f9bec45e3e7bb54f30372f2bf/content/renderer/service_worker/service_worker_provider_context_unittest.cc
[modify] https://crrev.com/adccb79dd7f8545f9bec45e3e7bb54f30372f2bf/content/renderer/service_worker/web_service_worker_impl.cc
[modify] https://crrev.com/adccb79dd7f8545f9bec45e3e7bb54f30372f2bf/content/renderer/service_worker/web_service_worker_impl.h
[modify] https://crrev.com/adccb79dd7f8545f9bec45e3e7bb54f30372f2bf/third_party/WebKit/LayoutTests/http/tests/serviceworker/chromium.csp-fetch-from-installed-service-worker-connect.html
[modify] https://crrev.com/adccb79dd7f8545f9bec45e3e7bb54f30372f2bf/third_party/WebKit/LayoutTests/http/tests/serviceworker/chromium.csp-fetch-from-installed-service-worker-default.html
[modify] https://crrev.com/adccb79dd7f8545f9bec45e3e7bb54f30372f2bf/third_party/WebKit/LayoutTests/http/tests/serviceworker/chromium.csp-fetch-from-installed-service-worker-script.html
[modify] https://crrev.com/adccb79dd7f8545f9bec45e3e7bb54f30372f2bf/third_party/WebKit/LayoutTests/http/tests/serviceworker/chromium/resources/slow-fetch-and-stop-worker-iframe.html
[modify] https://crrev.com/adccb79dd7f8545f9bec45e3e7bb54f30372f2bf/third_party/WebKit/LayoutTests/http/tests/serviceworker/chromium/usecounter.html
[modify] https://crrev.com/adccb79dd7f8545f9bec45e3e7bb54f30372f2bf/third_party/WebKit/Source/modules/serviceworkers/ServiceWorker.cpp
[modify] https://crrev.com/adccb79dd7f8545f9bec45e3e7bb54f30372f2bf/third_party/WebKit/Source/modules/serviceworkers/ServiceWorker.h
[modify] https://crrev.com/adccb79dd7f8545f9bec45e3e7bb54f30372f2bf/third_party/WebKit/Source/modules/serviceworkers/testing/InternalsServiceWorker.cpp
[modify] https://crrev.com/adccb79dd7f8545f9bec45e3e7bb54f30372f2bf/third_party/WebKit/Source/modules/serviceworkers/testing/InternalsServiceWorker.h
[modify] https://crrev.com/adccb79dd7f8545f9bec45e3e7bb54f30372f2bf/third_party/WebKit/Source/modules/serviceworkers/testing/InternalsServiceWorker.idl
[modify] https://crrev.com/adccb79dd7f8545f9bec45e3e7bb54f30372f2bf/third_party/WebKit/public/mojom/service_worker/service_worker_object.mojom
[modify] https://crrev.com/adccb79dd7f8545f9bec45e3e7bb54f30372f2bf/third_party/WebKit/public/platform/modules/serviceworker/WebServiceWorker.h

Comment 2 by bashi@chromium.org, Feb 27 2018

Status: Fixed (was: Started)

Sign in to add a comment