New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 816326 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Feb 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Windows
Pri: 3
Type: Bug

Blocking:
issue 816435



Sign in to add a comment

swarming.py --dump-json doesn't work for Windows slaves?

Project Member Reported by thakis@chromium.org, Feb 26 2018

Issue description

This works fine:

`tools/swarming_client/swarming.py trigger -S https://chromium-swarm.appspot.com -I https://isolateserver.appspot.com -d pool Chrome -s 5c98c21812a49406ebb7c23be51656188916554d -d os Windows -- --gtest_filter=ProxyResolverV8Test.SideEffects` => https://chromium-swarm.appspot.com/task?id=3be8760b192b5110&refresh=10&show_raw=1
[1/1] ProxyResolverV8Test.SideEffects (127 ms)
SUCCESS: all tests passed.



If I add --dump-json, the run fails:

`tools/swarming_client/swarming.py trigger -S https://chromium-swarm.appspot.com -I https://isolateserver.appspot.com -d pool Chrome -s 5c98c21812a49406ebb7c23be51656188916554d --dump-json results/0.json -d os Windows -- --gtest_filter=ProxyResolverV8Test.SideEffects` => https://chromium-swarm.appspot.com/task?id=3be8750ff8ef0a10&refresh=10&show_raw=1
Traceback (most recent call last):
  File "..\..\testing\test_env.py", line 288, in <module>
    sys.exit(main())
  File "..\..\testing\test_env.py", line 284, in main
    return run_executable(sys.argv[1:], os.environ.copy())
  File "..\..\testing\test_env.py", line 248, in run_executable
    '-vpython-tool', 'install',
  File "c:\infra-system\bin\lib\subprocess.py", line 181, in check_call
    retcode = call(*popenargs, **kwargs)
  File "c:\infra-system\bin\lib\subprocess.py", line 168, in call
    return Popen(*popenargs, **kwargs).wait()
  File "c:\infra-system\bin\lib\subprocess.py", line 390, in __init__
    errread, errwrite)
  File "c:\infra-system\bin\lib\subprocess.py", line 640, in _execute_child
    startupinfo)
WindowsError: [Error 2] The system cannot find the file specified
 

Comment 1 by thakis@chromium.org, Feb 26 2018

Blocking: 816435

Comment 2 by mar...@chromium.org, Feb 26 2018

Owner: iannucci@chromium.org
Status: Assigned (was: Untriaged)
I think this is a vpython difference between Windows 7 and Windows 10, Robbie, can you double check? Likely retry each task on the reverse OS version.

I think the --dump-json flag is red herring here.
This should work as of https://chromium.googlesource.com/chromium/src.git/+/5908c5d2269594aff9c2454c4732360a311c27ca

If you need a specific version that has the un-reverted change, you can include the vpython cipd package, as in e.g. https://chromium-swarm.appspot.com/task?id=3becacddcd178410&refresh=10&request_detail=true&show_raw=1

I'm working on a change to make the inclusion of these packages transparent on the usage of the Chrome pool (which would prevent this from being an issue).
(you could also manually edit test_env.py to apply the revert)
Status: Fixed (was: Assigned)
(Closing this one as fixed as the offending change was reverted)

Comment 6 by thakis@chromium.org, Feb 26 2018

Works after I synced. Thanks, and sorry about the noise -- didn't realize this is a type of problem that syncing could have fixed.
No worries, it's non-obvious :)

Sign in to add a comment