New issue
Advanced search Search tips

Issue 816080 link

Starred by 2 users
Status: Fixed
Owner:
haddowk@chromium.org
Closed: Feb 2018
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug



Sign in to add a comment

/mnt/moblab/containers directory having incorrect owner

Project Member Reported by haddowk@chromium.org, Feb 24 2018 

I think there is a race condition, if moblab-external-storage-init completes before moblab-containers-init the /mnt/moblab/containers is left owned by root.

Move the chown command for the /mnt/moblab/containers to moblab-containers-init just after the directory is created.
Project Member

Comment 1 by bugdroid1@chromium.org, Feb 27 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/overlays/board-overlays/+/28d12385ad894d2810a3bc4526db29475729b110

commit 28d12385ad894d2810a3bc4526db29475729b110
Author: Keith Haddow <haddowk@chromium.org>
Date: Tue Feb 27 03:28:48 2018

[moblab] Move the container chown to the correct place.

TEST=Local moblab build
BUG= chromium:816080 

Change-Id: I90a399bc22806a7966a7507659e48bb19e21939b
Reviewed-on: https://chromium-review.googlesource.com/938185
Commit-Ready: Keith Haddow <haddowk@chromium.org>
Tested-by: Keith Haddow <haddowk@chromium.org>
Reviewed-by: Keith Haddow <haddowk@chromium.org>
Reviewed-by: Matt Mallett <mattmallett@chromium.org>

[modify] https://crrev.com/28d12385ad894d2810a3bc4526db29475729b110/project-moblab/chromeos-base/chromeos-bsp-moblab/files/init/moblab-external-storage-init.conf
[modify] https://crrev.com/28d12385ad894d2810a3bc4526db29475729b110/project-moblab/chromeos-base/chromeos-bsp-moblab/files/init/moblab-containers-dir-init.conf
Project Member

Comment 2 by bugdroid1@chromium.org, Feb 27 2018

Labels: merge-merged-release-R65-10323.B
The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/overlays/board-overlays/+/6ce4d19dd5a3b13c75df2330357cf80e555251a8

commit 6ce4d19dd5a3b13c75df2330357cf80e555251a8
Author: Keith Haddow <haddowk@chromium.org>
Date: Tue Feb 27 04:14:37 2018

[moblab] Move the container chown to the correct place.

TEST=Local moblab build
BUG= chromium:816080 

Change-Id: I90a399bc22806a7966a7507659e48bb19e21939b
Reviewed-on: https://chromium-review.googlesource.com/938185
Commit-Ready: Keith Haddow <haddowk@chromium.org>
Tested-by: Keith Haddow <haddowk@chromium.org>
Reviewed-by: Keith Haddow <haddowk@chromium.org>
Reviewed-by: Matt Mallett <mattmallett@chromium.org>
(cherry picked from commit 28d12385ad894d2810a3bc4526db29475729b110)
Reviewed-on: https://chromium-review.googlesource.com/938903
Commit-Queue: Keith Haddow <haddowk@chromium.org>

[modify] https://crrev.com/6ce4d19dd5a3b13c75df2330357cf80e555251a8/project-moblab/chromeos-base/chromeos-bsp-moblab/files/init/moblab-external-storage-init.conf
[modify] https://crrev.com/6ce4d19dd5a3b13c75df2330357cf80e555251a8/project-moblab/chromeos-base/chromeos-bsp-moblab/files/init/moblab-containers-dir-init.conf
Project Member

Comment 3 by bugdroid1@chromium.org, Feb 27 2018

Labels: merge-merged-release-R64-10176.B
The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/overlays/board-overlays/+/7a5e0fd67ca1d9b3074e63df2cd71dfae4378e39

commit 7a5e0fd67ca1d9b3074e63df2cd71dfae4378e39
Author: Keith Haddow <haddowk@chromium.org>
Date: Tue Feb 27 04:14:40 2018

[moblab] Move the container chown to the correct place.

TEST=Local moblab build
BUG= chromium:816080 

Change-Id: I90a399bc22806a7966a7507659e48bb19e21939b
Reviewed-on: https://chromium-review.googlesource.com/938185
Commit-Ready: Keith Haddow <haddowk@chromium.org>
Tested-by: Keith Haddow <haddowk@chromium.org>
Reviewed-by: Keith Haddow <haddowk@chromium.org>
Reviewed-by: Matt Mallett <mattmallett@chromium.org>
(cherry picked from commit 28d12385ad894d2810a3bc4526db29475729b110)
Reviewed-on: https://chromium-review.googlesource.com/938904
Commit-Queue: Keith Haddow <haddowk@chromium.org>

[modify] https://crrev.com/7a5e0fd67ca1d9b3074e63df2cd71dfae4378e39/project-moblab/chromeos-base/chromeos-bsp-moblab/files/init/moblab-external-storage-init.conf
[modify] https://crrev.com/7a5e0fd67ca1d9b3074e63df2cd71dfae4378e39/project-moblab/chromeos-base/chromeos-bsp-moblab/files/init/moblab-containers-dir-init.conf

Comment 4 by haddowk@chromium.org, Feb 27 2018

Status: Fixed (was: Assigned)
►

Sign in to add a comment