New issue
Advanced search Search tips

Issue 816026 link

Starred by 5 users

Issue metadata

Status: Assigned
Owner:
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Bug



Sign in to add a comment

"external/wpt/css/css-fonts/font-display/font-display.html" is flaky

Project Member Reported by chromium...@appspot.gserviceaccount.com, Feb 24 2018

Issue description

"external/wpt/css/css-fonts/font-display/font-display.html" is flaky.

This issue was created automatically by the chromium-try-flakes app. Please find the right owner to fix the respective test/step and assign this issue to them. If the step/test is infrastructure-related, please add Infra-Troopers label and change issue status to Untriaged. When done, please remove the issue from Sheriff Bug Queue by removing the Sheriff-Chromium label.

We have detected 4 recent flakes. List of all flakes can be found at https://chromium-try-flakes.appspot.com/all_flake_occurrences?key=ahVzfmNocm9taXVtLXRyeS1mbGFrZXNyRAsSBUZsYWtlIjlleHRlcm5hbC93cHQvY3NzL2Nzcy1mb250cy9mb250LWRpc3BsYXkvZm9udC1kaXNwbGF5Lmh0bWwM.

Flaky tests should be disabled within 30 minutes unless culprit CL is found and reverted. Please see more details here: https://sites.google.com/a/chromium.org/dev/developers/tree-sheriffs/sheriffing-bug-queues#triaging-auto-filed-flakiness-bugs

This flaky test/step was previously tracked in  issue 813550 .
 

Comment 1 by timloh@chromium.org, Feb 26 2018

Cc: timloh@chromium.org
Labels: -Sheriff-Chromium
Owner: kojii@chromium.org
Status: Assigned (was: Untriaged)
Disabling the test in https://chromium-review.googlesource.com/c/chromium/src/+/936984. Koji, could you take a look (or re-assign) when you have a chance?

Comment 2 by kojii@chromium.org, Feb 26 2018

Cc: kojii@chromium.org
Owner: ksakamoto@chromium.org
Project Member

Comment 3 by bugdroid1@chromium.org, Feb 26 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a4114c833de77e8c67092b7019e3870f496a479c

commit a4114c833de77e8c67092b7019e3870f496a479c
Author: Timothy Loh <timloh@chromium.org>
Date: Mon Feb 26 03:37:29 2018

Disable flaky test font-display.html

Seems to have been flaking for the past several days.

TBR=kojii

Bug: 816026
Change-Id: I335b2c4d49a172a7ae092e8163adf2f6c9cd5f2d
Reviewed-on: https://chromium-review.googlesource.com/936984
Reviewed-by: Timothy Loh <timloh@chromium.org>
Reviewed-by: Koji Ishii <kojii@chromium.org>
Commit-Queue: Timothy Loh <timloh@chromium.org>
Cr-Commit-Position: refs/heads/master@{#539066}
[modify] https://crrev.com/a4114c833de77e8c67092b7019e3870f496a479c/third_party/WebKit/LayoutTests/TestExpectations

 Issue 821002  has been merged into this issue.
Project Member

Comment 6 by bugdroid1@chromium.org, Mar 12 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c647daef87227415db5d5119b226c76c239030da

commit c647daef87227415db5d5119b226c76c239030da
Author: Luna Lu <loonybear@chromium.org>
Date: Mon Mar 12 15:39:51 2018

Mark external/wpt/css/css-fonts/font-display/font-display.html flaky

Bug: 816026
Change-Id: I28fb2575e76f9f3a0dd55e8373b6909abb156f4a
Reviewed-on: https://chromium-review.googlesource.com/959117
Commit-Queue: Luna Lu <loonybear@chromium.org>
Reviewed-by: Luna Lu <loonybear@chromium.org>
Cr-Commit-Position: refs/heads/master@{#542490}
[modify] https://crrev.com/c647daef87227415db5d5119b226c76c239030da/third_party/WebKit/LayoutTests/TestExpectations

The test seems to take a long time, even when passing.  Maybe the test can be broken down into smaller tests (or maybe we can add the test to third_party/WebKit/LayoutTests/SlowTests to ensure that it runs with an increased timeout).

For example, https://logs.chromium.org/v/?s=chromium%2Fbuildbucket%2Fcr-buildbucket.appspot.com%2F8952254027485862240%2F%2B%2Fsteps%2Fsite_per_process_webkit_layout_tests__with_patch_%2F0%2Fstdout says:

    10 slowest tests that are not marked as SLOW and did not timeout/crash:
    ...
    external/wpt/css/css-fonts/font-display/font-display.html took 5.3 seconds
    ...

(note that the default test timeout is 6 seconds).
Project Member

Comment 8 by bugdroid1@chromium.org, Mar 14 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/52fda21f2027d204c3a5c01cdf9a3ac4ad542d43

commit 52fda21f2027d204c3a5c01cdf9a3ac4ad542d43
Author: Kunihiko Sakamoto <ksakamoto@chromium.org>
Date: Wed Mar 14 08:22:46 2018

Mark external/wpt/css/css-fonts/font-display/font-display.html Slow

It takes at least 5 seconds. Marking it as SLOW to ensure that it runs
with an increased timeout.

NoTry: True
Bug: 816026
Change-Id: Ie6923678e945b05def57f93647ae69a97190da86
Reviewed-on: https://chromium-review.googlesource.com/961922
Commit-Queue: Kunihiko Sakamoto <ksakamoto@chromium.org>
Reviewed-by: Takashi Toyoshima <toyoshim@chromium.org>
Cr-Commit-Position: refs/heads/master@{#543028}
[modify] https://crrev.com/52fda21f2027d204c3a5c01cdf9a3ac4ad542d43/third_party/WebKit/LayoutTests/SlowTests
[modify] https://crrev.com/52fda21f2027d204c3a5c01cdf9a3ac4ad542d43/third_party/WebKit/LayoutTests/TestExpectations

 Issue 821003  has been merged into this issue.
Cc: ksakamoto@chromium.org
 Issue 564109  has been merged into this issue.

Sign in to add a comment