cautotest unlock should work when status is NULL |
||||
Issue descriptionIt's not supposed to be able to happen, but it can: https://crbug.com/811476 https://crbug.com/813830 If a DUT ends up locked with a reason of NULL, we can't unlock it. Since that happens once in a while, the unlock should be robust against it.
,
Mar 10 2018
Lucifer (job_aborter) marks DUT status as NULL (NULL means unknown in the relational model) as the DUT status is unknown if lucifer flat out dies (uncommon, but sporadically happens https://viceroy.corp.google.com/chromeos/lucifer) The host scheduler explicitly handles this as if the DUT is Ready. Yet another reason why null pointers/None is bad.
,
Mar 10 2018
I'm going to say P1 since it gets in the way of lab management.
,
Mar 26 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/third_party/autotest/+/7b930b58fafaa483b1d18151618601272a04a653 commit 7b930b58fafaa483b1d18151618601272a04a653 Author: Allen Li <ayatane@chromium.org> Date: Mon Mar 26 17:38:22 2018 [autotest] Use READY for abort instead of NULL Interestingly, though this is NULLable and there are NULL lookups in the host scheduler, NULL is not a valid value for host status on the Django validation side. NULL is interpreted identically to READY by the host scheduler, so use that instead. BUG= chromium:815380 TEST=None Change-Id: Icc7c4b2b334e2c9549e46d996929cd04d2261eb7 Reviewed-on: https://chromium-review.googlesource.com/976547 Commit-Ready: Allen Li <ayatane@chromium.org> Tested-by: Allen Li <ayatane@chromium.org> Reviewed-by: Richard Barnette <jrbarnette@google.com> [modify] https://crrev.com/7b930b58fafaa483b1d18151618601272a04a653/venv/lucifer/handoffs.py
,
Mar 26 2018
,
Mar 26 2018
The only creator of NULL status is gone now, and NULL is a transition state so if any DUTs have it, they should lose it in due time (after the change is pushed). |
||||
►
Sign in to add a comment |
||||
Comment 1 by dgarr...@chromium.org
, Feb 24 2018Summary: cautotest unlock should work when status is NULL (was: cautotest unlock should work when lock reason is NULL)