New issue
Advanced search Search tips

Issue 815376 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Feb 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug



Sign in to add a comment

power.CheckStatus fails on lab machines with batteries reporting more-than-full charges

Project Member Reported by derat@chromium.org, Feb 24 2018

Issue description

The power.CheckStatus test fails sometimes because it verifies that the battery charge reported in sysfs doesn't exceed the "full_charge" reported in sysfs.

From the elm job at http://pantheon/storage/browser/chromeos-autotest-results/178648467-chromeos-test/chromeos2-row7-rack7-host3/ :

2018/02/22 23:08:53 Started test power.CheckStatus
2018/02/22 23:08:53 [23:08:52.698] Error at check_status.go:37: Battery charge 3.8 exceeds full charge 2.0

Device: Line Power
  path:                    /sys/class/power_supply/CROS_USB_PD_CHARGER0
  online:                  yes
  type:                    USB_PD
  enum type:               AC
  voltage (V):             14.791
  current (A):             0
  max voltage (V):         15
  max current (A):         3
  active source:           CROS_USB_PD_CHARGER0
  available sources:       CROS_USB_PD_CHARGER0* [0/ff00]
  supports dual-role:      yes
Device: Battery
  path:                    /sys/class/power_supply/sbs-1-000b
  vendor:                  PANASONIC
  model name:              AP15O5L
  serial number:           080a
  state:                   Fully charged
  voltage (V):             12.473
  energy (Wh):             37.86
  energy rate (W):         0
  current (A):             0
  charge (Ah):             3.786
  full charge (Ah):        1.963
  full charge design (Ah): 4.67
  percentage:              100
  display percentage:      100
  technology:              Li-ion

See also veyron_minnie at http://pantheon/storage/browser/chromeos-autotest-results/178738578-chromeos-test/chromeos4-row9-rack10-host16/ :

Device: Line Power
  path:                    /sys/class/power_supply/gpio-charger
  online:                  yes
  type:                    Mains
  enum type:               AC
  voltage (V):             0
  current (A):             0
  max voltage (V):         0
  max current (A):         0
  active source:           gpio-charger
  available sources:       gpio-charger* [/]
  supports dual-role:      no
Device: Battery
  path:                    /sys/class/power_supply/bq27500-0
  vendor:                  Texas Instruments
  model name:              C100-80
  serial number:           
  state:                   Fully charged
  voltage (V):             4.283
  energy (Wh):             8.291
  energy rate (W):         0
  current (A):             0
  charge (Ah):             7.734
  full charge (Ah):        7.702
  full charge design (Ah): 8.06
  percentage:              100
  display percentage:      100
  technology:              Li-ion
 

Comment 1 by tbroch@chromium.org, Feb 24 2018

Agreed these seem like failures either w/ the battery on these particular DUTs or w/ the fuel gauge FW more generally.

Will probably need to disable the test for now or whitelist elm & minnie until someone has debugged those DUTs / devices further.

Comment 2 by derat@chromium.org, Feb 24 2018

Status: Started (was: Assigned)
I'll probably adjust the test to verify that charge and charge_full are both less than or equal to charge_full_design -- I haven't seen any devices where that doesn't hold (yet...).

Comment 3 by tbroch@chromium.org, Feb 24 2018

Unfortunately charge and charge_full can sometimes be greater than charge_full_design ... especially on new batteries.

Usually no more than +10% of full_design.
Project Member

Comment 4 by bugdroid1@chromium.org, Feb 24 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform/tast-tests/+/799b1c03d065c983e634b98c444f24b3f7f76c07

commit 799b1c03d065c983e634b98c444f24b3f7f76c07
Author: Daniel Erat <derat@chromium.org>
Date: Sat Feb 24 07:12:59 2018

tast-tests: Make power.CheckStatus allow weird charges.

Make the power.CheckStatus local test not check the battery
charge level. charge is sometimes higher than charge_full in
the lab.

BUG= chromium:815376 
TEST=ran it manually

Change-Id: I5688482b7420a53e5b73522af2afbb7410b87e55
Reviewed-on: https://chromium-review.googlesource.com/936008
Commit-Ready: Dan Erat <derat@chromium.org>
Tested-by: Dan Erat <derat@chromium.org>
Reviewed-by: Todd Broch <tbroch@chromium.org>

[modify] https://crrev.com/799b1c03d065c983e634b98c444f24b3f7f76c07/src/chromiumos/tast/local/bundles/cros/power/check_status.go

Comment 5 by derat@chromium.org, Feb 24 2018

Status: Fixed (was: Started)

Sign in to add a comment