New issue
Advanced search Search tips

Issue 815366 link

Starred by 1 user
Status: Verified
Owner:
eugene...@chromium.org
Closed: Feb 2018
Cc:
ios-bugs-priority@chromium.org
ios-bugs@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: iOS
Pri: 1
Type: Bug



Sign in to add a comment

Replacing download opens the second download manager infobar

Project Member Reported by eugene...@chromium.org, Feb 24 2018 
App Version (from "Chrome Settings > About Chrome"): ToT
iOS Version: All
Device: All

Steps to reproduce: 
1.) Enable new Download Manager in chrome://flags
2.) Load http://www.barebones.com/products/bbedit/download.html
3.) Tap Download
4.) Tap Download again
5.) Confirm starting new download 

Observed behavior: 
Second download infobar is opened

Expected behavior: 
Existing infobar UI should be updated with new download information
Project Member

Comment 1 by bugdroid1@chromium.org, Feb 26 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5c8f1b533e4de7a844f16fa58686b872401c1549

commit 5c8f1b533e4de7a844f16fa58686b872401c1549
Author: Eugene But <eugenebut@chromium.org>
Date: Mon Feb 26 22:44:22 2018

Gracefully handle download replacement.

DownloadManagerCoordinator should not present another view controller if
in existing download is replaced with a new download. Instead
coordinator should simply update the UI by setting new download task to
mediator.

Bug:  815366 
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: I0298b2be999be9acda3c200a8182ba425b318010
Reviewed-on: https://chromium-review.googlesource.com/935840
Commit-Queue: Eugene But <eugenebut@chromium.org>
Reviewed-by: Sylvain Defresne <sdefresne@chromium.org>
Cr-Commit-Position: refs/heads/master@{#539298}
[modify] https://crrev.com/5c8f1b533e4de7a844f16fa58686b872401c1549/ios/chrome/browser/ui/download/download_manager_coordinator.mm
[modify] https://crrev.com/5c8f1b533e4de7a844f16fa58686b872401c1549/ios/chrome/browser/ui/download/download_manager_coordinator_unittest.mm

Comment 2 by eugene...@chromium.org, Feb 26 2018

Status: Fixed (was: Started)

Comment 3 by rakurati@chromium.org, Mar 6 2018

Status: Verified (was: Fixed)
Verified on 66.0.3363.0 Canary in iPhone 7plus(iOS 10.3.3), iPad Air(iOS 10.3.3) and iPad Air(iOS 11.2.6)

Followed the steps mentioned in comment #0, existing infobar UI is being updated with the new download information

Link to video: 
https://drive.google.com/file/d/1oDX2Udj9qM2MLi3lSDafbZUGPmgjN8Eo/view?usp=sharing
►

Sign in to add a comment