[MacViewsBrowser] It's difficult to tell when a browser window is MacViews |
||
Issue descriptionChrome Version: 66.0.3353.0 OS: macOS Lately, it's gotten tricky to tell when Chrome is using MacViews browser windows. The windows should be marked somehow, but only in dev (channel-less) builds.
,
Mar 7 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/ee3d2348bb803c92328665a48b3b5d678f8a6602 commit ee3d2348bb803c92328665a48b3b5d678f8a6602 Author: Sidney San Martín <sdy@chromium.org> Date: Wed Mar 07 19:49:53 2018 Show "construction stripes" above MacViews browser windows Bug: 815361 Change-Id: If996ee8d38af8a07fb615eb422a816dfd9bd9963 Reviewed-on: https://chromium-review.googlesource.com/941909 Reviewed-by: Robert Sesek <rsesek@chromium.org> Commit-Queue: Sidney San Martín <sdy@chromium.org> Cr-Commit-Position: refs/heads/master@{#541534} [modify] https://crrev.com/ee3d2348bb803c92328665a48b3b5d678f8a6602/chrome/browser/ui/BUILD.gn [modify] https://crrev.com/ee3d2348bb803c92328665a48b3b5d678f8a6602/chrome/browser/ui/views/frame/browser_native_widget_window_mac.mm [add] https://crrev.com/ee3d2348bb803c92328665a48b3b5d678f8a6602/chrome/browser/ui/views/frame/macviews_under_construction_window_mac.h [add] https://crrev.com/ee3d2348bb803c92328665a48b3b5d678f8a6602/chrome/browser/ui/views/frame/macviews_under_construction_window_mac.mm
,
Mar 7 2018
,
Mar 14 2018
This is awesome -- I just built MacViews for the first time in ages this afternoon and laughed out loud when I saw this.
,
Mar 14 2018
\o/ |
||
►
Sign in to add a comment |
||
Comment 1 by sdy@chromium.org
, Mar 2 2018134 KB
134 KB View Download
80.1 KB
80.1 KB View Download