New issue
Advanced search Search tips

Issue 815359 link

Starred by 4 users

Issue metadata

Status: Verified
Owner:
Closed: Apr 2018
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Feature



Sign in to add a comment

termina: allow vmc to remove an existing VM

Project Member Reported by dgreid@chromium.org, Feb 24 2018

Issue description

let user remove vm disk image
 
Project Member

Comment 1 by bugdroid1@chromium.org, Mar 1 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform/system_api/+/f89c490da12c83ce9dbd1d43a10a5fd625a4507c

commit f89c490da12c83ce9dbd1d43a10a5fd625a4507c
Author: Dylan Reid <dgreid@chromium.org>
Date: Thu Mar 01 05:30:00 2018

vm_concierge: Add message to delete a vm disk

If a user wants to free up disk space or restart their VM from scratch
the existing disk needs to be deleted. Add a message to allow that.

BUG= 815359 
TEST=with other changes, vmc destroy <vm name>

Change-Id: I5131859c6a17d4332c9ecc8e97876029fd44e5aa
Reviewed-on: https://chromium-review.googlesource.com/935194
Commit-Ready: Dylan Reid <dgreid@chromium.org>
Tested-by: Dylan Reid <dgreid@chromium.org>
Reviewed-by: Stephen Barber <smbarber@chromium.org>

[modify] https://crrev.com/f89c490da12c83ce9dbd1d43a10a5fd625a4507c/dbus/vm_concierge/service.proto
[modify] https://crrev.com/f89c490da12c83ce9dbd1d43a10a5fd625a4507c/dbus/vm_concierge/dbus-constants.h

Project Member

Comment 2 by bugdroid1@chromium.org, Mar 2 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform2/+/04221ad52b540584af9ec9522a9cbaf142dabf40

commit 04221ad52b540584af9ec9522a9cbaf142dabf40
Author: Dylan Reid <dgreid@chromium.org>
Date: Fri Mar 02 00:13:13 2018

vm_tools: concierge: Add DestroyDiskImage

This will allow users to remove disk images they created with
CreateDiskImage.

CQ-DEPEND=CL:935194
BUG= 815359 
TEST=vmc destroy <vm name>

Change-Id: I1a3e3f8e920789ffed342070fc8ba5bd0d2f9296
Signed-off-by: Dylan Reid <dgreid@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/935923
Reviewed-by: Chirantan Ekbote <chirantan@chromium.org>

[modify] https://crrev.com/04221ad52b540584af9ec9522a9cbaf142dabf40/vm_tools/concierge/service.h
[modify] https://crrev.com/04221ad52b540584af9ec9522a9cbaf142dabf40/vm_tools/concierge/service.cc
[modify] https://crrev.com/04221ad52b540584af9ec9522a9cbaf142dabf40/vm_tools/concierge/client.cc

Labels: Proj-Containers
Labels: -Pri-1 Hotlist-Crostini-Platform Pri-2
Status: Verified (was: Started)

Sign in to add a comment