New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 815358 link

Starred by 6 users
Status: Fixed
Owner:
█ trchen@chromium.org
Last visit > 30 days ago
Closed: Mar 2018
Cc:
wangxianzhu@chromium.org
vmp...@chromium.org
nyerramilli@chromium.org
rbasuvula@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux
Pri: 1
Type: Bug-Regression

Blocking:
issue 771643



Sign in to add a comment

Ripple is Clipped in chrome://settings

Project Member Reported by hcarmona@chromium.org, Feb 24 2018 
Chrome Version       : 64.0.3282.167
OS Version: Linux. Did not test other platforms

What steps will reproduce the problem?
1. Navigate to chrome://settings
2. Use tab to focus an icon

What is the expected result?
Ripples should be round

What happens instead of that?
Ripples are clipped

Ran bisect tool:
https://chromium.googlesource.com/chromium/src/+log/7138892f3594182055e60b713494123f75f49b25..0fbd51f0347223bf09ae85d28fa34536c1dbb2db

Nothing is webui related, did a manual build w/ each revision.
Suspecting 0a9a5c3. See screenshots for e282ebc and 0a9a5c3.

I didn't test other OS's.

Please provide any additional information below. Attach a screenshot if
possible.
expected - e282ebc.png
51.7 KB View Download
actual - 0a9a5c3.png
51.6 KB View Download

Comment 1 by wangxianzhu@chromium.org, Feb 24 2018

Cc: wangxianzhu@chromium.org
Components: Blink>Paint
Owner: vmp...@chromium.org
Status: Assigned (was: Unconfirmed)
Might be related to  bug 814664 .

Comment 2 by wangxianzhu@chromium.org, Feb 26 2018

Cc: nyerramilli@chromium.org rbasuvula@chromium.org
 Issue 816399  has been merged into this issue.

Comment 3 by wangxianzhu@chromium.org, Feb 28 2018

Cc: trchen@chromium.org
I created a reduced test case.
Seems related to inconsistent pixel-snapping of clip mask.

vmpstr@ feel free to assign the bug to me if you have not started.
ripple.html
339 bytes View Download

Comment 4 by wangxianzhu@chromium.org, Mar 9 2018

Blocking: 771643
Labels: -M-66 -RegressedIn-66 M-67

Comment 5 by wangxianzhu@chromium.org, Mar 9 2018

Cc: -trchen@chromium.org vmp...@chromium.org
Owner: trchen@chromium.org
-> trchen@ for this clip mask bug. #c3 has the reduced test case.

Comment 6 by wangxianzhu@chromium.org, Mar 19 2018 

 Issue 822571  has been merged into this issue.

Comment 7 by wangxianzhu@chromium.org, Mar 19 2018 

 Issue 823200  has been merged into this issue.

Comment 8 by wangxianzhu@chromium.org, Mar 19 2018

Labels: -Type-Bug Target-67 RegressedIn-67 Type-Bug-Regression
Copy labels from the duplicate bugs.

Comment 9 by wangxianzhu@chromium.org, Mar 20 2018 

 Issue 823650  has been merged into this issue.
Project Member

Comment 10 by bugdroid1@chromium.org, Mar 27 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1aa123c1bc2c35f0b66a3457020a1a210f617798

commit 1aa123c1bc2c35f0b66a3457020a1a210f617798
Author: Tien-Ren Chen <trchen@chromium.org>
Date: Tue Mar 27 03:43:30 2018

[Blink/SPv175] Fix child clipping mask snapping bug

The clip rect calculated by PaintLayerClipper already included all
paint offset. We inadvertantly added paint offset again to child
clipping mask bounds prior to this CL, resulting in subpixel
accumulation being counted twice. This CL fixes it.

As a side change, this CL also creates paint offset translation
for composited replaced elements. Previously we only create paint
offset translation for composited blocks, which broken assumptions
in other part of the code.

BUG= 815358 , 808325 

Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
Change-Id: I17ca32d366942e12f9364a42205d6fc44171bf9c
Reviewed-on: https://chromium-review.googlesource.com/974161
Reviewed-by: Chris Harrelson <chrishtr@chromium.org>
Commit-Queue: Tien-Ren Chen <trchen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#545995}
[modify] https://crrev.com/1aa123c1bc2c35f0b66a3457020a1a210f617798/third_party/WebKit/LayoutTests/TestExpectations
[add] https://crrev.com/1aa123c1bc2c35f0b66a3457020a1a210f617798/third_party/WebKit/LayoutTests/compositing/overflow/border-radius-clip-subpixel-accumulation-expected.html
[add] https://crrev.com/1aa123c1bc2c35f0b66a3457020a1a210f617798/third_party/WebKit/LayoutTests/compositing/overflow/border-radius-clip-subpixel-accumulation.html
[modify] https://crrev.com/1aa123c1bc2c35f0b66a3457020a1a210f617798/third_party/WebKit/LayoutTests/platform/linux/fast/borders/border-radius-mask-canvas-all-expected.png
[modify] https://crrev.com/1aa123c1bc2c35f0b66a3457020a1a210f617798/third_party/WebKit/LayoutTests/platform/linux/fast/borders/border-radius-mask-canvas-with-mask-expected.png
[modify] https://crrev.com/1aa123c1bc2c35f0b66a3457020a1a210f617798/third_party/WebKit/LayoutTests/platform/linux/fast/borders/border-radius-mask-canvas-with-shadow-expected.png
[delete] https://crrev.com/79edda647add552849397a3d643505442febda8c/third_party/WebKit/LayoutTests/platform/mac-mac10.12/virtual/prefer_compositing_to_lcd_text/compositing/overflow/border-radius-composited-subframe-expected.png
[modify] https://crrev.com/1aa123c1bc2c35f0b66a3457020a1a210f617798/third_party/WebKit/LayoutTests/platform/mac/compositing/overflow/border-radius-composited-subframe-expected.png
[modify] https://crrev.com/1aa123c1bc2c35f0b66a3457020a1a210f617798/third_party/WebKit/LayoutTests/platform/mac/fast/borders/border-radius-mask-canvas-all-expected.png
[modify] https://crrev.com/1aa123c1bc2c35f0b66a3457020a1a210f617798/third_party/WebKit/LayoutTests/platform/mac/fast/borders/border-radius-mask-canvas-with-mask-expected.png
[modify] https://crrev.com/1aa123c1bc2c35f0b66a3457020a1a210f617798/third_party/WebKit/LayoutTests/platform/mac/fast/borders/border-radius-mask-canvas-with-shadow-expected.png
[modify] https://crrev.com/1aa123c1bc2c35f0b66a3457020a1a210f617798/third_party/WebKit/LayoutTests/platform/win/compositing/overflow/border-radius-composited-subframe-expected.png
[modify] https://crrev.com/1aa123c1bc2c35f0b66a3457020a1a210f617798/third_party/WebKit/LayoutTests/platform/win/fast/borders/border-radius-mask-canvas-all-expected.png
[modify] https://crrev.com/1aa123c1bc2c35f0b66a3457020a1a210f617798/third_party/WebKit/LayoutTests/platform/win/fast/borders/border-radius-mask-canvas-with-mask-expected.png
[modify] https://crrev.com/1aa123c1bc2c35f0b66a3457020a1a210f617798/third_party/WebKit/LayoutTests/platform/win/fast/borders/border-radius-mask-canvas-with-shadow-expected.png
[modify] https://crrev.com/1aa123c1bc2c35f0b66a3457020a1a210f617798/third_party/WebKit/Source/core/paint/PaintLayerPainter.cpp
[modify] https://crrev.com/1aa123c1bc2c35f0b66a3457020a1a210f617798/third_party/WebKit/Source/core/paint/PaintPropertyTreeBuilder.cpp
[modify] https://crrev.com/1aa123c1bc2c35f0b66a3457020a1a210f617798/third_party/WebKit/Source/core/paint/PaintPropertyTreeBuilderTest.cpp

Comment 11 by trchen@chromium.org, Mar 27 2018

Status: Fixed (was: Assigned)
►

Sign in to add a comment