New issue
Advanced search Search tips

Issue 815357 link

Starred by 1 user

Issue metadata

Status: Verified
Owner:
Closed: Mar 2018
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug
Build-Toolchain

Blocked on:
issue 820140
issue 822807



Sign in to add a comment

Update llvm to a newer version

Project Member Reported by manojgupta@chromium.org, Feb 24 2018

Issue description

Update the llvm version in Chrome OS to a newer version for R67 branch.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Feb 24 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/overlays/chromiumos-overlay/+/159674af91b97cc18bb55f7473bf6481149b90bf

commit 159674af91b97cc18bb55f7473bf6481149b90bf
Author: Manoj Gupta <manojgupta@google.com>
Date: Sat Feb 24 05:07:11 2018

Mask llvm-7.0 from targets.

Prepare for llvm-7.0 roll.
Mask llvm-7.0-pre* ebuilds from installation on target boards.

BUG= chromium:815357 
TEST=Locally upreved llvm wasn't picked for target installation.

Change-Id: If63232a1017c0b585dc28e2700eb93e4097277e5
Reviewed-on: https://chromium-review.googlesource.com/935190
Commit-Ready: Manoj Gupta <manojgupta@chromium.org>
Tested-by: Manoj Gupta <manojgupta@chromium.org>
Reviewed-by: Yunlian Jiang <yunlian@chromium.org>
Reviewed-by: Mike Frysinger <vapier@chromium.org>

[modify] https://crrev.com/159674af91b97cc18bb55f7473bf6481149b90bf/profiles/targets/chromeos/package.mask

Project Member

Comment 2 by bugdroid1@chromium.org, Mar 1 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/overlays/chromiumos-overlay/+/22d70eb5d27ad064f0cf7b4b9d1f1cde8cfdafbf

commit 22d70eb5d27ad064f0cf7b4b9d1f1cde8cfdafbf
Author: Manoj Gupta <manojgupta@google.com>
Date: Thu Mar 01 05:30:08 2018

llvm-next: Update to r324073.

Update llvm-next to r324073.
Does not impact the current llvm version used in Chrome OS.
Also update compiler-rt ebuild to install the libraries in both 6.0.0
and 7.0.0 clang directories to make it work with llvm-next builders.

BUG= chromium:815357 
TEST=No new warnings on samus/elm builders.

Change-Id: I05dcf5d929b3abd8c643e1bf0acf2e1369e91d31
Reviewed-on: https://chromium-review.googlesource.com/941981
Commit-Ready: Manoj Gupta <manojgupta@chromium.org>
Tested-by: Manoj Gupta <manojgupta@chromium.org>
Reviewed-by: Manoj Gupta <manojgupta@chromium.org>
Reviewed-by: Rahul Chaudhry <rahulchaudhry@chromium.org>

[rename] https://crrev.com/22d70eb5d27ad064f0cf7b4b9d1f1cde8cfdafbf/sys-libs/compiler-rt/compiler-rt-6.0_pre321490-r3.ebuild
[rename] https://crrev.com/22d70eb5d27ad064f0cf7b4b9d1f1cde8cfdafbf/sys-devel/llvm/llvm-6.0_pre321490_p20180131-r5.ebuild
[rename] https://crrev.com/22d70eb5d27ad064f0cf7b4b9d1f1cde8cfdafbf/sys-devel/lld/lld-6.0_pre321490-r2.ebuild

Project Member

Comment 3 by bugdroid1@chromium.org, Mar 2 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/overlays/chromiumos-overlay/+/0878ab51d4bf76fe71a10b121630594b9fcd0c58

commit 0878ab51d4bf76fe71a10b121630594b9fcd0c58
Author: Manoj Gupta <manojgupta@google.com>
Date: Fri Mar 02 03:13:45 2018

llvm-next: Fix a hang in building cmake.

Pick an upstream CL 324252 to fix an infinite loop when building cmake.
Does not impact current llvm used in Chrome OS.

Upstream CL description.

commit 16748767563bb9bcb1e1c3e42c35d44924d464d0
Author: Sanjay Patel <spatel@rotateright.com>
Date:   Mon Feb 5 17:16:50 2018 +0000

    [InstCombine] only allow narrow/wide evaluation of values with >1 use if that user is a binop

    There was a logic hole in D42739 / rL324014 because we're not accounting for select and phi
    instructions that might have repeated operands. This is likely a source of an infinite loop.
    I haven't manufactured a test case to prove that, but it should be safe to speculatively limit
    this transform to binops while we try to create that test.

BUG= chromium:815357 
TEST=cmake builds.

Change-Id: Id392d5478c50bfb02d1d1aeb5d9d2d8ebf29be1c
Reviewed-on: https://chromium-review.googlesource.com/942681
Commit-Ready: Manoj Gupta <manojgupta@chromium.org>
Tested-by: Manoj Gupta <manojgupta@chromium.org>
Reviewed-by: Yunlian Jiang <yunlian@chromium.org>

[add] https://crrev.com/0878ab51d4bf76fe71a10b121630594b9fcd0c58/sys-devel/llvm/files/cherry/16748767563bb9bcb1e1c3e42c35d44924d464d0.patch
[rename] https://crrev.com/0878ab51d4bf76fe71a10b121630594b9fcd0c58/sys-devel/llvm/llvm-6.0_pre321490_p20180131-r6.ebuild

Blockedon: 820140
Project Member

Comment 5 by bugdroid1@chromium.org, Mar 10 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/overlays/chromiumos-overlay/+/20d214bc1b568d202de358041734f83ab3eb6bf0

commit 20d214bc1b568d202de358041734f83ab3eb6bf0
Author: Manoj Gupta <manojgupta@google.com>
Date: Sat Mar 10 06:59:17 2018

llvm-next: Cherry-pick 4 upstream CLs.

Cherry-pick 4 CLs to fix various issues. These are cherry-picked to
Chrome OS's llvm-next only. Does not impact the current llvm
version used.

CL descriptions:

commit 284236c047631c8b0eabac3ddd3d0c95253f4361
Author: Manoj Gupta <manojgupta@google.com>
Date:   Fri Mar 2 23:52:44 2018 +0000

    Do not generate calls to fentry with __attribute__((no_instrument_function))

commit 30f9051d7d8b6f56c8149fd1bdcc714285f77527
Author: Dan Albert <danalbert@google.com>
Date:   Wed Feb 21 22:36:51 2018 +0000

    [Driver] Generate .eh_frame_hdr for static executables too.

commit 98079e294f718c14d25ccf30ab2b1938780ffe4d
Author: Florian Hahn <florian.hahn@arm.com>
Date:   Fri Mar 2 13:02:55 2018 +0000

    [ARM] Fix codegen for VLD3/VLD4/VST3/VST4 with WB

commit ffaaef68dbab0e872c0e6013836170bb78705a81
Author: Reid Kleckner <rnk@google.com>
Date:   Tue Feb 6 00:47:14 2018 +0000

    Revert "Don't assume a null GV is local for ELF and MachO."

BUG= chromium:820140 
BUG= chromium:815357 
BUG=b:74090329

TEST="USE=llvm-next" sudo emerge  llvm works.

Change-Id: I67d2215dd47dc9ada2381b8817b485c9f8a0d107
Reviewed-on: https://chromium-review.googlesource.com/957474
Commit-Ready: Manoj Gupta <manojgupta@chromium.org>
Tested-by: Manoj Gupta <manojgupta@chromium.org>
Reviewed-by: Yunlian Jiang <yunlian@chromium.org>

[add] https://crrev.com/20d214bc1b568d202de358041734f83ab3eb6bf0/sys-devel/llvm/files/cherry/30f9051d7d8b6f56c8149fd1bdcc714285f77527.patch
[add] https://crrev.com/20d214bc1b568d202de358041734f83ab3eb6bf0/sys-devel/llvm/files/cherry/98079e294f718c14d25ccf30ab2b1938780ffe4d.patch
[add] https://crrev.com/20d214bc1b568d202de358041734f83ab3eb6bf0/sys-devel/llvm/files/cherry/284236c047631c8b0eabac3ddd3d0c95253f4361.patch
[rename] https://crrev.com/20d214bc1b568d202de358041734f83ab3eb6bf0/sys-devel/llvm/llvm-6.0_pre321490_p20180131-r7.ebuild
[add] https://crrev.com/20d214bc1b568d202de358041734f83ab3eb6bf0/sys-devel/llvm/files/cherry/ffaaef68dbab0e872c0e6013836170bb78705a81.patch

Blockedon: 822334
Blockedon: -822334
Project Member

Comment 8 by bugdroid1@chromium.org, Mar 15 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/toolchain-utils/+/26391dbdf9a49ff414f00839e0ea70e7ef0f7e73

commit 26391dbdf9a49ff414f00839e0ea70e7ef0f7e73
Author: Manoj Gupta <manojgupta@google.com>
Date: Thu Mar 15 21:08:03 2018

toolchain testing: Switch to different boards with better availability.

Replace some testing boards with other boards in same platform
that have better availability in pool:suites.

BUG= chromium:815357 
TEST=None

Change-Id: Icf89f00462479b5b34695442995fe5f3e3776ebd
Reviewed-on: https://chromium-review.googlesource.com/964702
Commit-Queue: Manoj Gupta <manojgupta@chromium.org>
Tested-by: Manoj Gupta <manojgupta@chromium.org>
Trybot-Ready: Manoj Gupta <manojgupta@chromium.org>
Reviewed-by: Rahul Chaudhry <rahulchaudhry@chromium.org>

[modify] https://crrev.com/26391dbdf9a49ff414f00839e0ea70e7ef0f7e73/buildbot_test_llvm.py

Blockedon: 822807
Project Member

Comment 10 by bugdroid1@chromium.org, Mar 17 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/overlays/chromiumos-overlay/+/4545e335f8d5045850df6f74f9ee641c0968a4d4

commit 4545e335f8d5045850df6f74f9ee641c0968a4d4
Author: Manoj Gupta <manojgupta@google.com>
Date: Sat Mar 17 22:44:36 2018

llvm-next: Cherry-pick CL r327761.

Pick CL r327761 to avoid some mysterious miscompilations
reported in b/74077219.

CL description:
commit 2755819705e9c2116f4ef72e1273303c6a56c520
Author: Chandler Carruth <chandlerc@gmail.com>
Date:   Fri Mar 16 23:51:33 2018 +0000

    [GlobalsAA] Fix a pretty terrible bug that has been in GlobalsAA for
    a long time.

BUG= chromium:815357 
TEST=USE="llvm-next" sudo emerge llvm works.

Change-Id: Ia2f55569e9830b9a4e9d4302371fd2a0e3437c34
Reviewed-on: https://chromium-review.googlesource.com/967384
Commit-Queue: Manoj Gupta <manojgupta@chromium.org>
Tested-by: Manoj Gupta <manojgupta@chromium.org>
Trybot-Ready: Manoj Gupta <manojgupta@chromium.org>
Reviewed-by: Manoj Gupta <manojgupta@chromium.org>

[add] https://crrev.com/4545e335f8d5045850df6f74f9ee641c0968a4d4/sys-devel/llvm/files/cherry/2755819705e9c2116f4ef72e1273303c6a56c520.patch
[rename] https://crrev.com/4545e335f8d5045850df6f74f9ee641c0968a4d4/sys-devel/llvm/llvm-6.0_pre321490_p20180131-r10.ebuild

Project Member

Comment 11 by bugdroid1@chromium.org, Mar 20 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/overlays/chromiumos-overlay/+/30e5cf7244ded884163b79d4e7f468af5a888a00

commit 30e5cf7244ded884163b79d4e7f468af5a888a00
Author: Manoj Gupta <manojgupta@google.com>
Date: Tue Mar 20 00:32:38 2018

llvm: Update to r326829.

Updated llvm in Chrome OS to r326829.

Testing data:
https://docs.google.com/spreadsheets/d/15OglM4ZesJ-9YPAPezl7MO4e0GbfClL39l_fZdEBLN0/edit?usp=sharing

BUG= chromium:815357 
TEST=Testing data above.

Change-Id: I83608825a91985474c4e4763be742b64d1c3a84d
Reviewed-on: https://chromium-review.googlesource.com/967861
Tested-by: Manoj Gupta <manojgupta@chromium.org>
Trybot-Ready: Manoj Gupta <manojgupta@chromium.org>
Reviewed-by: Rahul Chaudhry <rahulchaudhry@chromium.org>

[delete] https://crrev.com/36bb38cfd1a511fbe99828066464e25572738cef/sys-devel/llvm/files/cherry/771594b9ab02241dec7c254f490eb701b62de070.patch
[delete] https://crrev.com/36bb38cfd1a511fbe99828066464e25572738cef/sys-devel/llvm/files/cherry/43849be6e44493d485401aac5b62484e36bd2864.patch
[delete] https://crrev.com/36bb38cfd1a511fbe99828066464e25572738cef/sys-devel/llvm/files/cherry/197917a303a397db80df6f71246490ad5cf23228.patch
[delete] https://crrev.com/36bb38cfd1a511fbe99828066464e25572738cef/sys-devel/llvm/files/cherry/61c5605f601c14b58d9697c7b625f2082daed65d.patch
[delete] https://crrev.com/36bb38cfd1a511fbe99828066464e25572738cef/sys-devel/llvm/files/cherry/fd5a8723ce9f2a6b250e85972ef859e4253ea95d.patch
[delete] https://crrev.com/36bb38cfd1a511fbe99828066464e25572738cef/sys-devel/lld/files/cherry/17b90924dbf7eb14c591d72d4e360d77b87fdefc.patch
[delete] https://crrev.com/36bb38cfd1a511fbe99828066464e25572738cef/sys-devel/llvm/files/cherry/d09d7393dda2a6afe77b58a3db0bf046f8d2c2b3.patch
[delete] https://crrev.com/36bb38cfd1a511fbe99828066464e25572738cef/sys-devel/lld/files/cherry/cb6934a621f04652dda0be611ec298877b1d8e14.patch
[delete] https://crrev.com/36bb38cfd1a511fbe99828066464e25572738cef/sys-devel/llvm/files/cherry/0d816739a82da29748caf88570affb9715e18b69.patch
[rename] https://crrev.com/30e5cf7244ded884163b79d4e7f468af5a888a00/sys-devel/lld/lld-7.0_pre326829.ebuild
[rename] https://crrev.com/30e5cf7244ded884163b79d4e7f468af5a888a00/sys-libs/compiler-rt/compiler-rt-7.0_pre326829.ebuild
[delete] https://crrev.com/36bb38cfd1a511fbe99828066464e25572738cef/sys-devel/llvm/files/cherry/1e7ad1c95ade6d20d3e0544772e55e45d2e6edb9.patch
[delete] https://crrev.com/36bb38cfd1a511fbe99828066464e25572738cef/sys-devel/llvm/files/cherry/e4eed790f8967cc92fc03fa2cf9183c6b03b3428.patch
[delete] https://crrev.com/36bb38cfd1a511fbe99828066464e25572738cef/sys-devel/llvm/files/cherry/59b64490fda69d29bb42cfdf7eec37bcc31ff833.patch
[rename] https://crrev.com/30e5cf7244ded884163b79d4e7f468af5a888a00/sys-devel/clang/clang-7.0_pre326829_p20180318.ebuild
[rename] https://crrev.com/30e5cf7244ded884163b79d4e7f468af5a888a00/sys-devel/llvm/llvm-7.0_pre326829_p20180318.ebuild

Project Member

Comment 12 by bugdroid1@chromium.org, Mar 26 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/chromite/+/5ba7bb8a90ce47c54a1514cfd0e80d84829b3643

commit 5ba7bb8a90ce47c54a1514cfd0e80d84829b3643
Author: Manoj Gupta <manojgupta@google.com>
Date: Mon Mar 26 21:41:27 2018

generic_stages: temporarily ignore all target prebuilts.

Ignore the target prebuilts and rebuild packages from source.

This is a temporary CL. Revert this CL once in has participated in
a green CQ run. This process is documented at:

https://sites.google.com/a/google.com/chromeos/for-team-members/infrastructure/chromeos-admin/clear_binaries

BUG= chromium:815357 
TEST='./cbuildbot/run_tests' passed.

Change-Id: I692dd082b86fe4f5c077c33ff31ac35a90dde0d3
Reviewed-on: https://chromium-review.googlesource.com/979697
Commit-Ready: Manoj Gupta <manojgupta@chromium.org>
Tested-by: Manoj Gupta <manojgupta@chromium.org>
Reviewed-by: Aviv Keshet <akeshet@chromium.org>

[modify] https://crrev.com/5ba7bb8a90ce47c54a1514cfd0e80d84829b3643/cbuildbot/config_dump.json
[modify] https://crrev.com/5ba7bb8a90ce47c54a1514cfd0e80d84829b3643/lib/sysroot_lib.py
[modify] https://crrev.com/5ba7bb8a90ce47c54a1514cfd0e80d84829b3643/cbuildbot/stages/build_stages_unittest.py
[modify] https://crrev.com/5ba7bb8a90ce47c54a1514cfd0e80d84829b3643/cbuildbot/stages/generic_stages.py
[modify] https://crrev.com/5ba7bb8a90ce47c54a1514cfd0e80d84829b3643/lib/config_lib.py

Project Member

Comment 13 by bugdroid1@chromium.org, Mar 26 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/chromite/+/6aab402bbddc03b02fc2557220c2771250e285f4

commit 6aab402bbddc03b02fc2557220c2771250e285f4
Author: Manoj Gupta <manojgupta@chromium.org>
Date: Mon Mar 26 21:59:02 2018

Revert "generic_stages: temporarily ignore all target prebuilts."

This reverts commit 5ba7bb8a90ce47c54a1514cfd0e80d84829b3643.

Reason for revert: CQ had a green run, new prebuilts were uploaded.

Original change's description:
> generic_stages: temporarily ignore all target prebuilts.
> 
> Ignore the target prebuilts and rebuild packages from source.
> 
> This is a temporary CL. Revert this CL once in has participated in
> a green CQ run. This process is documented at:
> 
> https://sites.google.com/a/google.com/chromeos/for-team-members/infrastructure/chromeos-admin/clear_binaries
> 
> BUG= chromium:815357 
> TEST='./cbuildbot/run_tests' passed.
> 
> Change-Id: I692dd082b86fe4f5c077c33ff31ac35a90dde0d3
> Reviewed-on: https://chromium-review.googlesource.com/979697
> Commit-Ready: Manoj Gupta <manojgupta@chromium.org>
> Tested-by: Manoj Gupta <manojgupta@chromium.org>
> Reviewed-by: Aviv Keshet <akeshet@chromium.org>

Bug:  chromium:815357 
Change-Id: Id1d5c7eda3549dd0d5f48041e919fc45adde1348
Reviewed-on: https://chromium-review.googlesource.com/981015
Reviewed-by: Manoj Gupta <manojgupta@chromium.org>
Commit-Queue: Manoj Gupta <manojgupta@chromium.org>
Tested-by: Manoj Gupta <manojgupta@chromium.org>

[modify] https://crrev.com/6aab402bbddc03b02fc2557220c2771250e285f4/cbuildbot/config_dump.json
[modify] https://crrev.com/6aab402bbddc03b02fc2557220c2771250e285f4/lib/sysroot_lib.py
[modify] https://crrev.com/6aab402bbddc03b02fc2557220c2771250e285f4/cbuildbot/stages/build_stages_unittest.py
[modify] https://crrev.com/6aab402bbddc03b02fc2557220c2771250e285f4/cbuildbot/stages/generic_stages.py
[modify] https://crrev.com/6aab402bbddc03b02fc2557220c2771250e285f4/lib/config_lib.py

Status: Verified (was: Untriaged)
Project Member

Comment 15 by bugdroid1@chromium.org, Mar 27 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/01fd5476c3e062e2dd059b829e876b966a4365ef

commit 01fd5476c3e062e2dd059b829e876b966a4365ef
Author: chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Date: Tue Mar 27 03:45:41 2018

Roll src/third_party/chromite/ 44123785c..6aab402bb (2 commits)

https://chromium.googlesource.com/chromiumos/chromite.git/+log/44123785ca9a..6aab402bbddc

$ git log 44123785c..6aab402bb --date=short --no-merges --format='%ad %ae %s'
2018-03-26 manojgupta Revert "generic_stages: temporarily ignore all target prebuilts."
2018-03-25 manojgupta generic_stages: temporarily ignore all target prebuilts.

Created with:
  roll-dep src/third_party/chromite
BUG= chromium:815357 , chromium:815357 


The AutoRoll server is located here: https://chromite-chromium-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=chrome-os-gardeners@chromium.org

Change-Id: Ia41806216c37f2f0422416d84978bf59da15d86c
Reviewed-on: https://chromium-review.googlesource.com/981600
Reviewed-by: Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#545999}
[modify] https://crrev.com/01fd5476c3e062e2dd059b829e876b966a4365ef/DEPS

Sign in to add a comment