New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 815334 link

Starred by 1 user
Status: Assigned
Owner:
jamescook@chromium.org
Cc:
█ sashab@chromium.org
mustash-bugs@google.com
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug

Blocked on:
issue 817307


Sign in to add a comment

Move ash UI modules and mojo apps into //ash/components

Project Member Reported by jamescook@chromium.org, Feb 23 2018 
See go/cros-ash-components

Clean up //ui/chromeos and //mash.

//ui/chromeos/ksv -> //ash/components/shortcut_viewer
//ash/autoclick/mus -> //ash/components/autoclick
//mash/quick_launch -> //ash/components/quick_launch
etc.

//ash/components has DEPS with noparent, -ash, -chrome. Components should be isolated from ash and isolated from each other.

//ash/components/foo goes in namespace foo not namespace ash.

Comment 1 by lafo...@chromium.org, Feb 26 2018

Components: -Internals>MUS Internals>Services>WindowService
Project Member

Comment 2 by bugdroid1@chromium.org, Feb 27 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a4bdde39385f55317aefabc07d5cdfe79c6a1667

commit a4bdde39385f55317aefabc07d5cdfe79c6a1667
Author: James Cook <jamescook@chromium.org>
Date: Tue Feb 27 00:21:39 2018

cros: Move autoclick mojo app into //ash/components

This is an existing example of how a built-in ash feature can be done
with a mojo app, so put it in //ash/components.

Bug: 815334
Test: ash_unittests, autoclick still works in mash
Change-Id: I1d38901a96708cbd2d3fc17c39f66e537851a61b
Reviewed-on: https://chromium-review.googlesource.com/935755
Reviewed-by: Tom Sepez <tsepez@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Commit-Queue: James Cook <jamescook@chromium.org>
Cr-Commit-Position: refs/heads/master@{#539337}
[modify] https://crrev.com/a4bdde39385f55317aefabc07d5cdfe79c6a1667/ash/BUILD.gn
[modify] https://crrev.com/a4bdde39385f55317aefabc07d5cdfe79c6a1667/ash/DEPS
[modify] https://crrev.com/a4bdde39385f55317aefabc07d5cdfe79c6a1667/ash/accessibility/accessibility_controller.cc
[rename] https://crrev.com/a4bdde39385f55317aefabc07d5cdfe79c6a1667/ash/components/autoclick/BUILD.gn
[rename] https://crrev.com/a4bdde39385f55317aefabc07d5cdfe79c6a1667/ash/components/autoclick/DEPS
[rename] https://crrev.com/a4bdde39385f55317aefabc07d5cdfe79c6a1667/ash/components/autoclick/OWNERS
[rename] https://crrev.com/a4bdde39385f55317aefabc07d5cdfe79c6a1667/ash/components/autoclick/autoclick_application.cc
[rename] https://crrev.com/a4bdde39385f55317aefabc07d5cdfe79c6a1667/ash/components/autoclick/autoclick_application.h
[rename] https://crrev.com/a4bdde39385f55317aefabc07d5cdfe79c6a1667/ash/components/autoclick/main.cc
[rename] https://crrev.com/a4bdde39385f55317aefabc07d5cdfe79c6a1667/ash/components/autoclick/manifest.json
[rename] https://crrev.com/a4bdde39385f55317aefabc07d5cdfe79c6a1667/ash/components/autoclick/public/mojom/BUILD.gn
[rename] https://crrev.com/a4bdde39385f55317aefabc07d5cdfe79c6a1667/ash/components/autoclick/public/mojom/OWNERS
[rename] https://crrev.com/a4bdde39385f55317aefabc07d5cdfe79c6a1667/ash/components/autoclick/public/mojom/autoclick.mojom
[modify] https://crrev.com/a4bdde39385f55317aefabc07d5cdfe79c6a1667/ash/manifest.json
[modify] https://crrev.com/a4bdde39385f55317aefabc07d5cdfe79c6a1667/chrome/app/BUILD.gn
[modify] https://crrev.com/a4bdde39385f55317aefabc07d5cdfe79c6a1667/chrome/browser/chrome_content_browser_manifest_overlay.json
[modify] https://crrev.com/a4bdde39385f55317aefabc07d5cdfe79c6a1667/chrome/browser/mash_service_registry.cc
[modify] https://crrev.com/a4bdde39385f55317aefabc07d5cdfe79c6a1667/chrome/utility/BUILD.gn
[modify] https://crrev.com/a4bdde39385f55317aefabc07d5cdfe79c6a1667/chrome/utility/DEPS
[modify] https://crrev.com/a4bdde39385f55317aefabc07d5cdfe79c6a1667/chrome/utility/mash_service_factory.cc
[modify] https://crrev.com/a4bdde39385f55317aefabc07d5cdfe79c6a1667/mash/BUILD.gn
Project Member

Comment 3 by bugdroid1@chromium.org, Feb 27 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2268befd4be8ba57ac2c9081c1280e8b47594b29

commit 2268befd4be8ba57ac2c9081c1280e8b47594b29
Author: James Cook <jamescook@chromium.org>
Date: Tue Feb 27 01:12:16 2018

cros: Move touch_hud mojo app into //ash/components

This is a good example mojo mini-app that runs as part of ash.
Move it next to the other mini-apps (quick launch, autoclick).

No functional changes.

Bug: 815334
Test: ash_unittests, run chrome --enable-features=Mash --show-taps
Change-Id: I0044213d3d67c54d97c98ede3526bc33c3e48219
Reviewed-on: https://chromium-review.googlesource.com/937988
Commit-Queue: James Cook <jamescook@chromium.org>
Reviewed-by: Tom Sepez <tsepez@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Cr-Commit-Position: refs/heads/master@{#539359}
[modify] https://crrev.com/2268befd4be8ba57ac2c9081c1280e8b47594b29/ash/BUILD.gn
[rename] https://crrev.com/2268befd4be8ba57ac2c9081c1280e8b47594b29/ash/components/touch_hud/BUILD.gn
[rename] https://crrev.com/2268befd4be8ba57ac2c9081c1280e8b47594b29/ash/components/touch_hud/DEPS
[rename] https://crrev.com/2268befd4be8ba57ac2c9081c1280e8b47594b29/ash/components/touch_hud/OWNERS
[rename] https://crrev.com/2268befd4be8ba57ac2c9081c1280e8b47594b29/ash/components/touch_hud/main.cc
[rename] https://crrev.com/2268befd4be8ba57ac2c9081c1280e8b47594b29/ash/components/touch_hud/manifest.json
[rename] https://crrev.com/2268befd4be8ba57ac2c9081c1280e8b47594b29/ash/components/touch_hud/touch_hud_application.cc
[rename] https://crrev.com/2268befd4be8ba57ac2c9081c1280e8b47594b29/ash/components/touch_hud/touch_hud_application.h
[modify] https://crrev.com/2268befd4be8ba57ac2c9081c1280e8b47594b29/ash/manifest.json
[modify] https://crrev.com/2268befd4be8ba57ac2c9081c1280e8b47594b29/ash/shell.cc
[modify] https://crrev.com/2268befd4be8ba57ac2c9081c1280e8b47594b29/ash/standalone/manifest.json
[modify] https://crrev.com/2268befd4be8ba57ac2c9081c1280e8b47594b29/chrome/app/BUILD.gn
[modify] https://crrev.com/2268befd4be8ba57ac2c9081c1280e8b47594b29/chrome/browser/mash_service_registry.cc
[modify] https://crrev.com/2268befd4be8ba57ac2c9081c1280e8b47594b29/chrome/utility/BUILD.gn
[modify] https://crrev.com/2268befd4be8ba57ac2c9081c1280e8b47594b29/chrome/utility/DEPS
[modify] https://crrev.com/2268befd4be8ba57ac2c9081c1280e8b47594b29/chrome/utility/mash_service_factory.cc
[modify] https://crrev.com/2268befd4be8ba57ac2c9081c1280e8b47594b29/mash/BUILD.gn
Project Member

Comment 4 by bugdroid1@chromium.org, Feb 27 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/bc2a054251804074b3cef57ddf5237ba3c75c784

commit bc2a054251804074b3cef57ddf5237ba3c75c784
Author: James Cook <jamescook@chromium.org>
Date: Tue Feb 27 01:53:03 2018

cros: Rename QuickLaunch to QuickLaunchApplication

For consistency with TouchHudApplication and AutoclickApplication.

Rename the mojo app to quick_launch_app for consistency with
touch_hud_app and autoclick_app.

This is part of getting //ash/components to have good examples.

Bug: 815334
Test: compiles
Change-Id: Ib02eb512a4da9a447611342c994cf25cee5d3139
Reviewed-on: https://chromium-review.googlesource.com/938148
Commit-Queue: James Cook <jamescook@chromium.org>
Reviewed-by: Tom Sepez <tsepez@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Cr-Commit-Position: refs/heads/master@{#539369}
[modify] https://crrev.com/bc2a054251804074b3cef57ddf5237ba3c75c784/ash/BUILD.gn
[modify] https://crrev.com/bc2a054251804074b3cef57ddf5237ba3c75c784/ash/components/quick_launch/BUILD.gn
[modify] https://crrev.com/bc2a054251804074b3cef57ddf5237ba3c75c784/ash/components/quick_launch/main.cc
[modify] https://crrev.com/bc2a054251804074b3cef57ddf5237ba3c75c784/ash/components/quick_launch/manifest.json
[modify] https://crrev.com/bc2a054251804074b3cef57ddf5237ba3c75c784/ash/components/quick_launch/public/mojom/constants.mojom
[rename] https://crrev.com/bc2a054251804074b3cef57ddf5237ba3c75c784/ash/components/quick_launch/quick_launch_application.cc
[rename] https://crrev.com/bc2a054251804074b3cef57ddf5237ba3c75c784/ash/components/quick_launch/quick_launch_application.h
[modify] https://crrev.com/bc2a054251804074b3cef57ddf5237ba3c75c784/chrome/browser/DEPS
[modify] https://crrev.com/bc2a054251804074b3cef57ddf5237ba3c75c784/chrome/utility/DEPS
[modify] https://crrev.com/bc2a054251804074b3cef57ddf5237ba3c75c784/chrome/utility/mash_service_factory.cc
[modify] https://crrev.com/bc2a054251804074b3cef57ddf5237ba3c75c784/mash/BUILD.gn
[modify] https://crrev.com/bc2a054251804074b3cef57ddf5237ba3c75c784/mash/session/BUILD.gn

Comment 5 by sashab@chromium.org, Feb 28 2018

Blockedon: 817307

Comment 6 by jamescook@chromium.org, Apr 19 2018

Components: -Internals>Services>WindowService Internals>Services>Ash
Labels: -Proj-Mustash-Mash

Comment 7 by jamescook@chromium.org, May 22 2018

Status: Assigned (was: Started)
On hold. I think //mash/task_viewer is the last one to move.

I would not move existing webui stuff (like //ui/file_manager) -- there's not much value. However, I would build new webui things in //ash/components.
►

Sign in to add a comment