New issue
Advanced search Search tips

Issue 815295 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Mar 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Bug

Blocked on:
issue 812485



Sign in to add a comment

Set up a new bot for slow-running traffic annotation checks

Project Member Reported by dpranke@chromium.org, Feb 23 2018

Issue description

Checking that all of the networking code is properly annotated takes too long to do in the CQ, so we do a fast pass there instead.

However, we should run the full tests as well to catch any other potential breakages.
 
Blockedon: 812485
Project Member

Comment 2 by bugdroid1@chromium.org, Feb 26 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2c1e08aec3878c9452e28c1f46b1b9eaa100d460

commit 2c1e08aec3878c9452e28c1f46b1b9eaa100d460
Author: Dirk Pranke <dpranke@chromium.org>
Date: Mon Feb 26 22:42:59 2018

Add src-side configs for linux-annotator-rel.

The network traffic annotation checks are too slow to be run
in the main CQ, so we're setting up an additional (FYI) bot to run
the full check (and a matching optional trybot).

R=jbudorick@chromium.org
BUG= 815295 

Change-Id: I16c2bd8cdb2bf10178f1bcd9904b15a1ab90bc8b
Reviewed-on: https://chromium-review.googlesource.com/935625
Commit-Queue: Dirk Pranke <dpranke@chromium.org>
Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Reviewed-by: John Budorick <jbudorick@chromium.org>
Cr-Commit-Position: refs/heads/master@{#539296}
[modify] https://crrev.com/2c1e08aec3878c9452e28c1f46b1b9eaa100d460/testing/buildbot/chromium.fyi.json
[modify] https://crrev.com/2c1e08aec3878c9452e28c1f46b1b9eaa100d460/testing/buildbot/waterfalls.pyl
[modify] https://crrev.com/2c1e08aec3878c9452e28c1f46b1b9eaa100d460/tools/mb/mb_config.pyl

The changes have landed now so all we need are master restarts (bug 816701) and -- assuming things work correctly -- we can start adding the slower tests.
Project Member

Comment 5 by bugdroid1@chromium.org, Mar 7 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/932bda52328d04e32aa2abdf2cd6cb726cf3fa67

commit 932bda52328d04e32aa2abdf2cd6cb726cf3fa67
Author: Ryan Tseng <hinoka@google.com>
Date: Wed Mar 07 03:52:24 2018

[milo] Update consoles

As per: https://ci.chromium.org/p/infra/builders/luci.infra.ci/luci-check/90

BUG:  810907 , 801780,  815295 , 814935, 746816
Change-Id: I6a47d472ff304b2265971bdbf4431ed31af73d61
Reviewed-on: https://chromium-review.googlesource.com/952366
Commit-Queue: Ryan Tseng <hinoka@chromium.org>
Reviewed-by: John Budorick <jbudorick@chromium.org>
Cr-Commit-Position: refs/heads/master@{#541314}
[modify] https://crrev.com/932bda52328d04e32aa2abdf2cd6cb726cf3fa67/infra/config/global/luci-milo.cfg

Status: Fixed (was: Started)

Sign in to add a comment