Privacy Notice content is not displayed in correct language after changing the device language setting. |
||||||||
Issue descriptionApp Version: 65.0.3325.93 Beta iOS Version: 11.2.6, 11.3 Device : iPhone 7, iPhone X Steps to reproduce : 1. Have the device in language other than EN 2. Install the app 3. Change device language to EN 4. Launch app 5. Tap on Privacy Notice link Observed results: Privacy notice content is still displayed in Hebrew. Note: The Title of Privacy Notice is translated, but not the content Terms of Service is translated Expected results: Privacy Notice content should be displayed in correct language after changing the device language setting. Number of times you were able to reproduce: 5/5 Bug reproducible after clean install: Yes Bug reproducible after clearing cache and cookies: Yes Bug reproducible on Chrome Mobile on Android: NA Bug reproducible on Dolphin/Safari/Firefox: Safari : NA Bug reproducible on current stable build (App Version, iOS Version): No in M64 Bug reproducible on the current beta channel build (App Version, iOS Version): Yes in M65 Link to Video : https://drive.google.com/file/d/1_s0TW5eB_hYL_Ygxy9YOQY1b1H8foMjw/view
,
Feb 24 2018
Kurt for first run. Do we know how Privacy Notice language is determined? By using Accept-Lang header?
,
Feb 25 2018
I haven't traced it, but yes, it should be accept-lang set by wkwebview. The value is correct if the device language is changed before installing the app, or if you restart after changing the language. this seems to be a weird edge case.
,
Feb 26 2018
Only delete and install after changing UI language would it work. I wonder if terms.html passes in the language code explicitly or not. Do terms and privacy use the same mechanism for passing along language?
,
Feb 26 2018
Assigning to FirstRun owner. Please reassign if the bus is caused by incorrectly sent Accept-Lang header.
,
Feb 27 2018
I'll take this
,
Feb 27 2018
shbarezer@ can you please confirm the steps in this bug? Neither myself nor srikanthg@ can reproduce with the exact steps. It looks like if you install the app, launch and tap privacy, *then* change the language, the webpage shows a cached version on the second launch. This is something we can fix on our side. However, the steps imply not launching the app at all before changing the language, and that I cannot reproduce.
,
Feb 27 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/f50def54830171c28c63c7332cc6cfe5086d6759 commit f50def54830171c28c63c7332cc6cfe5086d6759 Author: Justin Cohen <justincohen@google.com> Date: Tue Feb 27 20:52:45 2018 [ios] Ignore cache for welcome view page loads. Bug: 815285 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: I87ca4984122383038ecebf2a510d32bc16be54f0 Reviewed-on: https://chromium-review.googlesource.com/939746 Commit-Queue: Justin Cohen <justincohen@chromium.org> Commit-Queue: Kurt Horimoto <kkhorimoto@chromium.org> Reviewed-by: Kurt Horimoto <kkhorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#539540} [modify] https://crrev.com/f50def54830171c28c63c7332cc6cfe5086d6759/ios/chrome/browser/ui/first_run/static_file_view_controller.mm
,
Feb 27 2018
justincohen@ You are correct, I missed an important step (launch and tap privacy) in comment#0. 1) set phone to HE 2) download and install chrome beta, launch, tap on privacy link, see in HE, then 3) set to english 4) launch again, tap on privacy link, content is in HE.
,
Feb 27 2018
Ok, definitely a p3, but also an easy fix, per #8. Thanks!
,
Mar 1 2018
Verified in 66.0.3358.0 Canary, iPhone X iOS 11.2 Looks good. |
||||||||
►
Sign in to add a comment |
||||||||
Comment 1 by justincohen@chromium.org
, Feb 24 2018