New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 815275 link

Starred by 3 users

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Feb 2018
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 3
Type: Bug



Sign in to add a comment

Checking SSH connection for DUTs is slow

Project Member Reported by mattmallett@chromium.org, Feb 23 2018

Issue description

When the manage DUTs page is loaded, each DHCP lease is checked for SSH connectivity, and the timeout is 2 seconds. This is done in serial and results in slow page load. It should be run in parallel.

 
Status: Started (was: Untriaged)
Project Member

Comment 2 by bugdroid1@chromium.org, Feb 24 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/autotest/+/f5321f056459ea0073df92983a1daebe425875d4

commit f5321f056459ea0073df92983a1daebe425875d4
Author: Matt Mallett <mattmallett@chromium.org>
Date: Sat Feb 24 03:31:19 2018

[moblab] Run dut ssh test in parallel

The Manage DUTs page becomes slow with many DUTs connected, as
it checks each connected DUT for SSH connectivity in sequence.
This change has the checks run in parallel subprocesses and
provides a good speedup.

Also updated some messaging on UI for DUTs that couldn't be
reached by SSH, to make it clear what the problem is.

BUG= chromium:815275 , chromium:814425 
TEST=Added unit test for parallel test execution logic, and tested
functionality on local device with 24 connected DUTs.

Change-Id: Id087f02e9a5bf20e06cd536642164c356c747b74
Reviewed-on: https://chromium-review.googlesource.com/935881
Commit-Ready: Matt Mallett <mattmallett@chromium.org>
Tested-by: Matt Mallett <mattmallett@chromium.org>
Reviewed-by: Keith Haddow <haddowk@chromium.org>

[modify] https://crrev.com/f5321f056459ea0073df92983a1daebe425875d4/frontend/afe/moblab_rpc_interface_unittest.py
[modify] https://crrev.com/f5321f056459ea0073df92983a1daebe425875d4/frontend/afe/moblab_rpc_interface.py
[modify] https://crrev.com/f5321f056459ea0073df92983a1daebe425875d4/frontend/client/src/autotest/moblab/DutManagementView.java

Status: Fixed (was: Started)

Sign in to add a comment