New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 815274 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Mar 2018
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 3
Type: Bug



Sign in to add a comment

Mobmonitor should be locally available without network

Project Member Reported by mattmallett@chromium.org, Feb 23 2018

Issue description

We have some external JS dependencies that prevent the page from loading if the moblab device doesn't have network.

 
Summary: Mobmonitor should be locally available without network (was: Mobmonitor should locally available without network)
Status: Started (was: Untriaged)
Project Member

Comment 3 by bugdroid1@chromium.org, Mar 1 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/overlays/board-overlays/+/48195f5433702b5f0393eae9ca5552fb58107360

commit 48195f5433702b5f0393eae9ca5552fb58107360
Author: Matt Mallett <mattmallett@chromium.org>
Date: Thu Mar 01 20:38:55 2018

[moblab] Download mobmonitor UI dependencies during build

Download and include jquery, handlebars js dependencies in the
build, so that the third party scripts are not checked into
source control

BUG= chromium:815274 
TEST=local device

Change-Id: Ia820cd90ebae6746cbf0d8a07e7e3259f2ba4ec1
Reviewed-on: https://chromium-review.googlesource.com/939644
Commit-Ready: Matt Mallett <mattmallett@chromium.org>
Tested-by: Matt Mallett <mattmallett@chromium.org>
Reviewed-by: Keith Haddow <haddowk@chromium.org>
Reviewed-by: Mike Frysinger <vapier@chromium.org>

[modify] https://crrev.com/48195f5433702b5f0393eae9ca5552fb58107360/project-moblab/sys-apps/mobmonitor/mobmonitor-9999.ebuild
[add] https://crrev.com/48195f5433702b5f0393eae9ca5552fb58107360/project-moblab/sys-apps/mobmonitor/Manifest

Project Member

Comment 4 by bugdroid1@chromium.org, Mar 1 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform/moblab/+/eef971e60d830e2419487de6dae2b2f124616ae3

commit eef971e60d830e2419487de6dae2b2f124616ae3
Author: Matt Mallett <mattmallett@chromium.org>
Date: Thu Mar 01 20:38:56 2018

[moblab] Get third party js/css libraries from localhost

Load jquery, handlerbars libraries from localhost instead of from
CDN to allow mobmonitor to be accessed on the moblab device even
without network connectivity.

BUG= chromium:815274 
TEST=Test on local moblab device, both with and without network
connectivity. Verified that mobmonitor page still loads.
CQ-DEPEND=CL:939644

Change-Id: I3e59e7376c41fc3456f779122ff20ba87e9f1624
Reviewed-on: https://chromium-review.googlesource.com/937942
Commit-Ready: Matt Mallett <mattmallett@chromium.org>
Tested-by: Matt Mallett <mattmallett@chromium.org>
Reviewed-by: Keith Haddow <haddowk@chromium.org>

[modify] https://crrev.com/eef971e60d830e2419487de6dae2b2f124616ae3/src/mobmonitor/static/templates/index.html

Status: Fixed (was: Started)

Sign in to add a comment