New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.
Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Mar 2
Cc:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug

Blocked on:
issue 817526



Sign in to add a comment

newbie-release fails Signing stage

Project Member Reported by norvez@chromium.org, Feb 23

Issue description

https://luci-milo.appspot.com/buildbot/chromeos/newbie-release/1007

"
Signing Signing
Image signing timed out.
"

This is fallout from b/72947583
 
Components: Platform>ARC
Cc: norvez@chromium.org
Owner: ejcaruso@chromium.org
Looks like this is happening on fizz, too. https://luci-milo.appspot.com/buildbot/chromeos/fizz-release/1040
Oh interesting, this is actually a different issue from what I was thinking.

Fallout from b/72947583 triggers this behaviour, from a week ago: https://luci-milo.appspot.com/buildbot/chromeos/newbie-release/1000

The signer fails, but it doesn't timeout, it reports the failure. That's the KI.

The fact that the signing step now times out is a different issue however, not sure what's causing it.
I discussed this issue with vapier@ and he discovered the following:

the image is bad

sign_android_image.sh: ERROR : Number of re-signed package seems to be wrong

but the signer also ran into a problem when it tried to send an e-mail notification

280218 15:01 INFO: Failed to retrieve access token: { "error" : "deleted_client", "error_description" : "The OAuth client was deleted.",

He's filing a bug to have some other fallback so signing failures are reported instead of showing up as timeouts and I'll link it here when that's ready.
Cc: -norvez@chromium.org ejcaruso@chromium.org matthewmwang@chromium.org
Owner: norvez@chromium.org
(This does mean that this is a bug with the newbie build rather than an infrastructure issue, at any rate. Assigning to norvez@ to take a look.)
https://chromium-review.googlesource.com/c/chromiumos/platform/vboot_reference/+/911905 should fix the "sign_android_image.sh: ERROR : Number of re-signed package seems to be wrong", that's the fallout from b/72947583

But before submitting it I was waiting for the unit tests to be ready (see https://chrome-internal-review.googlesource.com/c/chromeos/cros-signing/+/572073 and following), the previous attempt at a fix broke *all* the signers...
Blockedon: 817526
Project Member

Comment 8 by bugdroid1@chromium.org, Mar 2

The following revision refers to this bug:
  https://chrome-internal.googlesource.com/chromeos/cros-signing/+/1ef8795a6b829034895e6e11ef347b9be30708bd

commit 1ef8795a6b829034895e6e11ef347b9be30708bd
Author: Nicolas Norvez <norvez@google.com>
Date: Fri Mar 02 01:08:30 2018

Project Member

Comment 9 by bugdroid1@chromium.org, Mar 2

The following revision refers to this bug:
  https://chrome-internal.googlesource.com/chromeos/cros-signing/+/cf7974d67f346ed15a23803a808a4db683c7a4f9

commit cf7974d67f346ed15a23803a808a4db683c7a4f9
Author: Mike Frysinger <vapier@google.com>
Date: Fri Mar 02 01:57:23 2018

Project Member

Comment 10 by bugdroid1@chromium.org, Mar 2

The following revision refers to this bug:
  https://chrome-internal.googlesource.com/chromeos/cros-signing/+/6f2f4398d8c4d56e1fadde79c8a3a08dc7bec696

commit 6f2f4398d8c4d56e1fadde79c8a3a08dc7bec696
Author: Nicolas Norvez <norvez@google.com>
Date: Fri Mar 02 19:19:34 2018

Status: Fixed (was: Started)
i requeued all the old newbie signer requests and they're all passing, so i guess this is good now

Sign in to add a comment