New issue
Advanced search Search tips

Issue 815241 link

Starred by 2 users
Status: Assigned
Owner:
rch@chromium.org
Cc:
mpear...@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

Remove Net.QuicSession.InternalErrorLocation once INTERNAL_ERROR rates are diagnosed

Project Member Reported by rch@chromium.org, Feb 23 2018 
QUIC_INTERNAL_ERROR rates have increased dramatically, and https://chromium-review.googlesource.com/c/chromium/src/+/931996 adds a Net.QuicSession.InternalErrorLocation histogram to track these down. Once we know where these are coming from this histogram needs to be removed.
Project Member

Comment 1 by bugdroid1@chromium.org, Mar 1 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b3fbd6ece138996e15abe165b13d13b49647bd0c

commit b3fbd6ece138996e15abe165b13d13b49647bd0c
Author: Ryan Hamilton <rch@chromium.org>
Date: Thu Mar 01 22:38:50 2018

Add one more missing entry to the Net.QuicSession.InternalErrorLocation
histogram. Also rename the enums to be readable, as per the histogram
team's advice.

BUG=815241

Change-Id: Ic4a15efed46f367b2500ef5e553645323355020a
Reviewed-on: https://chromium-review.googlesource.com/944262
Commit-Queue: Ryan Hamilton <rch@chromium.org>
Reviewed-by: Zhongyi Shi <zhongyi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#540317}
[modify] https://crrev.com/b3fbd6ece138996e15abe165b13d13b49647bd0c/net/quic/chromium/quic_chromium_client_session.cc
[modify] https://crrev.com/b3fbd6ece138996e15abe165b13d13b49647bd0c/net/quic/core/quic_connection.cc
[modify] https://crrev.com/b3fbd6ece138996e15abe165b13d13b49647bd0c/net/quic/core/quic_control_frame_manager.cc
[modify] https://crrev.com/b3fbd6ece138996e15abe165b13d13b49647bd0c/net/quic/core/quic_crypto_client_handshaker.cc
[modify] https://crrev.com/b3fbd6ece138996e15abe165b13d13b49647bd0c/net/quic/core/quic_error_codes.h
[modify] https://crrev.com/b3fbd6ece138996e15abe165b13d13b49647bd0c/net/quic/core/quic_session.cc
[modify] https://crrev.com/b3fbd6ece138996e15abe165b13d13b49647bd0c/net/quic/core/quic_stream.cc
[modify] https://crrev.com/b3fbd6ece138996e15abe165b13d13b49647bd0c/tools/metrics/histograms/enums.xml
Project Member

Comment 2 by bugdroid1@chromium.org, Mar 6 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5b80a387b3941559b6e099d1e3cf45a16f6e5a15

commit 5b80a387b3941559b6e099d1e3cf45a16f6e5a15
Author: Zhongyi Shi <zhongyi@chromium.org>
Date: Tue Mar 06 23:37:59 2018

Fix enum.xml for QuicInternalErrorLocation to map
QUIC_CHROMIUM_CLIENT_SESSION_CLOSE_SESSION_ON_ERROR

Bug: 815241
Change-Id: I807f9e6938fb6cd02b0d047e31f7056325adb71c
Reviewed-on: https://chromium-review.googlesource.com/951856
Reviewed-by: Miriam Gershenson <mgersh@chromium.org>
Commit-Queue: Zhongyi Shi <zhongyi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#541244}
[modify] https://crrev.com/5b80a387b3941559b6e099d1e3cf45a16f6e5a15/tools/metrics/histograms/enums.xml

Comment 3 by benhenry@chromium.org, Aug 3

Status: Assigned (was: Untriaged)
This bug has an owner, thus, it's been triaged. Changing status to "assigned".
►

Sign in to add a comment