New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 815240 link

Starred by 1 user

Issue metadata

Status: Duplicate
Owner:
Long OOO (go/where-is-mgiuca)
Closed: Feb 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Windows , Mac
Pri: 2
Type: ----



Sign in to add a comment

HostedAppTest.ShouldShowLocationBarForHTTPApp in browser_tests is flaky

Project Member Reported by sheriff-...@appspot.gserviceaccount.com, Feb 23 2018

Issue description

Filed by sheriff-o-matic@appspot.gserviceaccount.com on behalf of reillyg@chromium.org

HostedAppTest.ShouldShowLocationBarForHTTPApp in browser_tests is flaky on multiple platforms

Dashboard:

https://test-results.appspot.com/dashboards/flakiness_dashboard.html#tests=HostedAppTest.ShouldShowLocationBarForHTTPApp
 
Description: Show this description
Components: UI>Browser>WebAppInstalls
Labels: OS-Mac OS-Windows
[ RUN      ] HostedAppTest.ShouldShowLocationBarForHTTPApp/0
[7152:7068:0223/100905.989:WARNING:discovery_network_list_win.cc(195)] Failed to open Wlan client handle: 1062
[7152:5456:0223/100905.992:WARNING:chrome_browser_main_win.cc(615)] Command line too long for RegisterApplicationRestart:  --brave-new-test-launcher --cfi-diag=0 --gtest_also_run_disabled_tests --gtest_filter=HostedAppTest.ShouldShowLocationBarForHTTPApp/0 --single_process --test-launcher-bot-mode --test-launcher-output="C:\Users\CHROME~2\AppData\Local\Temp\scoped_dir4540_8433\results4540_17854\test_results.xml" --test-launcher-summary-output="e:\b\s\w\ioyx4x8q\output.json" --user-data-dir="C:\Users\CHROME~2\AppData\Local\Temp\scoped_dir4540_8433\d4540_9031" --disable-offline-auto-reload --no-first-run --no-default-browser-check --enable-logging=stderr --disable-default-apps --wm-window-animations-disabled --disable-component-update --test-type=browser --force-color-profile=srgb --disable-zero-browsers-open-for-tests --ipc-connection-timeout=30 --allow-file-access-from-files --dom-automation --log-gpu-control-list-decisions --disable-backgrounding-occluded-windows --disable-gl-drawing-for-tests --override-use-software-gl-for-tests --force-color-profile=srgb --disable-compositor-ukm-for-tests --enable-features=TestFeatureForBrowserTest1 --disable-features=NetworkPrediction,TestFeatureForBrowserTest2 --flag-switches-begin --flag-switches-end --restore-last-session about:blank
../../chrome/browser/ui/extensions/hosted_app_browsertest.cc(99): error: Expected equality of these values:
  expected_visibility
    Which is: false
  browser->hosted_app_controller()->ShouldShowLocationBar()
    Which is: true
[7152:5456:0223/100908.770:INFO:chrome_cryptauth_service.cc(232)] Profile is not authenticated yet; waiting before starting CryptAuth managers.
[  FAILED  ] HostedAppTest.ShouldShowLocationBarForHTTPApp/0, where GetParam() = (4-byte object <00-00 00-00>, false) (2853 ms)
[ RUN      ] HostedAppTest.ShouldShowLocationBarForHTTPApp/0
[4260:2760:0223/100942.237:WARNING:discovery_network_list_win.cc(195)] Failed to open Wlan client handle: 1062
[4260:3264:0223/100942.237:WARNING:chrome_browser_main_win.cc(615)] Command line too long for RegisterApplicationRestart:  --brave-new-test-launcher --cfi-diag=0 --gtest_also_run_disabled_tests --gtest_filter=HostedAppTest.ShouldShowLocationBarForHTTPApp/0 --single_process --test-launcher-bot-mode --test-launcher-output="C:\Users\CHROME~2\AppData\Local\Temp\scoped_dir4540_8433\results4540_59\test_results.xml" --test-launcher-summary-output="e:\b\s\w\ioyx4x8q\output.json" --user-data-dir="C:\Users\CHROME~2\AppData\Local\Temp\scoped_dir4540_8433\d4540_29974" --disable-offline-auto-reload --no-first-run --no-default-browser-check --enable-logging=stderr --disable-default-apps --wm-window-animations-disabled --disable-component-update --test-type=browser --force-color-profile=srgb --disable-zero-browsers-open-for-tests --ipc-connection-timeout=30 --allow-file-access-from-files --dom-automation --log-gpu-control-list-decisions --disable-backgrounding-occluded-windows --disable-gl-drawing-for-tests --override-use-software-gl-for-tests --force-color-profile=srgb --disable-compositor-ukm-for-tests --enable-features=TestFeatureForBrowserTest1 --disable-features=NetworkPrediction,TestFeatureForBrowserTest2 --flag-switches-begin --flag-switches-end --restore-last-session about:blank
../../chrome/browser/ui/extensions/hosted_app_browsertest.cc(99): error: Expected equality of these values:
  expected_visibility
    Which is: false
  browser->hosted_app_controller()->ShouldShowLocationBar()
    Which is: true
[4260:3264:0223/100944.799:INFO:chrome_cryptauth_service.cc(232)] Profile is not authenticated yet; waiting before starting CryptAuth managers.
[  FAILED  ] HostedAppTest.ShouldShowLocationBarForHTTPApp/0, where GetParam() = (4-byte object <00-00 00-00>, false) (2625 ms)
[ RUN      ] HostedAppTest.ShouldShowLocationBarForHTTPApp/0
[6100:7080:0223/100949.512:WARNING:discovery_network_list_win.cc(195)] Failed to open Wlan client handle: 1062
[6100:7028:0223/100949.512:WARNING:chrome_browser_main_win.cc(615)] Command line too long for RegisterApplicationRestart:  --brave-new-test-launcher --cfi-diag=0 --gtest_also_run_disabled_tests --gtest_filter=HostedAppTest.ShouldShowLocationBarForHTTPApp/0 --single_process --test-launcher-bot-mode --test-launcher-output="C:\Users\CHROME~2\AppData\Local\Temp\scoped_dir4540_8433\results4540_20863\test_results.xml" --test-launcher-summary-output="e:\b\s\w\ioyx4x8q\output.json" --user-data-dir="C:\Users\CHROME~2\AppData\Local\Temp\scoped_dir4540_8433\d4540_26215" --disable-offline-auto-reload --no-first-run --no-default-browser-check --enable-logging=stderr --disable-default-apps --wm-window-animations-disabled --disable-component-update --test-type=browser --force-color-profile=srgb --disable-zero-browsers-open-for-tests --ipc-connection-timeout=30 --allow-file-access-from-files --dom-automation --log-gpu-control-list-decisions --disable-backgrounding-occluded-windows --disable-gl-drawing-for-tests --override-use-software-gl-for-tests --force-color-profile=srgb --disable-compositor-ukm-for-tests --enable-features=TestFeatureForBrowserTest1 --disable-features=NetworkPrediction,TestFeatureForBrowserTest2 --flag-switches-begin --flag-switches-end --restore-last-session about:blank
../../chrome/browser/ui/extensions/hosted_app_browsertest.cc(99): error: Expected equality of these values:
  expected_visibility
    Which is: false
  browser->hosted_app_controller()->ShouldShowLocationBar()
    Which is: true
[6100:7028:0223/100952.522:INFO:chrome_cryptauth_service.cc(232)] Profile is not authenticated yet; waiting before starting CryptAuth managers.
[  FAILED  ] HostedAppTest.ShouldShowLocationBarForHTTPApp/0, where GetParam() = (4-byte object <00-00 00-00>, false) (3087 ms)
[ RUN      ] HostedAppTest.ShouldShowLocationBarForHTTPApp/0
[2164:3188:0223/100952.756:WARNING:discovery_network_list_win.cc(195)] Failed to open Wlan client handle: 1062
[2164:6988:0223/100952.756:WARNING:chrome_browser_main_win.cc(615)] Command line too long for RegisterApplicationRestart:  --brave-new-test-launcher --cfi-diag=0 --gtest_also_run_disabled_tests --gtest_filter=HostedAppTest.ShouldShowLocationBarForHTTPApp/0 --single_process --test-launcher-bot-mode --test-launcher-output="C:\Users\CHROME~2\AppData\Local\Temp\scoped_dir4540_8433\results4540_9799\test_results.xml" --test-launcher-summary-output="e:\b\s\w\ioyx4x8q\output.json" --user-data-dir="C:\Users\CHROME~2\AppData\Local\Temp\scoped_dir4540_8433\d4540_24528" --disable-offline-auto-reload --no-first-run --no-default-browser-check --enable-logging=stderr --disable-default-apps --wm-window-animations-disabled --disable-component-update --test-type=browser --force-color-profile=srgb --disable-zero-browsers-open-for-tests --ipc-connection-timeout=30 --allow-file-access-from-files --dom-automation --log-gpu-control-list-decisions --disable-backgrounding-occluded-windows --disable-gl-drawing-for-tests --override-use-software-gl-for-tests --force-color-profile=srgb --disable-compositor-ukm-for-tests --enable-features=TestFeatureForBrowserTest1 --disable-features=NetworkPrediction,TestFeatureForBrowserTest2 --flag-switches-begin --flag-switches-end --restore-last-session about:blank
../../chrome/browser/ui/extensions/hosted_app_browsertest.cc(99): error: Expected equality of these values:
  expected_visibility
    Which is: false
  browser->hosted_app_controller()->ShouldShowLocationBar()
    Which is: true
[2164:6988:0223/100955.643:INFO:chrome_cryptauth_service.cc(232)] Profile is not authenticated yet; waiting before starting CryptAuth managers.
[  FAILED  ] HostedAppTest.ShouldShowLocationBarForHTTPApp/0, where GetParam() = (4-byte object <00-00 00-00>, false) (2950 ms)
Project Member

Comment 4 by bugdroid1@chromium.org, Feb 23 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8536f5b4c49ef6be78ee64477e59ca9b1ecdd9e0

commit 8536f5b4c49ef6be78ee64477e59ca9b1ecdd9e0
Author: Reilly Grant <reillyg@chromium.org>
Date: Fri Feb 23 19:09:43 2018

Disable flaky HostedAppTests

ShouldShowLocationBarForHTTPApp and ShouldShowLocationBarForHTTPSApp
are both flaky, with the former failing while the later crashes.

TBR=mguica@chromium.org

Bug:  815240 , 815246
Change-Id: I8856047c78d503affea58a25ba6f708454642116
Reviewed-on: https://chromium-review.googlesource.com/934926
Reviewed-by: Reilly Grant <reillyg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#538848}
[modify] https://crrev.com/8536f5b4c49ef6be78ee64477e59ca9b1ecdd9e0/chrome/browser/ui/extensions/hosted_app_browsertest.cc

Labels: -Sheriff-Chromium
Remove from sheriff queue.

Comment 6 by mgiuca@chromium.org, Feb 28 2018

Mergedinto: 814400
Owner: mgiuca@chromium.org
Status: Duplicate (was: Available)
I'm already investigating this in Issue 814400.

There was no way for me to find out about this disabled test because:
- You didn't CC me on the bug.
- You misspelled my name in both the TBR and code review.
- You didn't add a TODO(mgiuca) in the disable comment.

Please check the above when you disable a flaky test. (I only found this because I independently found it was flaky and got a merge conflict disabling it.)
My apologies. It's unfortunate that Gerrit doesn't flag when a reviewer without an account is added as a reviewer on a change. I will try to remember to also CC reviewers on the bug so as to double-check that I have gotten their e-mail address correct.
#7 No problem, just letting you know.

FYI:
- Gerrit autocompletes names and if you type a correct email address, it replaces it with the person's full name and avatar. So if it just remains grey, something is up.
- Regardless of double-checking, you should assign the person on the bug, because it's their responsibility to fix it later.

Sign in to add a comment