New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 815238 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Mar 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug



Sign in to add a comment

Android PFQ: cheets_NotificationTest and cheets_PlayStoreTest are failing

Project Member Reported by norvez@chromium.org, Feb 23 2018

Issue description

https://luci-milo.appspot.com/buildbot/chromeos/veyron_minnie-nyc-android-pfq/1651
https://luci-milo.appspot.com/buildbot/chromeos/veyron_jaq-nyc-android-pfq/1799
https://luci-milo.appspot.com/buildbot/chromeos/cyan-nyc-android-pfq/1651

Some of those builds sometimes fail in other tests too. Maybe ARC++ is a bit flaky and some tests are more likely to trigger an error?

Assigning to the constable for triage.
 
Components: Platform>Apps>ARC

Comment 2 by lpique@chromium.org, Feb 23 2018

The common theme in the failures of cheets_NotificationTest and cheets_PlayStoreTest is that the screenshot captured in the logs (/var/log/arc_screenshots/arc-screenshot_iter1.png) shows an Android system dialog box has popped up "System UI has stopped". I looked at one of the additional failures which happened on the Cyan builder, and saw the same screenshot.

The Play Store test is trying to click a button when it fails. The notification test is trying to find an Android notification by looking for a notification popup. The System UI crash means that both of those will not succeed.

From the logs for the minnie crash of cheets_NotificationTest, I see (/var/log/logcat):

02-23 08:09:58.273   248   248 E AndroidRuntime: FATAL EXCEPTION: main
02-23 08:09:58.273   248   248 E AndroidRuntime: Process: com.android.systemui, PID: 248
02-23 08:09:58.273   248   248 E AndroidRuntime: org.chromium.mojo.bindings.SerializationException: Trying to encode a null pointer for a non-nullable type.
02-23 08:09:58.273   248   248 E AndroidRuntime: 	at org.chromium.mojo.bindings.Encoder.encodeNullPointer(Encoder.java:510)
02-23 08:09:58.273   248   248 E AndroidRuntime: 	at org.chromium.mojo.bindings.Encoder.encode(Encoder.java:242)
02-23 08:09:58.273   248   248 E AndroidRuntime: 	at org.chromium.arc.mojom.ArcNotificationData.encode(ArcNotificationData.java:233)
02-23 08:09:58.273   248   248 E AndroidRuntime: 	at org.chromium.mojo.bindings.Encoder.encode(Encoder.java:218)
02-23 08:09:58.273   248   248 E AndroidRuntime: 	at org.chromium.arc.mojom.NotificationsHost_Internal$NotificationsHostOnNotificationPostedParams.encode(NotificationsHost_Internal.java:369)
02-23 08:09:58.273   248   248 E AndroidRuntime: 	at org.chromium.mojo.bindings.Struct.serializeWithHeader(Struct.java:80)
02-23 08:09:58.273   248   248 E AndroidRuntime: 	at org.chromium.arc.mojom.NotificationsHost_Internal$Proxy.onNotificationPosted(NotificationsHost_Internal.java:75)
02-23 08:09:58.273   248   248 E AndroidRuntime: 	at com.android.systemui.arc.notification.ArcNotificationMojoBridge.onNotificationPosted(ArcNotificationMojoBridge.java:203)
02-23 08:09:58.273   248   248 E AndroidRuntime: 	at com.android.systemui.arc.notification.ArcNotificationsService.openOrUpdateWrapper(ArcNotificationsService.java:249)
02-23 08:09:58.273   248   248 E AndroidRuntime: 	at com.android.systemui.arc.notification.StatelessGroupWrapperManager.updateNotifications(StatelessGroupWrapperManager.java:264)
02-23 08:09:58.273   248   248 E AndroidRuntime: 	at com.android.systemui.arc.notification.StatelessGroupWrapperManager.addNotification(StatelessGroupWrapperManager.java:74)
02-23 08:09:58.273   248   248 E AndroidRuntime: 	at com.android.systemui.arc.notification.ArcNotificationsService.onNotificationPosted(ArcNotificationsService.java:371)
02-23 08:09:58.273   248   248 E AndroidRuntime: 	at android.service.notification.NotificationListenerService$MyHandler.handleMessage(NotificationListenerService.java:1441)
02-23 08:09:58.273   248   248 E AndroidRuntime: 	at android.os.Handler.dispatchMessage(Handler.java:102)
02-23 08:09:58.273   248   248 E AndroidRuntime: 	at android.os.Looper.loop(Looper.java:154)
02-23 08:09:58.273   248   248 E AndroidRuntime: 	at android.app.ActivityThread.main(ActivityThread.java:6320)
02-23 08:09:58.273   248   248 E AndroidRuntime: 	at java.lang.reflect.Method.invoke(Native Method)
02-23 08:09:58.273   248   248 E AndroidRuntime: 	at com.android.internal.os.ZygoteInit$MethodAndArgsCaller.run(ZygoteInit.java:891)

The minnie Play store crash looks like the same stacktrace.

Finding an owner....


Comment 3 by lpique@chromium.org, Feb 23 2018

Owner: edcourtney@chromium.org
Hi Eliot! Looks like you most recently touched this. If you know of someone better to give it to, feel free to reassign.

Comment 4 by lpique@chromium.org, Feb 24 2018

Cc: yoshiki@chromium.org

Comment 5 by lpique@chromium.org, Feb 24 2018

Cc: edcourtney@chromium.org
Owner: yoshiki@chromium.org
Since this is breaking builds, and I it is almost the weekend, I took a little time to track it down to a pair of recently submitted changes.

I'll revert them. This should stop failing at some point "soon".

Real owner is yoshiki@


This failure was because the Chrome-side change (crrev.com/917845) was not on the bots at the time. Since the Chrome-side patch was landed last Friday, I think it's ok for now.

Let me reland the CLs after testing locally and checking the revision which the bots are using.
Status: Started (was: Assigned)
Sorry, the link in #6 was incorrect, the correct is crrev.com/c/917845.
I found that the reason of failure is not making the deprecated fields optional. I'll crate a CL to do it on Chromium-side before landing Android-side CLs.
Status: Fixed (was: Started)
Done by https://chromium-review.googlesource.com/c/chromium/src/+/936948

Sign in to add a comment