New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 815232 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Feb 2018
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux
Pri: 2
Type: Bug



Sign in to add a comment

GN calls orphan files

Reported by juanka85...@gmail.com, Feb 23 2018

Issue description

UserAgent: Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/64.0.3282.140 Safari/537.36

Steps to reproduce the problem:
1. Download canary tarball 
2. Extract it
3. Bootstrap GN
4. See it fail 

What is the expected behavior?
Bootstrap GN 

What went wrong?
Building gn manually in a temporary directory for bootstrapping...
ninja: Entering directory `src/temp/tmpGUh7bQ'
ninja: error: 'src/chromium-66.0.3353.0/base/threading/sequenced_worker_pool.cc', needed by 'base/threading/sequenced_worker_pool.o', missing and no known rule to make it
Command '['ninja', '-C', 'src/temp/tmpGUh7bQ', '-w', 'dupbuild=err', 'gn']' returned non-zero exit status 1

Did this work before? N/A 

Chrome version: 66.0.3353.0  Channel: canary
OS Version: 66.0.3353.0
Flash Version: 

i've fixed it 
https://raw.githubusercontent.com/bn0785ac/in-night/master/r21.patch
 
Owner: timbrown@chromium.org
Status: Started (was: Unconfirmed)
Project Member

Comment 2 by bugdroid1@chromium.org, Feb 23 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/99637d39f360b06fa4d3692f837637a2203d4c75

commit 99637d39f360b06fa4d3692f837637a2203d4c75
Author: Tim Brown <timbrown@chromium.org>
Date: Fri Feb 23 20:35:19 2018

Remove reference to deleted sequenced_worker_pool

Bug:  815232 
Change-Id: I7fad2ccc0c63b16839fb4f43b095bbfb41e844fd
Reviewed-on: https://chromium-review.googlesource.com/935156
Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Commit-Queue: Tim Brown <timbrown@chromium.org>
Cr-Commit-Position: refs/heads/master@{#538882}
[modify] https://crrev.com/99637d39f360b06fa4d3692f837637a2203d4c75/tools/gn/bootstrap/bootstrap.py

Status: Fixed (was: Started)

Sign in to add a comment