New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 815231 link

Starred by 1 user

Issue metadata

Status: Untriaged
Owner: ----
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

Official builders are not building nor running components_unittest

Project Member Reported by sorin@chromium.org, Feb 23 2018

Issue description

Could we add the components_unittest to the official builders?

It appears that the official builder are not building nor running the components_unittest. If this is true then we have some code and test code that builds with #if defined(GOOGLE_CHROME_BUILD) that is not run when in the official builds.

I am looking at the command line for official builders:
python -u /b/rr/tmpTNyIDB/rw/checkout/recipes/.recipe_deps/build/scripts/slave/recipe_modules/chromium/resources/ninja_wrapper.py --ninja_info_output /var/folders/74/6q8tck6s76q64sp6b7wsww_m0000gm/T/tmp4oCDeD.json --failure_output /var/folders/74/6q8tck6s76q64sp6b7wsww_m0000gm/T/tmpLCZWjs -- /b/rr/tmpTNyIDB/rw/checkout/recipes/.recipe_deps/depot_tools/ninja -w 'dupbuild=err' -C /b/c/b/mac64/src/out/Release base_unittests browser_tests chrome content_browsertests content_unittests installer ipc_tests media_unittests net_unittests printing_unittests remoting_all skia_unittests sql_unittests symupload ui_base_unittests unit_tests url_unittests

The case in point is https://chromium-review.googlesource.com/c/chromium/src/+/899920. This change breaks the conditional compilation on Mac but as far as I know it is undetected by the official builder waterfall.

 
This bug had an unsupported status. Updating to Untriaged so someone will reevaluate.
Status: Untriaged

Sign in to add a comment