UnguessableToken::ToString() does not guarantee string length |
|||||||
Issue descriptionOne would expect the string representation of an unguessable token to always be the same length, because it always represents 128b of randomness. However, when the most significant four bytes of either the high_ or the low_ part are zero, which happens about (1 - ((15/16)^2) of the time, the string would be shorter.
,
Feb 23 2018
Fix here: https://chromium-review.googlesource.com/c/chromium/src/+/934824
,
Feb 23 2018
,
Feb 23 2018
,
Feb 26 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/d16e74c356a770d216177213eec390790eca75dc commit d16e74c356a770d216177213eec390790eca75dc Author: Elad Alon <eladalon@chromium.org> Date: Mon Feb 26 13:16:50 2018 Fix UnguessableToken::ToString() Make sure that ToString() would produce distinct strings for distinct tokens. Bug: 815217 Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel Change-Id: I38ea5bfad061610e95945eb31187cb3c02f737cf Reviewed-on: https://chromium-review.googlesource.com/934824 Reviewed-by: Avi Drissman <avi@chromium.org> Reviewed-by: Daniel Cheng <dcheng@chromium.org> Reviewed-by: Jochen Eisinger <jochen@chromium.org> Commit-Queue: Elad Alon <eladalon@chromium.org> Cr-Commit-Position: refs/heads/master@{#539115} [modify] https://crrev.com/d16e74c356a770d216177213eec390790eca75dc/base/unguessable_token.cc [modify] https://crrev.com/d16e74c356a770d216177213eec390790eca75dc/base/unguessable_token_unittest.cc [modify] https://crrev.com/d16e74c356a770d216177213eec390790eca75dc/components/viz/common/surfaces/local_surface_id_unittest.cc
,
Feb 26 2018
,
Feb 26 2018
,
Jun 4 2018
This bug has been closed for more than 14 weeks. Removing security view restrictions. For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot |
|||||||
►
Sign in to add a comment |
|||||||
Comment 1 by eladalon@chromium.org
, Feb 23 2018