New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 815215 link

Starred by 2 users
Status: Fixed
Owner:
█ ymalik@chromium.org
(currently inactive on Chromium)
Closed: Mar 2018
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 3
Type: Bug
Proj-VR
Proj-XR
Proj-XR-VR



Sign in to add a comment

Add integration tests for web input editing

Project Member Reported by ymalik@chromium.org, Feb 23 2018 
We're computing a diff from the text state we get from the GVR keyboard and calling functions on the InputConnection. We have unittests for the diffs we compute, but any changes to the input machinery (e.g ThreadedInputConnection.java) can break us. We should have some integration tests to catch this.

Comment 1 by ymalik@chromium.org, Mar 6 2018

Labels: -Pri-2 -M-66 OS-Android Pri-3

Comment 2 by ymalik@chromium.org, Mar 6 2018

Blocking: -641470
Project Member

Comment 3 by bugdroid1@chromium.org, Mar 22 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/22956a2ef58ab7ca07311a697bfb491b30b68b36

commit 22956a2ef58ab7ca07311a697bfb491b30b68b36
Author: Yash Malik <ymalik@google.com>
Date: Thu Mar 22 18:23:15 2018

VR: Add integration test for WebInputEditing

Bug:  815215 
Change-Id: I98a3665e0663ced8c00ea3a03fa1dbb8ac3d164d
Reviewed-on: https://chromium-review.googlesource.com/956692
Commit-Queue: Yash Malik <ymalik@chromium.org>
Reviewed-by: Brian Sheedy <bsheedy@chromium.org>
Reviewed-by: Amirhossein Simjour <asimjour@chromium.org>
Cr-Commit-Position: refs/heads/master@{#545163}
[modify] https://crrev.com/22956a2ef58ab7ca07311a697bfb491b30b68b36/chrome/android/BUILD.gn
[modify] https://crrev.com/22956a2ef58ab7ca07311a697bfb491b30b68b36/chrome/android/java/src/org/chromium/chrome/browser/vr_shell/VrShellImpl.java
[modify] https://crrev.com/22956a2ef58ab7ca07311a697bfb491b30b68b36/chrome/android/java/src/org/chromium/chrome/browser/vr_shell/keyboard/TextEditAction.java
[modify] https://crrev.com/22956a2ef58ab7ca07311a697bfb491b30b68b36/chrome/android/java/src/org/chromium/chrome/browser/vr_shell/keyboard/VrInputMethodManagerWrapper.java
[modify] https://crrev.com/22956a2ef58ab7ca07311a697bfb491b30b68b36/chrome/android/javatests/src/org/chromium/chrome/browser/vr_shell/EmulatedVrController.java
[modify] https://crrev.com/22956a2ef58ab7ca07311a697bfb491b30b68b36/chrome/android/javatests/src/org/chromium/chrome/browser/vr_shell/VrShellControllerInputTest.java
[add] https://crrev.com/22956a2ef58ab7ca07311a697bfb491b30b68b36/chrome/android/javatests/src/org/chromium/chrome/browser/vr_shell/VrShellWebInputEditingTest.java
[add] https://crrev.com/22956a2ef58ab7ca07311a697bfb491b30b68b36/chrome/android/javatests/src/org/chromium/chrome/browser/vr_shell/mock/MockBrowserKeyboardInterface.java
[modify] https://crrev.com/22956a2ef58ab7ca07311a697bfb491b30b68b36/chrome/browser/android/vr/vr_input_connection.cc
[modify] https://crrev.com/22956a2ef58ab7ca07311a697bfb491b30b68b36/chrome/browser/android/vr/vr_input_connection.h
[modify] https://crrev.com/22956a2ef58ab7ca07311a697bfb491b30b68b36/chrome/browser/android/vr/vr_shell.cc
[modify] https://crrev.com/22956a2ef58ab7ca07311a697bfb491b30b68b36/chrome/browser/android/vr/vr_shell.h
[add] https://crrev.com/22956a2ef58ab7ca07311a697bfb491b30b68b36/chrome/test/data/vr/e2e_test_files/html/test_web_input_editing.html

Comment 4 by ymalik@chromium.org, Mar 26 2018

Status: Fixed (was: Assigned)

Comment 5 by dougman@chromium.org, Mar 28 2018

Labels: M-67 Test-Complete
►

Sign in to add a comment