Remove hostWithProtocol helper function in gerrit.go |
||
Issue descriptionThere is a temporary function left-over in gerrit.go which is meant to be removed once all gerrit hosts in configs have the right protocol: https://chromium.googlesource.com/infra/infra/+/63701ed7cf817938854c20e55c197b9828fa9f86/go/src/infra/tricium/appengine/gerrit/gerrit.go#247
,
Mar 13 2018
The following revision refers to this bug: https://chrome-internal.googlesource.com/infradata/config/+/7ca47f60324f7f967797f52d246c014744118b9a commit 7ca47f60324f7f967797f52d246c014744118b9a Author: Quinten Yearsley <qyearsley@chromium.org> Date: Tue Mar 13 21:39:32 2018
,
Mar 15 2018
The following revision refers to this bug: https://chromium.googlesource.com/infra/infra/+/923bd58184126403ed022035b0cbb348fc2db65f commit 923bd58184126403ed022035b0cbb348fc2db65f Author: Quinten Yearsley <qyearsley@chromium.org> Date: Thu Mar 15 18:19:53 2018 Remove hostWithProtocol helper function Reason: slightly simplify the related code. The API says host doesn't include schema. Bug: 815209 Change-Id: I1273f5f4380ee9a13e102ef7171ace13b0a59484 Reviewed-on: https://chromium-review.googlesource.com/953090 Reviewed-by: Marc-Antoine Ruel <maruel@chromium.org> Commit-Queue: Quinten Yearsley <qyearsley@chromium.org> [modify] https://crrev.com/923bd58184126403ed022035b0cbb348fc2db65f/go/src/infra/tricium/appengine/gerrit/gerrit_test.go [modify] https://crrev.com/923bd58184126403ed022035b0cbb348fc2db65f/go/src/infra/tricium/appengine/gerrit/gerrit.go
,
Mar 20 2018
|
||
►
Sign in to add a comment |
||
Comment 1 by qyears...@chromium.org
, Mar 8 2018