New issue
Advanced search Search tips

Issue 815183 link

Starred by 1 user

Issue metadata

Status: Untriaged
Owner: ----
EstimatedDays: ----
NextAction: ----
OS: Linux
Pri: 3
Type: Bug


Sign in to add a comment

some gl_tests are failing on UBSanVPtr Linux

Project Member Reported by thakis@chromium.org, Feb 23 2018

Issue description

https://chromium-review.googlesource.com/c/933862/ added a bunch of tests to run on UBSanVPtr Linux. The tot bot runs just chromium_linux_clang_gtests but the non-tot bot currently runs chromium_linux_clang_and_gl_gtests.

Turns out some gl_unittests , interactive_ui_tests, and one unit_tests fail on the bot now. (The unit_tests failure is on the tot bot too.)


I'll file sub bugs for all the failures, and then let's only run the tests we also run on the tot bot, so that our bots are green.
 

Comment 1 by thakis@chromium.org, Feb 23 2018

Blockedon: 814308

Comment 2 by thakis@chromium.org, Feb 23 2018

Blockedon: 815184

Comment 3 by thakis@chromium.org, Feb 23 2018

Blockedon: 815185

Comment 4 by thakis@chromium.org, Feb 23 2018

Blockedon: 815186

Comment 5 by thakis@chromium.org, Feb 23 2018

Blocking: 815190

Comment 6 by thakis@chromium.org, Feb 23 2018

Blocking: -815190

Comment 7 by thakis@chromium.org, Feb 23 2018

Blockedon: 815190

Comment 8 by thakis@chromium.org, Feb 23 2018

Blockedon: 815192

Comment 9 by kbr@chromium.org, Feb 23 2018

Blockedon: 814099
Project Member

Comment 10 by bugdroid1@chromium.org, Feb 23 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3a2b171c417d416f3868c77272caec9d59414e65

commit 3a2b171c417d416f3868c77272caec9d59414e65
Author: Nico Weber <thakis@chromium.org>
Date: Fri Feb 23 23:47:38 2018

Tweak which tests run on ToTLinuxUBSanVptr and UBSanVptr Linux.

https://chromium-review.googlesource.com/c/chromium/src/+/933862 added
chromium_linux_clang_and_gl_gtests to the UBSanVptr Linux bot, while
the ToT bot only runs chromium_linux_clang_gtests -- and gl_unittests
doesn't run under ubsan yet (see blockers of crbug.com/815183). So
switch UBSanVptr Linux to chromium_linux_clang_gtests instead.

Many of the tests that were run on UBSanVptr Linux do pass, so run
those on ToTLinuxUBSanVptr too. Namely, aura_unittests, capture_unittests,
chromedriver_unittests, components_browsertests, compositor_unittests,
dbus_unittests, events_unittests, gin_unittests, media_unittests,
mojo_common_unittests, mojo_unittests, nacl_loader_unittests,
ui_touch_selection_unittests, and wm_unittests now run on the ToT bot.

Generally check that if a test is disabled on ToTLinuxUBSanVptr
it's disabled for UBSanVptr Linux too (notably, interactive_ui_tests
no longer runs on the non-tot bot, which also doesn't pass. But
services_unittests now does run, like on the tot bot).

Bug:  814099 , 815183
Change-Id: Icef0bd597f740774351a112df1d2c891ee371d24
Reviewed-on: https://chromium-review.googlesource.com/934424
Reviewed-by: Kenneth Russell <kbr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#538947}
[modify] https://crrev.com/3a2b171c417d416f3868c77272caec9d59414e65/testing/buildbot/chromium.clang.json
[modify] https://crrev.com/3a2b171c417d416f3868c77272caec9d59414e65/testing/buildbot/test_suite_exceptions.pyl
[modify] https://crrev.com/3a2b171c417d416f3868c77272caec9d59414e65/testing/buildbot/waterfalls.pyl

Sign in to add a comment