New issue
Advanced search Search tips

Issue 815179 link

Starred by 1 user
Status: WontFix
Owner: ----
Closed: Feb 2018
Cc:
smcgruer@chromium.org
sadrul@chromium.org
rmis...@google.com
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Bug



Sign in to add a comment

Gerrit sometimes replaces the "Submit to CQ" button with a "Submit" button

Project Member Reported by tdres...@chromium.org, Feb 23 2018 
I'm not sure when this happens, but I'm aware of three sightings now.

I've accidentally skipped the CQ because of this.

According to Stephen, he saw the "Submit" button actually get replaced with a "Submit to CQ" button, without reloading the page.

Marking Pri-1, cause skipping the CQ is scary.

Comment 1 by aga...@chromium.org, Feb 24 2018 

The Submit button is a built-in part of Gerrit. The Submit-to-CQ button is part of a plugin that we wrote and maintain.

If the Submit button isn't being replaced, that means that the plugin wasn't loaded. That's a Gerrit-side bug, and should be filed using the "Send Feedback" link at the bottom of the page.

If the Submit button is being replaced late/slowly, that's the same thing.

The next time you see this, check the js console to make sure that there wasn't an error logged from the plugin itself. If there was, then that's something else I need to look into, but my guess is that the plugin simply wasn't loaded or was loaded slowly.

Comment 2 by tdres...@chromium.org, Feb 26 2018

Status: WontFix (was: Untriaged)
Moving to gerrit issue tracker.
►

Sign in to add a comment