New issue
Advanced search Search tips

Issue 815173 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Feb 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Mac
Pri: 1
Type: Bug-Regression



Sign in to add a comment

Hardware Acceleration Does Not Disable

Reported by monre...@gmail.com, Feb 23 2018

Issue description

UserAgent: Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/66.0.3353.0 Safari/537.36

Steps to reproduce the problem:
1. Disable hardware acceleration in settings
2. Relaunch
3. Hardware acceleration is still enabled

What is the expected behavior?
Hardware acceleration should be disabled

What went wrong?
Hardware acceleration remains enabled

Did this work before? Yes Chrome stable (non-canary)

Chrome version: 66.0.3353.0  Channel: canary
OS Version: 10.0
Flash Version:
 
Labels: Needs-Bisect Needs-Triage-M66
Cc: vamshi.kommuri@chromium.org
Labels: -Pri-2 -Needs-Bisect ReleaseBlock-Stable Triaged-ET M-66 FoundIn-66 Target-66 RegressedIn-66 hasbisect OS-Linux OS-Mac Pri-1
Owner: dpa...@chromium.org
Status: Assigned (was: Unconfirmed)
Able to reproduce the issue on reported chrome version 66.0.3353.0 and on the latest canary 66.0.3355.0 using Windows 10, Ubuntu 14.04 and Mac 10.13.1.

Bisect Information:
=========================
Last Good Build: 66.0.3350.0
First Bad Build: 66.0.3352.0
Note: Performed tool bisect for the above mentioned versions, as 66.0.3351.0 isn't there.

You are probably looking for a change made after 537519 (known good), but no later than 537521 (first known bad).
CHANGELOG URL:
 https://chromium.googlesource.com/chromium/src/+log/2a6316cbf58a58b8f5e29758e645e43469aff312..04f68ff8420a40a405969c3251a119afb0697a96

Suspecting: https://chromium.googlesource.com/chromium/src/+/04f68ff8420a40a405969c3251a119afb0697a96

Review URL: https://chromium-review.googlesource.com/919174
Note: While performing per-revision bisect we faced an issue, i.e., invoked builds are crashing. Hence provided with chromium bisect.
 
@dpapad: Please help in assigning it to others if not related to your change. 

Note: Adding RB-stable as this seems to be a recent regression. Please remove if not required.

Comment 3 by dpa...@chromium.org, Feb 26 2018

Components: -UI UI>Settings

Comment 4 by dpa...@chromium.org, Feb 26 2018

Status: Started (was: Assigned)
Project Member

Comment 5 by bugdroid1@chromium.org, Feb 26 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/24c557e8e069b5892d775dac9271214cec33623a

commit 24c557e8e069b5892d775dac9271214cec33623a
Author: dpapad <dpapad@chromium.org>
Date: Mon Feb 26 20:17:14 2018

Settings WebUI: Fix accidental toggling of hardware acceleration setting.

settings-toggle-button, and cr-toggle need to be migrated from 'click' to 'tap'
at the same time, otherwise calling stopPropagation() has no effect.

Bug:  815173 
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I847ca9892de3c108269995c10647ff16d935d8a5
Reviewed-on: https://chromium-review.googlesource.com/937904
Reviewed-by: Hector Carmona <hcarmona@chromium.org>
Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org>
Cr-Commit-Position: refs/heads/master@{#539250}
[modify] https://crrev.com/24c557e8e069b5892d775dac9271214cec33623a/chrome/browser/resources/settings/system_page/system_page.html

Comment 6 by dpa...@chromium.org, Feb 26 2018

Status: Fixed (was: Started)
Labels: TE-Verified-M66 TE-Verified-66.0.3356.0
Able to reproduce this issue on reported version 66.0.3353.0 using Mac, windows and Linux. Hence verified the fix on latest canary 66.0.3356.0 using Mac, Windows and Linux. Fix is working as expected. i.e; After Navigating to Chrome://settings and disabling Hardware acceleration, Relaunching chrome shows the Hardware acceleration is in disabled state.

Hence adding TE-Verified labels.

Thanks!
815173 CL Verfied.mp4
969 KB View Download

Comment 8 by dpa...@chromium.org, Feb 27 2018

Cc: nyerramilli@chromium.org dpa...@chromium.org rbasuvula@chromium.org
 Issue 816808  has been merged into this issue.

Sign in to add a comment