New issue
Advanced search Search tips

Issue 815170 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Feb 2018
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug



Sign in to add a comment

Mutation of 'pathLength' on non-SVGPathElement SVGGeometryElement doesn't work

Project Member Reported by f...@opera.com, Feb 23 2018

Issue description

Example:

<!DOCTYPE html>
<svg width="100" height="100">
  <rect y="50" width="200" height="100" fill="red"
        stroke="green" stroke-width="100" stroke-dasharray="100"
        pathLength="4800"/>
</svg>
<script>
setTimeout(function() {
  document.querySelector('rect').setAttribute('pathLength', 600);
}, 1000);
</script>

should yield a green 100x100 rectangle after 1s.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Feb 28 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5d6af5e82fb1b59cb7bc257241375a30f1963074

commit 5d6af5e82fb1b59cb7bc257241375a30f1963074
Author: Fredrik Söderquist <fs@opera.com>
Date: Wed Feb 28 12:01:40 2018

[PE] Make SVGGeometryElement handle 'pathLength' mutations

Since the 'pathLength' attribute moved to SVGGeometryElement, so should
the attribute mutation handling.

Bug:  815170 
Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
Change-Id: I04bc19988f80f3c3fe4810897e3003403c6997c6
Reviewed-on: https://chromium-review.googlesource.com/939625
Commit-Queue: Fredrik Söderquist <fs@opera.com>
Reviewed-by: Stephen Chenney <schenney@chromium.org>
Cr-Commit-Position: refs/heads/master@{#539794}
[add] https://crrev.com/5d6af5e82fb1b59cb7bc257241375a30f1963074/third_party/WebKit/LayoutTests/svg/stroke/pathlength-mutation-with-rect-expected.html
[add] https://crrev.com/5d6af5e82fb1b59cb7bc257241375a30f1963074/third_party/WebKit/LayoutTests/svg/stroke/pathlength-mutation-with-rect.html
[modify] https://crrev.com/5d6af5e82fb1b59cb7bc257241375a30f1963074/third_party/WebKit/Source/core/svg/SVGGeometryElement.cpp
[modify] https://crrev.com/5d6af5e82fb1b59cb7bc257241375a30f1963074/third_party/WebKit/Source/core/svg/SVGGeometryElement.h
[modify] https://crrev.com/5d6af5e82fb1b59cb7bc257241375a30f1963074/third_party/WebKit/Source/core/svg/SVGPathElement.cpp

Comment 2 by f...@opera.com, Feb 28 2018

Status: Fixed (was: Started)

Sign in to add a comment