New issue
Advanced search Search tips

Issue 815165 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Feb 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux
Pri: 3
Type: Bug



Sign in to add a comment

Can't `git cl upload` in third_party/openmax_dl

Project Member Reported by thakis@chromium.org, Feb 23 2018

Issue description

What steps will reproduce the problem?
1. cd third_party/openmax_dl
2. Check out local branch, hack
3. git cl upload

What is the expected result?

Uploads patch to somewhere.

What happens instead of that?


Upload server: https://codereview.webrtc.org (change with -s/--server)

Error after CL description prompt -- saving description to /usr/local/google/home/thakis/.git_cl_description_backup

Traceback (most recent call last):
  File "/usr/local/google/home/thakis/src/depot_tools/git_cl.py", line 6174, in <module>
    sys.exit(main(sys.argv[1:]))
  File "/usr/local/google/home/thakis/src/depot_tools/git_cl.py", line 6156, in main
    return dispatcher.execute(OptionParser(), argv)
  File "/usr/local/google/home/thakis/src/depot_tools/subcommand.py", line 252, in execute
    return command(parser, args[1:])
  File "/usr/local/google/home/thakis/src/depot_tools/git_cl.py", line 5007, in CMDupload
    return cl.CMDUpload(options, args, orig_args)
  File "/usr/local/google/home/thakis/src/depot_tools/git_cl.py", line 1617, in CMDUpload
    ret = self.CMDUploadChange(options, git_diff_args, custom_cl_base, change)
  File "/usr/local/google/home/thakis/src/depot_tools/git_cl.py", line 2288, in CMDUploadChange
    issue, patchset = upload.RealMain(upload_args)
  File "/usr/local/google/home/thakis/src/depot_tools/third_party/upload.py", line 2507, in RealMain
    response_body = rpc_server.Send("/upload", body, content_type=ctype)
  File "/usr/local/google/home/thakis/src/depot_tools/third_party/upload.py", line 460, in Send
    f = self.opener.open(req, timeout=70)
  File "/usr/lib/python2.7/urllib2.py", line 435, in open
    response = meth(req, response)
  File "/usr/lib/python2.7/urllib2.py", line 548, in http_response
    'http', request, response, code, msg, hdrs)
  File "/usr/lib/python2.7/urllib2.py", line 473, in error
    return self._call_chain(*args)
  File "/usr/lib/python2.7/urllib2.py", line 407, in _call_chain
    result = func(*args)
  File "/usr/lib/python2.7/urllib2.py", line 556, in http_error_default
    raise HTTPError(req.get_full_url(), code, msg, hdrs, fp)
urllib2.HTTPError: HTTP Error 404: Not Found
 

Comment 1 by thakis@chromium.org, Feb 23 2018

Explicitly passing `--gerrit` made it work. I guess codereview.settings just needs updating somehow.

Comment 3 by thakis@chromium.org, Feb 23 2018

Owner: thakis@chromium.org
Status: Fixed (was: Untriaged)
Thanks for the fix!

Sign in to add a comment