Media Engagement: do not reduce MEI on history expiration |
|||||
Issue descriptionIn general, we need to figure out exactly what to do but most likely, we should leave the MEI untouched. For background, Chrome's history is removed after 90 days and when an entry for an origin is removed from the history, the MEI score is modified. When only part of the history is changed, for deniability, the MEI score is reduced to account for the removed visits and keep the score as-is (if possible). However, because the MEI DB might not be 90 days old, we might end up with 1000 visits to example.com and only 10 visits in the MEI DB. When the history removes the 2 visits that happened 91 days ago, MEI will reduce its visits count to 8. Most likely, this is what we have been calling Mark's bug.
,
Mar 5 2018
,
Mar 6 2018
Your change meets the bar and is auto-approved for M66. Please go ahead and merge the CL to branch 3359 manually. Please contact milestone owner if you have questions. Owners: cmasso@(Android), cmasso@(iOS), josafat@(ChromeOS), abdulsyed@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Mar 6 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/cfb073882daef5fa3567cc80fe2e20263fdcfa8e commit cfb073882daef5fa3567cc80fe2e20263fdcfa8e Author: Mounir Lamouri <mlamouri@chromium.org> Date: Tue Mar 06 17:16:04 2018 Media Engagement: better handling of history service callbacks. - When all history is cleared, simply wipe all of MEI data instead of handling it per website. - When history is expired, do nothing. Better handling of this event will be implemented as par tof bug 818153 Bug: 815163 Change-Id: I87c5d3e91b4c4e0c3191bb3c4e9c889ac6830790 Reviewed-on: https://chromium-review.googlesource.com/946169 Commit-Queue: Tommy Steimel <steimel@chromium.org> Reviewed-by: Tommy Steimel <steimel@chromium.org> Reviewed-by: Ilya Sherman <isherman@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#540842}(cherry picked from commit b1ef86c684a159f85fbece233c5c1f86634b0d9f) Reviewed-on: https://chromium-review.googlesource.com/951722 Reviewed-by: Mounir Lamouri <mlamouri@chromium.org> Cr-Commit-Position: refs/branch-heads/3359@{#32} Cr-Branched-From: 66afc5e5d10127546cc4b98b9117aff588b5e66b-refs/heads/master@{#540276} [modify] https://crrev.com/cfb073882daef5fa3567cc80fe2e20263fdcfa8e/chrome/browser/media/media_engagement_service.cc [modify] https://crrev.com/cfb073882daef5fa3567cc80fe2e20263fdcfa8e/chrome/browser/media/media_engagement_service.h [modify] https://crrev.com/cfb073882daef5fa3567cc80fe2e20263fdcfa8e/chrome/browser/media/media_engagement_service_unittest.cc [modify] https://crrev.com/cfb073882daef5fa3567cc80fe2e20263fdcfa8e/tools/metrics/histograms/enums.xml [modify] https://crrev.com/cfb073882daef5fa3567cc80fe2e20263fdcfa8e/tools/metrics/histograms/histograms.xml
,
Mar 6 2018
|
|||||
►
Sign in to add a comment |
|||||
Comment 1 by bugdroid1@chromium.org
, Mar 5 2018