New issue
Advanced search Search tips

Issue 815140 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Feb 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

Inconsistent use of last_modification_time on possible browsers

Project Member Reported by perezju@chromium.org, Feb 23 2018

Issue description

It is a method in desktop:
https://cs.chromium.org/chromium/src/third_party/catapult/telemetry/telemetry/internal/backends/chrome/desktop_browser_finder.py?rcl=8a42ad3cb185e340c32b20f657980fd057e3769f&l=182

And a property on the base class:
https://cs.chromium.org/chromium/src/third_party/catapult/telemetry/telemetry/internal/browser/possible_browser.py?rcl=8a42ad3cb185e340c32b20f657980fd057e3769f&l=139

It causes errors such as:

$ tools/perf/run_benchmark system_health.common_mobile --story-filter load:news:cnn
WARNING:root:Unable to import cv2 due to: libjpeg.so.8: cannot open shared object file: No such file or directory
(WARNING) 2018-02-23 10:00:31,837 desktop_browser_finder.FindAllAvailableBrowsers:242  Chrome build location for linux_x86_64 not found. Browser will be run without Flash.

Traceback (most recent call last):
  <module> at /usr/local/google/code/clankium/src/tools/perf/run_benchmark:27
    sys.exit(main())
  main at /usr/local/google/code/clankium/src/tools/perf/run_benchmark:23
    return benchmark_runner.main(config, [trybot_command.Trybot])
  main at /usr/local/google/code/clankium/src/third_party/catapult/telemetry/telemetry/benchmark_runner.py:376
    return command_instance.Run(options)
  Run at /usr/local/google/code/clankium/src/third_party/catapult/telemetry/telemetry/benchmark_runner.py:246
    return min(255, b.Run(args))
  Run at /usr/local/google/code/clankium/src/third_party/catapult/telemetry/telemetry/benchmark.py:100
    return story_runner.RunBenchmark(self, finder_options)
  RunBenchmark at /usr/local/google/code/clankium/src/third_party/catapult/telemetry/telemetry/internal/story_runner.py:292
    benchmark.CustomizeBrowserOptions(finder_options.browser_options)
  CustomizeBrowserOptions at /usr/local/google/code/clankium/src/tools/perf/core/perf_benchmark.py:40
    variations = self._GetVariationsBrowserArgs(options.finder_options)
  _GetVariationsBrowserArgs at /usr/local/google/code/clankium/src/tools/perf/core/perf_benchmark.py:57
    possible_browser = browser_finder.FindBrowser(finder_options)
  Cacher at /usr/local/google/code/clankium/src/third_party/catapult/telemetry/telemetry/decorators.py:35
    cacher.__cache[key] = obj(*args, **kwargs)
  FindBrowser at /usr/local/google/code/clankium/src/third_party/catapult/telemetry/telemetry/internal/browser/browser_finder.py:78
    key=lambda b: b.last_modification_time())[-1]
  <lambda> at /usr/local/google/code/clankium/src/third_party/catapult/telemetry/telemetry/internal/browser/browser_finder.py:78
    key=lambda b: b.last_modification_time())[-1]
TypeError: 'int' object is not callable

Locals:
  b : PossibleAndroidBrowser(browser_type=android-webview)

 
Project Member

Comment 2 by bugdroid1@chromium.org, Feb 23 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/catapult/+/07620c72196da0d3798113b850bac480a1fe19e9

commit 07620c72196da0d3798113b850bac480a1fe19e9
Author: Juan Antonio Navarro Perez <perezju@chromium.org>
Date: Fri Feb 23 16:46:33 2018

[Telemetry] Fix usage of last_modification_time in possible browsers

Some used to define it as a property, others as a method, others with
a different name.

Now all define it as a property named last_modification_time, just
like the base class does.

Bug:  chromium:815140 
Change-Id: I6aef3c06cb55c5400560d9be78ee621afc56fdb7
Reviewed-on: https://chromium-review.googlesource.com/934641
Reviewed-by: Ned Nguyen <nednguyen@google.com>
Commit-Queue: Juan Antonio Navarro Pérez <perezju@chromium.org>

[modify] https://crrev.com/07620c72196da0d3798113b850bac480a1fe19e9/telemetry/telemetry/internal/backends/chrome/android_browser_finder_unittest.py
[modify] https://crrev.com/07620c72196da0d3798113b850bac480a1fe19e9/telemetry/telemetry/internal/backends/chrome/desktop_browser_finder.py
[modify] https://crrev.com/07620c72196da0d3798113b850bac480a1fe19e9/telemetry/telemetry/internal/browser/browser_finder.py
[modify] https://crrev.com/07620c72196da0d3798113b850bac480a1fe19e9/telemetry/telemetry/internal/backends/chrome/android_browser_finder.py

Status: Fixed (was: Assigned)

Comment 4 by benhenry@google.com, Jan 16 (6 days ago)

Components: Test>Telemetry

Comment 5 by benhenry@google.com, Jan 16 (6 days ago)

Components: -Speed>Telemetry

Sign in to add a comment