Expand test coverage for Passwords Export feature |
|||
Issue descriptionThe following cases are not sufficiently covered by automated tests. 1. Don't offer UI for export if there are no passwords. 2. Offer UI if there are passwords. 3. Open export dialog when clicking on [More options] 4. Export dialog is dismissable 5. Cancelling ongoing export on the UI also cancels the export in the browser 6. The isn't enough space on the disk. Expand testing to cover these or determine why it isn't feasible.
,
Feb 27 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/fdecc35f4707d5964c7979c16bd2560052bbf567 commit fdecc35f4707d5964c7979c16bd2560052bbf567 Author: Christos Froussios <cfroussios@chromium.org> Date: Tue Feb 27 17:03:55 2018 [Password Manager] Expand automated tests coverage for export feature This CL adds tests for: * Partial write (insufficient disk space to export) * Export should be offered only if there are passwords * Export Passwords menu item opens the export dialog. * The Try Again button restarts the export * The start and error dialogs are dismissible. Bug: 815137 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: Ib8d971ac8eda5824ea80c397bd13a26a36a66277 Reviewed-on: https://chromium-review.googlesource.com/934823 Commit-Queue: Christos Froussios <cfroussios@chromium.org> Reviewed-by: Hector Carmona <hcarmona@chromium.org> Reviewed-by: Vaclav Brozek <vabr@chromium.org> Cr-Commit-Position: refs/heads/master@{#539465} [modify] https://crrev.com/fdecc35f4707d5964c7979c16bd2560052bbf567/chrome/browser/resources/settings/passwords_and_forms_page/passwords_export_dialog.html [modify] https://crrev.com/fdecc35f4707d5964c7979c16bd2560052bbf567/chrome/test/data/webui/settings/settings_passwords_section_browsertest.js [modify] https://crrev.com/fdecc35f4707d5964c7979c16bd2560052bbf567/components/password_manager/core/browser/export/password_manager_exporter_unittest.cc
,
Feb 27 2018
,
Feb 27 2018
Tests are now pending only for Cancelling ongoing export on the UI also cancels the export in the browser This will be resolved with issue 811779 |
|||
►
Sign in to add a comment |
|||
Comment 1 by cfroussios@chromium.org
, Feb 23 2018