The following revision refers to this bug:
  https://chromium.googlesource.com/catapult/+/c9341a3f5d47ca72b4227f181f4ca46dccb0b7fb

commit c9341a3f5d47ca72b4227f181f4ca46dccb0b7fb
Author: Juan Antonio Navarro Perez <perezju@chromium.org>
Date: Fri Feb 23 12:59:23 2018

[Telemetry] A bit of cleanup on Android browser backend settings

Before doing some more drastic changes, do a bit of cleanup removing
dead code and homogenizing attribute names.

Bug: chromium:815133
Change-Id: Id074a8e27f206681365d4e39f3c05ffe20ea0605
Reviewed-on: https://chromium-review.googlesource.com/934443
Reviewed-by: Ned Nguyen <nednguyen@google.com>
Commit-Queue: Juan Antonio Navarro Pérez <perezju@chromium.org>

[modify] https://crrev.com/c9341a3f5d47ca72b4227f181f4ca46dccb0b7fb/telemetry/telemetry/internal/backends/android_browser_backend_settings.py

The following revision refers to this bug:
  https://chromium.googlesource.com/catapult/+/5e6b5c9c68522f902b12289f20037d561764b5cb

commit 5e6b5c9c68522f902b12289f20037d561764b5cb
Author: Juan Antonio Navarro Perez <perezju@chromium.org>
Date: Fri Mar 02 13:59:07 2018

[Telemetry] Move apk finding code to Android backend settings

A first step towards encapsulating the logic to find and install apks
for individual Android browser variants, this CL introduces a
backend_settings.FindLocalApk() method.

As a side effect of this change the logic of the corresponding browser
finder becomes cleaner and now, even if --chrome-root is not given,
allows to select any known browser which is already installed on the
device.

We also take the chance to make _HaveLocalAPK and
_HaveWebViewEmbedderAPK private, as the logic to handle those will
be eventually moved to the banckend_settings as well.

Bug: chromium:815133
Change-Id: I92315d5e169ed308ea685213203244ba4812c186
Reviewed-on: https://chromium-review.googlesource.com/934322
Commit-Queue: Juan Antonio Navarro Pérez <perezju@chromium.org>
Reviewed-by: Ned Nguyen <nednguyen@google.com>

[modify] https://crrev.com/5e6b5c9c68522f902b12289f20037d561764b5cb/telemetry/telemetry/internal/backends/android_browser_backend_settings.py
[modify] https://crrev.com/5e6b5c9c68522f902b12289f20037d561764b5cb/telemetry/telemetry/internal/backends/chrome/android_browser_finder.py

The following revision refers to this bug:
  https://chromium.googlesource.com/catapult/+/354e9cdf4f7cfc5876d5ae8786470a687c283606

commit 354e9cdf4f7cfc5876d5ae8786470a687c283606
Author: Juan Antonio Navarro Perez <perezju@chromium.org>
Date: Tue Mar 06 17:00:23 2018

[Telemetry] Store Android backend settings as namedtuples

This carries many benefits:
- Makes sure we don't accidentally change values after the individual
  settings objects have been created.
- Moves all the information related to each android browser to the same
  place (e.g. browser types, package names, etc.)
- Simplifies a lot of the old "hierarchy" of subclasses amongst
  backend settings.
- Allows to explicitly check for uniqueness of browser types and
  package names on the configured browser.
- Helps to simplify the code for android_browser_finder.

Bug: chromium:815133
Change-Id: I0981f610b1168e0894e5b69ae06c9d2a96c31fc2
Reviewed-on: https://chromium-review.googlesource.com/934822
Reviewed-by: Ned Nguyen <nednguyen@google.com>
Commit-Queue: Juan Antonio Navarro Pérez <perezju@chromium.org>

[modify] https://crrev.com/354e9cdf4f7cfc5876d5ae8786470a687c283606/telemetry/telemetry/internal/backends/chrome/android_browser_finder.py
[modify] https://crrev.com/354e9cdf4f7cfc5876d5ae8786470a687c283606/telemetry/telemetry/internal/backends/android_browser_backend_settings.py
[add] https://crrev.com/354e9cdf4f7cfc5876d5ae8786470a687c283606/telemetry/telemetry/internal/backends/android_backend_settings_unittest.py
[modify] https://crrev.com/354e9cdf4f7cfc5876d5ae8786470a687c283606/telemetry/telemetry/internal/backends/android_app_backend.py

The following revision refers to this bug:
  https://chromium.googlesource.com/catapult/+/cdb26d8896466dce756e5df31cefe9b3955e593e

commit cdb26d8896466dce756e5df31cefe9b3955e593e
Author: Juan Antonio Navarro Pérez <perezju@chromium.org>
Date: Wed Mar 07 09:58:37 2018

Revert "[Telemetry] Store Android backend settings as namedtuples"

This reverts commit 354e9cdf4f7cfc5876d5ae8786470a687c283606.

Reason for revert: Blocking catapult roll.

Original change's description:
> [Telemetry] Store Android backend settings as namedtuples
> 
> This carries many benefits:
> - Makes sure we don't accidentally change values after the individual
>   settings objects have been created.
> - Moves all the information related to each android browser to the same
>   place (e.g. browser types, package names, etc.)
> - Simplifies a lot of the old "hierarchy" of subclasses amongst
>   backend settings.
> - Allows to explicitly check for uniqueness of browser types and
>   package names on the configured browser.
> - Helps to simplify the code for android_browser_finder.
> 
> Bug: chromium:815133
> Change-Id: I0981f610b1168e0894e5b69ae06c9d2a96c31fc2
> Reviewed-on: https://chromium-review.googlesource.com/934822
> Reviewed-by: Ned Nguyen <nednguyen@google.com>
> Commit-Queue: Juan Antonio Navarro Pérez <perezju@chromium.org>

TBR=perezju@chromium.org,nednguyen@google.com

Change-Id: I8c96d07e76803dd92d25912d5420862fdbeca990
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: chromium:815133
Reviewed-on: https://chromium-review.googlesource.com/951605
Reviewed-by: Juan Antonio Navarro Pérez <perezju@chromium.org>
Commit-Queue: Juan Antonio Navarro Pérez <perezju@chromium.org>

[modify] https://crrev.com/cdb26d8896466dce756e5df31cefe9b3955e593e/telemetry/telemetry/internal/backends/chrome/android_browser_finder.py
[modify] https://crrev.com/cdb26d8896466dce756e5df31cefe9b3955e593e/telemetry/telemetry/internal/backends/android_browser_backend_settings.py
[delete] https://crrev.com/d6a5e63df11bc8ed59ef527fa92ce3c9c86b4a4e/telemetry/telemetry/internal/backends/android_backend_settings_unittest.py
[modify] https://crrev.com/cdb26d8896466dce756e5df31cefe9b3955e593e/telemetry/telemetry/internal/backends/android_app_backend.py

Need to go two steps back again because #5 was blocking the catapult autoroll, e.g.:
https://ci.chromium.org/buildbot/tryserver.chromium.chromiumos/linux-chromeos-rel/71771

The following revision refers to this bug:
  https://chromium.googlesource.com/catapult/+/6fbfa7cb20f44fdf0a0336137a33febc44f6fd84

commit 6fbfa7cb20f44fdf0a0336137a33febc44f6fd84
Author: Juan Antonio Navarro Pérez <perezju@chromium.org>
Date: Wed Mar 07 11:10:05 2018

Revert "[Telemetry] Move apk finding code to Android backend settings"

This reverts commit 5e6b5c9c68522f902b12289f20037d561764b5cb.

Reason for revert: Blocking catapult roll.

Original change's description:
> [Telemetry] Move apk finding code to Android backend settings
>
> A first step towards encapsulating the logic to find and install apks
> for individual Android browser variants, this CL introduces a
> backend_settings.FindLocalApk() method.
>
> As a side effect of this change the logic of the corresponding browser
> finder becomes cleaner and now, even if --chrome-root is not given,
> allows to select any known browser which is already installed on the
> device.
>
> We also take the chance to make _HaveLocalAPK and
> _HaveWebViewEmbedderAPK private, as the logic to handle those will
> be eventually moved to the banckend_settings as well.
>
> Bug: chromium:815133
> Change-Id: I92315d5e169ed308ea685213203244ba4812c186
> Reviewed-on: https://chromium-review.googlesource.com/934322
> Commit-Queue: Juan Antonio Navarro Pérez <perezju@chromium.org>
> Reviewed-by: Ned Nguyen <nednguyen@google.com>

TBR=perezju@chromium.org,nednguyen@google.com

# Not skipping CQ checks because original CL landed > 1 day ago.

NOTRY=True
Bug: chromium:815133
Change-Id: Iee8372c13a8f27ee83701c07cd0cdeec1c04aa75
Reviewed-on: https://chromium-review.googlesource.com/951606
Commit-Queue: Juan Antonio Navarro Pérez <perezju@chromium.org>
Reviewed-by: Juan Antonio Navarro Pérez <perezju@chromium.org>

[modify] https://crrev.com/6fbfa7cb20f44fdf0a0336137a33febc44f6fd84/telemetry/telemetry/internal/backends/android_browser_backend_settings.py
[modify] https://crrev.com/6fbfa7cb20f44fdf0a0336137a33febc44f6fd84/telemetry/telemetry/internal/backends/chrome/android_browser_finder.py

The following revision refers to this bug:
  https://chromium.googlesource.com/catapult/+/91b919453804bf72ce06b67443a4ff2478b087db

commit 91b919453804bf72ce06b67443a4ff2478b087db
Author: Juan Antonio Navarro Perez <perezju@chromium.org>
Date: Thu Mar 08 17:34:51 2018

Reland "[Telemetry] Move apk finding code to Android backend settings"

A first step towards encapsulating the logic to find and install apks
for individual Android browser variants, this CL introduces a
backend_settings.FindLocalApk() method.

As a side effect of this change the logic of the corresponding browser
finder becomes cleaner and now, even if --chrome-root is not given,
allows to select any known browser which is already installed on the
device.

We also take the chance to make _HaveLocalAPK and
_HaveWebViewEmbedderAPK private, as the logic to handle those will
be eventually moved to the banckend_settings as well.

Fixed bug from previous attempt to land where the platform_backend
mock had a spec of the wrong object.

Bug: chromium:815133
Change-Id: Ia4c5a5ee65a7ac84fd7b94d440a05001ef396ef5
Reviewed-on: https://chromium-review.googlesource.com/952907
Reviewed-by: Ethan Kuefner <eakuefner@chromium.org>
Commit-Queue: Juan Antonio Navarro Pérez <perezju@chromium.org>

[modify] https://crrev.com/91b919453804bf72ce06b67443a4ff2478b087db/telemetry/telemetry/internal/backends/chrome/android_browser_finder_unittest.py
[modify] https://crrev.com/91b919453804bf72ce06b67443a4ff2478b087db/telemetry/telemetry/internal/backends/android_browser_backend_settings.py
[modify] https://crrev.com/91b919453804bf72ce06b67443a4ff2478b087db/telemetry/telemetry/internal/backends/chrome/android_browser_finder.py

The following revision refers to this bug:
  https://chromium.googlesource.com/catapult/+/b90b97cf8dec1060b14197b68a7c862bab7e4ed5

commit b90b97cf8dec1060b14197b68a7c862bab7e4ed5
Author: Juan Antonio Navarro Perez <perezju@chromium.org>
Date: Fri Mar 09 10:49:59 2018

Reland "[Telemetry] Store Android backend settings as namedtuples"

This is a reland of 354e9cdf4f7cfc5876d5ae8786470a687c283606

Identical patch as before. Patch this depended on has also been
relanded.

Original change's description:
> [Telemetry] Store Android backend settings as namedtuples
>
> This carries many benefits:
> - Makes sure we don't accidentally change values after the individual
>   settings objects have been created.
> - Moves all the information related to each android browser to the same
>   place (e.g. browser types, package names, etc.)
> - Simplifies a lot of the old "hierarchy" of subclasses amongst
>   backend settings.
> - Allows to explicitly check for uniqueness of browser types and
>   package names on the configured browser.
> - Helps to simplify the code for android_browser_finder.
>
> Bug: chromium:815133
> Change-Id: I0981f610b1168e0894e5b69ae06c9d2a96c31fc2
> Reviewed-on: https://chromium-review.googlesource.com/934822
> Reviewed-by: Ned Nguyen <nednguyen@google.com>
> Commit-Queue: Juan Antonio Navarro Pérez <perezju@chromium.org>

Bug: chromium:815133
TBR=nednguyen@google.com
Change-Id: I9b5268b6a8daadad477b5780013e64fe60db8bab
Reviewed-on: https://chromium-review.googlesource.com/957082
Reviewed-by: Juan Antonio Navarro Pérez <perezju@chromium.org>
Commit-Queue: Juan Antonio Navarro Pérez <perezju@chromium.org>

[modify] https://crrev.com/b90b97cf8dec1060b14197b68a7c862bab7e4ed5/telemetry/telemetry/internal/backends/chrome/android_browser_finder.py
[modify] https://crrev.com/b90b97cf8dec1060b14197b68a7c862bab7e4ed5/telemetry/telemetry/internal/backends/android_browser_backend_settings.py
[add] https://crrev.com/b90b97cf8dec1060b14197b68a7c862bab7e4ed5/telemetry/telemetry/internal/backends/android_backend_settings_unittest.py
[modify] https://crrev.com/b90b97cf8dec1060b14197b68a7c862bab7e4ed5/telemetry/telemetry/internal/backends/android_app_backend.py

The following revision refers to this bug:
  https://chromium.googlesource.com/catapult/+/734f737c6b57655a718a178426fb09532ff6f0e9

commit 734f737c6b57655a718a178426fb09532ff6f0e9
Author: Juan Antonio Navarro Perez <perezju@chromium.org>
Date: Mon Mar 19 19:17:28 2018

[Telemetry] Set WebView implementation when using Monochrome.apk

Also add device_utils.SetWebViewImplementation method to abstract away
the command details.

Bug: chromium:815133
Bug: chromium:711073
Change-Id: I60a71abef5253a744c26f71554cb315b8f69aacd
Reviewed-on: https://chromium-review.googlesource.com/968497
Reviewed-by: John Budorick <jbudorick@chromium.org>
Reviewed-by: Ned Nguyen <nednguyen@google.com>
Commit-Queue: Juan Antonio Navarro Pérez <perezju@chromium.org>

[modify] https://crrev.com/734f737c6b57655a718a178426fb09532ff6f0e9/devil/devil/android/device_utils.py
[modify] https://crrev.com/734f737c6b57655a718a178426fb09532ff6f0e9/devil/devil/android/device_utils_test.py
[modify] https://crrev.com/734f737c6b57655a718a178426fb09532ff6f0e9/telemetry/telemetry/internal/backends/chrome/android_browser_finder.py

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c27919454794b261493f721f2182d8a87338b97c

commit c27919454794b261493f721f2182d8a87338b97c
Author: catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Date: Mon Mar 19 22:40:24 2018

Roll src/third_party/catapult/ 2a467ca51..734f737c6 (3 commits)

https://chromium.googlesource.com/catapult.git/+log/2a467ca516e1..734f737c6b57

$ git log 2a467ca51..734f737c6 --date=short --no-merges --format='%ad %ae %s'
2018-03-19 perezju [Telemetry] Set WebView implementation when using Monochrome.apk
2018-03-19 eakuefner [Dashboard] Add IS_SUMMARY diagnostic
2018-03-15 simonhatch Dashboard - Convert anomaly_config.GetAnomalyConfigDict to tasklet.

Created with:
  roll-dep src/third_party/catapult
BUG=chromium:815133,chromium:711073


The AutoRoll server is located here: https://catapult-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=sullivan@chromium.org

Change-Id: I285a1e120abf596080d7fa0c8e187f384cd7d89b
Reviewed-on: https://chromium-review.googlesource.com/969447
Reviewed-by: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#544192}
[modify] https://crrev.com/c27919454794b261493f721f2182d8a87338b97c/DEPS

Most of the critical work I wanted to do here is done. Also no longer blocking issue 711073.

The only bit left I wanted to do is, for developers running the command on the terminal, to make it a lot more explicit: which browser was selected and which APKs (if any) were installed/updated, or if packages already on the device are being used.

The current "Installing {apk} on device if needed." does not make any of this clear.

Reducing Pri anyway as this is not as urgent.

The following revision refers to this bug:
  https://chromium.googlesource.com/catapult/+/70c6b404a5d0c59c3c3ce32956e5a3ae373bbedb

commit 70c6b404a5d0c59c3c3ce32956e5a3ae373bbedb
Author: Juan Antonio Navarro Perez <perezju@chromium.org>
Date: Fri Apr 06 14:14:00 2018

[Telemetry] Fix typo in _FindLocalApk

A typo was introduced in the original implementation which, happily,
still worked by accident.

Bug: chromium:815133
Change-Id: Iee7749bfc695373ce8464f0dc14612e0e35dbf72
Reviewed-on: https://chromium-review.googlesource.com/999652
Reviewed-by: Ned Nguyen <nednguyen@google.com>
Commit-Queue: Juan Antonio Navarro Pérez <perezju@chromium.org>

[modify] https://crrev.com/70c6b404a5d0c59c3c3ce32956e5a3ae373bbedb/telemetry/telemetry/internal/backends/android_browser_backend_settings.py

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4988217824042f03155e4dc611f6b233b3c33689

commit 4988217824042f03155e4dc611f6b233b3c33689
Author: catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Date: Fri Apr 06 19:07:36 2018

Roll src/third_party/catapult/ aaeb23e97..70c6b404a (1 commit)

https://chromium.googlesource.com/catapult.git/+log/aaeb23e97cd1..70c6b404a5d0

$ git log aaeb23e97..70c6b404a --date=short --no-merges --format='%ad %ae %s'
2018-04-06 perezju [Telemetry] Fix typo in _FindLocalApk

Created with:
  roll-dep src/third_party/catapult
BUG=chromium:815133


The AutoRoll server is located here: https://catapult-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=sullivan@chromium.org

Change-Id: I4efae742d78b14335e1c9a4f0c9443cde1993fc5
Reviewed-on: https://chromium-review.googlesource.com/998408
Reviewed-by: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#548881}
[modify] https://crrev.com/4988217824042f03155e4dc611f6b233b3c33689/DEPS