publish_tarball bot failing to produce M64 tarballs |
|||||
Issue descriptionSee e.g.: https://ci.chromium.org/buildbot/chromium.infra.cron/publish_tarball/9897 https://ci.chromium.org/buildbot/chromium.infra.cron/publish_tarball/9900 https://ci.chromium.org/buildbot/chromium.infra.cron/publish_tarball/9903 https://ci.chromium.org/buildbot/chromium.infra.cron/publish_tarball/9906 The failure is always in the bot_update step: Traceback (most recent call last): File "/b/rr/tmphrMlyH/rw/recipes/.recipe_deps/depot_tools/gclient.py", line 2919, in <module> sys.exit(main(sys.argv[1:])) File "/b/rr/tmphrMlyH/rw/recipes/.recipe_deps/depot_tools/gclient.py", line 2905, in main return dispatcher.execute(OptionParser(), argv) File "/b/rr/tmphrMlyH/rw/recipes/.recipe_deps/depot_tools/subcommand.py", line 252, in execute return command(parser, args[1:]) File "/b/rr/tmphrMlyH/rw/recipes/.recipe_deps/depot_tools/gclient.py", line 2660, in CMDsync ret = client.RunOnDeps('update', args) File "/b/rr/tmphrMlyH/rw/recipes/.recipe_deps/depot_tools/gclient.py", line 1640, in RunOnDeps work_queue.flush(revision_overrides, command, args, options=self._options) File "/b/rr/tmphrMlyH/rw/recipes/.recipe_deps/depot_tools/gclient_utils.py", line 1075, in run self.item.run(*self.args, **self.kwargs) File "/b/rr/tmphrMlyH/rw/recipes/.recipe_deps/depot_tools/gclient.py", line 989, in run self.ParseDepsFile() File "/b/rr/tmphrMlyH/rw/recipes/.recipe_deps/depot_tools/gclient.py", line 869, in ParseDepsFile self._postprocess_deps(deps, rel_prefix), use_relative_paths) File "/b/rr/tmphrMlyH/rw/recipes/.recipe_deps/depot_tools/gclient.py", line 727, in _deps_to_objects url = raw_url.format(**self.get_vars()) KeyError: 'git_url' ===Failed in 0.0 mins of /b/cipd_path_tools/bin/python -u /b/rr/tmphrMlyH/rw/recipes/.recipe_deps/depot_tools/gclient.py sync --verbose --reset --force --ignore_locks --output-json /b/rr/tmphrMlyH/t/tmpYbZzia.json --nohooks --noprehooks --delete_unversioned_trees --with_branch_heads --with_tags --revision src@unmanaged === We failed gclient sync, lets delete the checkout and retry. .git detected in checkout, deleting /b/rr/tmphrMlyH/w/recipe_cleanup... Marking for removal /b/rr/tmphrMlyH/w/recipe_cleanup => /b/rr/tmphrMlyH/w/recipe_cleanup/bot_update/recipe_cleanup_0609cd6dac0b4b38a92f0b4fd007e844 Error renaming /b/rr/tmphrMlyH/w/recipe_cleanup to /b/rr/tmphrMlyH/w/recipe_cleanup/bot_update/recipe_cleanup_0609cd6dac0b4b38a92f0b4fd007e844: [Errno 22] Invalid argument Traceback (most recent call last): File "/b/rr/tmphrMlyH/rw/recipes/.recipe_deps/depot_tools/recipes/recipe_modules/bot_update/resources/bot_update.py", line 1299, in <module> sys.exit(main()) File "/b/rr/tmphrMlyH/rw/recipes/.recipe_deps/depot_tools/recipes/recipe_modules/bot_update/resources/bot_update.py", line 1283, in main checkout(options, git_slns, specs, revisions, step_text, shallow) File "/b/rr/tmphrMlyH/rw/recipes/.recipe_deps/depot_tools/recipes/recipe_modules/bot_update/resources/bot_update.py", line 1192, in checkout ensure_no_checkout(dir_names, options.cleanup_dir) File "/b/rr/tmphrMlyH/rw/recipes/.recipe_deps/depot_tools/recipes/recipe_modules/bot_update/resources/bot_update.py", line 304, in ensure_no_checkout remove(deletion_target, cleanup_dir) File "/b/rr/tmphrMlyH/rw/recipes/.recipe_deps/depot_tools/recipes/recipe_modules/bot_update/resources/bot_update.py", line 289, in remove os.rename(target, dest) OSError: [Errno 22] Invalid argument step returned non-zero exit code: 1
,
Feb 23 2018
The problem is a bit complicated and will take some time to fix (and yet again comes down to not having consistent, robust code for handling DEPS file, i.e. Issue 760633 ). Probably the quickest fix for the immediate problem is to just add "git_url" to the vars in the bad DEPS.
,
Feb 23 2018
For completeness, that DEPS file also has occurrences of {boringssl_git}, {pdfium_git} and {webrtc_git}.
Did I understand you correctly in that it's possible to add those variables to DEPS and re-push the tag?
,
Feb 23 2018
Those should be fine because those vars are actually defined, e.g.:
'boringssl_git':
'https://boringssl.googlesource.com',
The problem with {git_url} is that it's not defined.
,
Feb 23 2018
Ah, sorry, I thought the Pythonic syntax was also making gclient fail.
,
Feb 23 2018
Nope, that syntax has been supported by gclient for quite a while now. It's not widely used yet, but is, for instance, the default syntax if you 'gclient flatten' a DEPS file.
,
Feb 23 2018
64.0.3282.186 has "git_url" now. I'll try to find and fix any others.
,
Feb 23 2018
Fixed a few others, although they probably won't be needed if publish_tarball only picks up versions used for releases.
,
Feb 23 2018
Issue 815233 has been merged into this issue.
,
Feb 24 2018
The publish_tarball bot may need some manual intervention. It's still failing the same way, and the hash for the 64.0.3282.186 tag doesn't match https://chromium.googlesource.com/chromium/src/+/64.0.3282.186. https://ci.chromium.org/buildbot/chromium.infra.cron/publish_tarball/9925 says "HEAD is now at 690068336d0f... Publish DEPS for Chromium 64.0.3282.186", whereas the tag's SHA1 b480b7f8aee9dedffaf989b659dc2fd7b3db5e56.
,
Feb 26 2018
Nevermind, https://ci.chromium.org/buildbot/chromium.infra.cron/publish_tarball/9929 seems to have picked up the right SHA1. |
|||||
►
Sign in to add a comment |
|||||
Comment 1 by raphael....@intel.com
, Feb 23 2018