New issue
Advanced search Search tips

Issue 815116 link

Starred by 1 user

Issue metadata

Status: Duplicate
Merged: issue 721219
Owner: ----
Closed: Nov 15
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

external/wpt/workers/name-property.html is flaky

Project Member Reported by raphael....@intel.com, Feb 23 2018

Issue description

WPT imports have been failing since yesterday because https://github.com/w3c/web-platform-tests/commit/51bde6931421d0729716c7f8214724e24de71e08 caused the expectations for name-property.html to change, and the order of the results is not deterministic.

Compare all the different name-property-expected.txt files generated in https://chromium-review.googlesource.com/c/chromium/src/+/933613 and https://chromium-review.googlesource.com/c/chromium/src/+/933807, for example.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Feb 23 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b1ae03c5e123e96be4b58d4d68ea477e66c82cc9

commit b1ae03c5e123e96be4b58d4d68ea477e66c82cc9
Author: Raphael Kubo da Costa <raphael.kubo.da.costa@intel.com>
Date: Fri Feb 23 11:12:08 2018

TestExpectations: Mark name-property.html as flaky

There was an entry in TestExpectations marking it as timing out; I believe
https://github.com/w3c/web-platform-tests/commit/51bde6931421d0729716c7f8214724e24de71e08
has fixed the timeout but now the order of the results is not deterministic.

Mark it as flaky to unblock WPT imports.

TBR=danyao,domenic

Bug:  815116 
Change-Id: Idde415a3676262e8dbc443d9d14b0c28aaae23b4
No-Try: True
Reviewed-on: https://chromium-review.googlesource.com/934343
Commit-Queue: Raphael Kubo da Costa <raphael.kubo.da.costa@intel.com>
Reviewed-by: Raphael Kubo da Costa <raphael.kubo.da.costa@intel.com>
Cr-Commit-Position: refs/heads/master@{#538757}
[modify] https://crrev.com/b1ae03c5e123e96be4b58d4d68ea477e66c82cc9/third_party/WebKit/LayoutTests/TestExpectations

This is still timing out on some builders -- Mac builders are failing now because of this test expectation change.
Hmm, sorry about that. I'll re-add Timeout to the modifiers and hope it all still works.
Project Member

Comment 4 by bugdroid1@chromium.org, Feb 23 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d8e932fbb6ebd5e669f496fd324f8ba83c410a71

commit d8e932fbb6ebd5e669f496fd324f8ba83c410a71
Author: Ian Clelland <iclelland@chromium.org>
Date: Fri Feb 23 15:32:59 2018

TestExpectations: Mark name-property.html as timeout

The previous change to this expectation (in b1ae03c5e1) removed
the timeout expectation; causing failures on the MacOS bots where
it was *also* timing out.

TBR=danyao@chromium.org,domenic@chromium.org,raphael.kubo.da.costa@intel.com

Bug:  815116 
Change-Id: I7854c991399a8e20b57a10cdbd66e13788376f9c
Reviewed-on: https://chromium-review.googlesource.com/934308
Commit-Queue: Ian Clelland <iclelland@chromium.org>
Reviewed-by: Ian Clelland <iclelland@chromium.org>
Cr-Commit-Position: refs/heads/master@{#538785}
[modify] https://crrev.com/d8e932fbb6ebd5e669f496fd324f8ba83c410a71/third_party/WebKit/LayoutTests/TestExpectations

Labels: WorkerBacklog
Mergedinto: 721219
Status: Duplicate (was: Available)

Sign in to add a comment