Regression: Unwanted blink of icons are observed after hovering the mouse on 'add Comment' in google docs.
Reported by
shruti.j...@etouch.net,
Feb 23 2018
|
|||||
Issue descriptionChrome Version:66.0.3353.0 Revision 545e59b4d718e55d2fa80a0a6c104de9236a0eda-refs/heads/master@{#538677}(32-bit) OS : Mac(10.12.6, 10.13.1, 10.13.4), Linux(14.04 LTS), Windows(7,8,8.1,10) Test URL:https://docs.google.com/document/u/0/ Steps to reproduce: (1) Launch chrome and login with valid credentials. (2) Create Document and type something. (3) Hover mouse on 'Add comment' button Actual Result:Unwanted blink of icons are observed after hovering the mouse on 'add Comment' . Expected Result:Unwanted blink of icons should not be seen after hovering the mouse on 'add Comment' . This is a regression issue broken in ‘M-66’ and using per-revision bisect providing the bisect results, Good Build:66.0.3350.0(Revision:537343) Bad Build:66.0.3352.0(Revision:538313) You are probably looking for a change made after 537453 (known good), but no later than 537454 (first known bad). CHANGE-LOG URL: The script might not always return single CL as suspect as some perf builds might get missing due to failure. https://chromium.googlesource.com/chromium/src/+log/e282ebc6f0e5852cfc46ee688bae89a78d119270..0a9a5c311a1d3a298f952e495510bd6fe3faa2f6 Suspect:https://chromium.googlesource.com/chromium/src/+/0a9a5c311a1d3a298f952e495510bd6fe3faa2f6 @Xianzhu Wang: Could you please check whether this is caused with respect to your change, if not please help us in assigning it to the right owner. Thank You!
,
Feb 23 2018
,
Feb 27 2018
I can work on this now.
,
Feb 27 2018
Moved to Target-67 because we have disabled SlimmingPaintV175 in M-66.
,
Feb 28 2018
Reduced test case. When a composited layer with css clip has a scaled stacked child, the layer bounds is incorrect when uniting the bounds of the child. For SPv1 the bug is not shown because we also apply the css clip within the layer. We could fix the bug for SPv175 by adjusting the layer state to be above the css clip but the correct fix should be to fix the layer bounds.
,
Feb 28 2018
Scratch the third paragraph in #c5. https://chromium-review.googlesource.com/c/chromium/src/+/941542 apply the css clip within the layer. Relying on layer bounds for clip seems fragile and would expose some hidden bugs in PaintLayer::BoundingBoxForCompositing().
,
Mar 1 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/08d0991aa4a543be32b43d3672735cf982e46471 commit 08d0991aa4a543be32b43d3672735cf982e46471 Author: Xianzhu Wang <wangxianzhu@chromium.org> Date: Thu Mar 01 03:26:29 2018 [SPv175] Use the parent of css clip as clip state of a composited layer We need to apply the css clip in the composited layer. Bug: 815113 Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Change-Id: I347481df0bf820ed5b2e5c8f33d32b9fbd4dc0c4 Reviewed-on: https://chromium-review.googlesource.com/941542 Reviewed-by: Chris Harrelson <chrishtr@chromium.org> Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Cr-Commit-Position: refs/heads/master@{#540021} [add] https://crrev.com/08d0991aa4a543be32b43d3672735cf982e46471/third_party/WebKit/LayoutTests/compositing/composited-css-clip-with-scaled-child-expected.html [add] https://crrev.com/08d0991aa4a543be32b43d3672735cf982e46471/third_party/WebKit/LayoutTests/compositing/composited-css-clip-with-scaled-child.html [modify] https://crrev.com/08d0991aa4a543be32b43d3672735cf982e46471/third_party/WebKit/Source/core/paint/compositing/CompositingLayerPropertyUpdater.cpp
,
Mar 1 2018
,
Mar 9 2018
Issue 817961 has been merged into this issue. |
|||||
►
Sign in to add a comment |
|||||
Comment 1 by shruti.j...@etouch.net
, Feb 23 2018