Issue metadata
Sign in to add a comment
|
Regression : Weird flickering of 'Previous' and 'next' arrow buttons is seen in 'Find in' page bubble.
Reported by
rp...@etouch.net,
Feb 23 2018
|
||||||||||||||||||||||
Issue description
Version: 66.0.3353.0 (Official Build) Revision545e59b4d718e55d2fa80a0a6c104de9236a0eda-refs/heads/master@{#538677}(64-bit)
OS: Mac OS X(10.12.6,10.13.1,10.13.4)
What steps will reproduce the problem?
1. Launch chrome,navigate to chrome://flags
2. Now press 'Cmd + F' to open 'Find in' page bubble and type any long text in it,observe 'Previous' and 'next' arrow buttons
Actual: Weird flickering of 'Previous' and 'next' arrow buttons is seen while typing long text
Expected: Weird flickering of 'Previous' and 'next' arrow buttons should not be seen while typing long text
This is regression issue, broken in ‘M 66’ and below is the bisect info :
Good build: 66.0.3334.0 (Revision: 532208).
Bad build: 66.0.3335.0 (Revision: 533164).
You are probably looking for a change made after 532458 (known good), but no later than 532459 (first known bad).
CHANGELOG URL:
The script might not always return single CL as suspect as some perf builds might get missing due to failure.
https://chromium.googlesource.com/chromium/src/+log/4719ef1a70a4f19bf8546d124e684074450f5985..a3a307c83a7458e64919925169c2dca0b3ca8049
Suspect : https://chromium.googlesource.com/chromium/src/+/a3a307c83a7458e64919925169c2dca0b3ca8049
From the CL above, assigning the issue to the concern owner
@sangwoo108- Could you please check whether this is caused with respect to your change, if not please help us in assigning it to the right owner.
Note : Issue is not seen on Windows (7,8,8.1,10) and Linux (14.04 LTS)
Thanks!
,
Feb 25 2018
@rpise Thank you for reporting this and sorry for delayed response. You're right. It seems my CL is culprit. I'll fix this ASAP. Thanks again.
,
Feb 28 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/f7e7f4fa0e58f902ff462fe08310291967e4e77d commit f7e7f4fa0e58f902ff462fe08310291967e4e77d Author: sangwoo.ko <sangwoo108@gmail.com> Date: Wed Feb 28 03:05:17 2018 Update find bar button's state properly Find paste board can be updated by current browser or other browsers/applications. 1. By Current Browser(When suppressPboardUpdateActions_ is true): We shouldn't en/disable buttons because it will be updated later based on results. Otherwise, flickering happens( bug 815105 ). 2. By Others(When suppressPboardUpdateAcitons_ is false): We should en/disable buttons based on text length, not on result. prepopulateText() already does this, so revert the previous patch. Why the bug 739735 happnend before was that we call clearFindResultsForCurrentBrowser() after prepopulateText(). Therfore swapping their order can resolve the bug. Bug: 815105 , 739735 Change-Id: I85dc12e151fb7087a3bfab1aaf2b5d8acc3ee6b1 Reviewed-on: https://chromium-review.googlesource.com/936943 Commit-Queue: SangWoo Ko <sangwoo108@gmail.com> Reviewed-by: Robert Sesek <rsesek@chromium.org> Cr-Commit-Position: refs/heads/master@{#539684} [modify] https://crrev.com/f7e7f4fa0e58f902ff462fe08310291967e4e77d/chrome/browser/ui/cocoa/find_bar/find_bar_cocoa_controller.mm
,
Feb 28 2018
,
Mar 1 2018
Update : Rechecked the above issue on Mac OS X(10.12.6,10.13.1,10.13.4) OS using latest canary chrome version : 66.0.3358.0 and issue is not reproduced.Hence adding TE Verified labels. Kindly refer attached screen cast for reference. Thank you. |
|||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||
Comment 1 by rp...@etouch.net
, Feb 23 2018