New issue
Advanced search Search tips

Issue 815078 link

Starred by 1 user
Status: Verified
Owner:
cjgrant@chromium.org
Closed: Feb 2018
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 1
Type: Bug
Proj-VR
Proj-XR
Proj-XR-VR

Blocking:
issue 641470



Sign in to add a comment

VR: URL text shows on top of the keyboard when editing web input

Project Member Reported by ymalik@chromium.org, Feb 23 2018 
1) Navigate to a webpage with a text input field (e.g. google.com)
2) Click on the text field, this should spawn the keyboard
3) Notice the url text and security icon from the url bar behind the keyboard appear on top of the keyboard. This is noticeable when you hover on the keys right in front of the url bar

Comment 1 by cjgrant@chromium.org, Feb 23 2018

Owner: cjgrant@chromium.org
Status: Started (was: Assigned)
Debugging result:  The keyboard isn't rendering through a BaseRenderer.  As such, the URL bar texture is sitting in TexturedQuadRenderer's queue when the keyboard renders itself, and is flushed out later.  This corrupts the intended ordering of elements.

Solution is to wrap keyboard rendering in our standard renderer interface.

Comment 2 by ericde@google.com, Feb 23 2018 

adding screenshot
815078-lockvis-under-keyboard.png
663 KB View Download

Comment 3 by cjgrant@chromium.org, Feb 23 2018

Summary: VR: URL text shows on top of the keyboard when editing web input (was: VR: URL text shows on top of the keyboard when editing web inpit)
Project Member

Comment 4 by bugdroid1@chromium.org, Feb 23 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/754202450a581d633850874e23bf20b820c0fe9e

commit 754202450a581d633850874e23bf20b820c0fe9e
Author: Christopher Grant <cjgrant@chromium.org>
Date: Fri Feb 23 20:48:47 2018

VR: Render the keyboard through a UI renderer

This ensures that it interacts properly with other renderers. If we
render the keyboard directly, it won't flush previously-queued work, and
elements may draw out of order.

BUG= 815078 
R=ymalik

Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_vr;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
Change-Id: Id691fea5a5a0bbbbe5f8e6d56b0ed2c33b0a8b59
Reviewed-on: https://chromium-review.googlesource.com/934981
Commit-Queue: Christopher Grant <cjgrant@chromium.org>
Reviewed-by: Yash Malik <ymalik@chromium.org>
Cr-Commit-Position: refs/heads/master@{#538890}
[modify] https://crrev.com/754202450a581d633850874e23bf20b820c0fe9e/chrome/browser/vr/elements/keyboard.cc
[modify] https://crrev.com/754202450a581d633850874e23bf20b820c0fe9e/chrome/browser/vr/elements/keyboard.h
[modify] https://crrev.com/754202450a581d633850874e23bf20b820c0fe9e/chrome/browser/vr/renderers/base_renderer.h
[modify] https://crrev.com/754202450a581d633850874e23bf20b820c0fe9e/chrome/browser/vr/ui_element_renderer.cc
[modify] https://crrev.com/754202450a581d633850874e23bf20b820c0fe9e/chrome/browser/vr/ui_element_renderer.h

Comment 5 by cjgrant@chromium.org, Feb 23 2018

Status: Fixed (was: Started)

Comment 6 by dougman@chromium.org, Feb 28 2018

Labels: Test-Complete
Status: Verified (was: Fixed)
Verified fix in build 66.0.3356.0
►

Sign in to add a comment