New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 815071 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Mar 2018
Cc:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug



Sign in to add a comment

Non-Regression : Selected Title of the folder should get dismiss after clicking outside in a Folder of App Launcher

Project Member Reported by mmanchala@chromium.org, Feb 23 2018

Issue description

Chrome Version: 66.0.3352.0/10429.0.0 dev-channel Daisy,Kip and Reks
OS: Chrome

What steps will reproduce the problem?
(1)Sign in to chrome -> Open App launcher
(2)Now drag any App into another App so that Folder is created
Ex: Drag 'Files App'  into 'Docs' -> Folder is created
(3)Open Folder -> Now enter lengthy name (Ex:gfhdtygbhhjfghfhdhrjehrfjejrejn)-> 
 Now try to select whole text and now click outside -> observe text selection does not dismiss
(Please refer video)

Expected: Text selection should get dismiss after clicking outside
Actual: Instead Text selection does not get dismiss

This is Non-Regression Issue seen from M-62

@omrilio: Please confirm the Issue

Note : Issue is also sen on M-63,M-64 and M-65
 
Actual_TextSelection.webm
1.8 MB View Download
Owner: weidongg@chromium.org
Labels: applist-folder
Project Member

Comment 3 by bugdroid1@chromium.org, Mar 6 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1b537ed8d78856bf453e9d07a310876f748d5724

commit 1b537ed8d78856bf453e9d07a310876f748d5724
Author: Weidong Guo <weidongg@chromium.org>
Date: Tue Mar 06 19:17:25 2018

Clear focus after located event is not handled

This solves the issue:
After the user taps or clicks outside the folder name, the text should
be deactivated.

Bug:  815071 
Change-Id: Ic8b77fb171d16c59198ccc1112d1b5dcb07a701d
Reviewed-on: https://chromium-review.googlesource.com/951718
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Commit-Queue: Weidong Guo <weidongg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#541170}
[modify] https://crrev.com/1b537ed8d78856bf453e9d07a310876f748d5724/ui/app_list/views/app_list_view.cc
[modify] https://crrev.com/1b537ed8d78856bf453e9d07a310876f748d5724/ui/app_list/views/folder_header_view.cc
[modify] https://crrev.com/1b537ed8d78856bf453e9d07a310876f748d5724/ui/app_list/views/folder_header_view.h

Status: Fixed (was: Assigned)
Labels: app-list-folder

Sign in to add a comment