New issue
Advanced search Search tips

Issue 815069 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Feb 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Mac
Pri: 1
Type: Bug-Regression



Sign in to add a comment

Regression: 'Automatically send usage statistics and crash reports to Google' does not Enable/Disable upon Relaunch.

Reported by aiman.an...@etouch.net, Feb 23 2018

Issue description

Chrome Version: 66.0.3353.0 (Official Build) Revision 545e59b4d718e55d2fa80a0a6c104de9236a0eda-refs/heads/master@{#538677}(32/64-bit)
 	
OS: Win(7,8,8.1,10), Mac(10.12.6, 10.13.1, 10.13.4) and Linux(14.04 LTS).

What steps will reproduce the problem?
1. Launch chrome, navigate to chrome://settings/privacy, toggle button for 'Automatically send usage statistics and crash reports to Google' and Relaunch.
2. Observe

Actual: 'Automatically send usage statistics and crash reports to Google' does not Enable/Disable upon Relaunch.

Expected: 'Automatically send usage statistics and crash reports to Google' should Enable/Disable upon Relaunch.

This is a regression issue, broken in M-66 series, and will soon update other info

Good Build:66.0.3350.0 
Bad Build:66.0.3352.0
 
Actual Result.mp4
1.3 MB View Download
Expected Result.mp4
1.1 MB View Download
Labels: hasbisect-per-revision RegressedIn-66 FoundIn-66 Target-66
Owner: dpa...@chromium.org
Status: Assigned (was: Unconfirmed)
This is a regression issue, broken in M-66 series, Using the per-revision bisect providing the bisect results,

Good Build:66.0.3350.0(Revision:537343)
Bad Build:66.0.3352.0(Revision:538313)

You are probably looking for a change made after 537519 (known good), but no later than 537521 (first known bad).

CHANGE-LOG URL:

The script might not always return single CL as suspect as some perf builds might get missing due to failure.

https://chromium.googlesource.com/chromium/src/+log/2a6316cbf58a58b8f5e29758e645e43469aff312..04f68ff8420a40a405969c3251a119afb0697a96

Suspect: https://chromium.googlesource.com/chromium/src/+/04f68ff8420a40a405969c3251a119afb0697a96

dpapad@:Could you please check whether this is caused with respect to your change, if not please help us in assigning it to the right owner.

Thank You!
Labels: ReleaseBlock-Stable
Adding release blocker label for this issue.Please reduce priority or remove if not the case.

Thank You!

Comment 3 by dpa...@chromium.org, Feb 23 2018

Status: Started (was: Assigned)
Project Member

Comment 4 by bugdroid1@chromium.org, Feb 24 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d44669af913dced6842d2537ca7ab51c01428fcc

commit d44669af913dced6842d2537ca7ab51c01428fcc
Author: dpapad <dpapad@chromium.org>
Date: Sat Feb 24 01:51:16 2018

Settings WebUI: Fix accidental toggling of metrics reporting setting.

settings-toggle-button, and cr-toggle need to be migrated from 'click' to 'tap'
at the same time, otherwise calling stopPropagation() has no effect.

Bug:  815069 
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I44015ff3e5a0a94c6625bc9cfad9ce0e88e43c11
Reviewed-on: https://chromium-review.googlesource.com/935152
Reviewed-by: Scott Chen <scottchen@chromium.org>
Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org>
Cr-Commit-Position: refs/heads/master@{#538966}
[modify] https://crrev.com/d44669af913dced6842d2537ca7ab51c01428fcc/chrome/browser/resources/settings/privacy_page/privacy_page.html

Comment 5 by dpa...@chromium.org, Feb 24 2018

Status: Fixed (was: Started)

Comment 6 by dchau...@etouch.net, Feb 26 2018

Labels: TE-Verified-M66 TE-Verified-65.0.3355.0
Update:-
 Re-tested this issue on Windows (7,8,8.1,10), Mac(10.12.6, 10.13.1, 10.13.4) and Linux(14.04 LTS) machines using latest Chrome Canary build# 66.0.3355.0 and fix is working as expected.. Hence adding TE-Verified labels. 

Please find the attached screen-cast for reference.

Thanks..!
Latest Canary behavior.mp4
779 KB View Download

Comment 7 by ajha@chromium.org, Feb 27 2018

Labels: -TE-Verified-65.0.3355.0 TE-Verified-66.0.3355.0

Sign in to add a comment