New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 815055 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Feb 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 3
Type: Bug



Sign in to add a comment

Use the priority feature to allow some tests to be higher priority than others on CTS moblab suite

Project Member Reported by haddowk@chromium.org, Feb 23 2018

Issue description


In this CL - https://chromium-review.googlesource.com/c/chromiumos/third_party/autotest/+/685831 a feature was added to moblab to allow a single test in the suite to increase the priority of a single job in that suite.

Observing CTS runs on moblab it can be seen that although using test lengths to schedule long running tests early does work.
However when an early run test fails ( often provision failure ) the rescheduled test gets scheduled at the end of the suite.

Setting a higher priority on these tests along with long test length will ensure they get run early and if they fail they will get re-run as soon as a DUT becomes free.
 

Comment 1 by pwang@chromium.org, Feb 23 2018

I'm fine with overriding the existing suite priorities. But ideally, making test_priorities a sub-priority under suite's priorities is making more sense to me. So we do not get extra provision based on test_priorities overlapped with suite_priorities. But, in this case, we may have to deal with the scheduler.
In moblab we do not have suite priorities ( just the default priority is used ) so for now it makes the most sense to do it this way.

I agree if we want to make this more general it would require some work and increase based on a value of the suite priority.  At the moment I am just trying to optimize moblab as much as possible.

Comment 3 by ihf@chromium.org, Feb 24 2018

I think the idea by pwang in #1 is better than mine using deltas, as the latter will trigger reordering of suites/reprovisioning which is undesirable. I am ok if moblab experiments with new features, but ultimately it is best for everyone if there is not too much divergence.

Comment 4 by pwang@chromium.org, Feb 24 2018

Just curious, why moblab does not have suite priority? What is the priority while user trying to schedule a suite? Can user specify their own priority to the suite? If so, would they expect the priority being overridden by test_priorities?
There is no suite scheduler on moblab and they are not running build / cq so there is really no need.  It is not that it is not there, there is just no need for it so it is not exposed in the UI.

Partners typically want to run a single suite at a time, until completion, there is never any overlap hence priorities are not required.
Status: Fixed (was: Started)

Sign in to add a comment