New issue
Advanced search Search tips

Issue 815045 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Feb 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 2
Type: Bug-Regression



Sign in to add a comment

[m.youtube.com] Half loading Spinner is seen

Reported by kye...@etouch.net, Feb 23 2018

Issue description

Application Version: Chrome 66.0.3352.3
Android Build Number: 6.0.1/MMB29K
Device: Samsung Galaxy J7(SM-J700F)

Steps to reproduce: 
1. Launch chrome.
2. Go to m.youtube.com > Observe.

Observed behavior: 
Half loading Spinner is seen. 

Expected behavior: 
Loading spinner should be proper.

Frequency: 
<5/5>

Additional comments: 
1. Good build: 66.0.3350.12
   Bad build : 66.0.3352.3
2. This issue is reproducible on Google Pixel(7.1.2/NJH47F),Karbonn Sparkle V(5.1.1/LMY47V),Samsung Galaxy J7(SM-J700F)(6.0.1/MMB29K),Samsung Galaxy J2(SM-J200G)(5.1.1/LMY47X),Redmi Note 4(6.0.1/MMB29M)

Bisect Range : 
https://chromium.googlesource.com/chromium/src/+log/66.0.3350.12..66.0.3352.3?pretty=fuller&n=10000
 

Comment 1 by kye...@etouch.net, Feb 23 2018

Please find logs and Video @ http://go/chrome-androidlogs1/8/815045

Comment 2 Deleted

Components: Internals>Media>Video Blink>Layout
Labels: -Pri-3 hasbisect-per-revision ReleaseBlock-Stable RegressedIn-66 M-66 FoundIn-66 Target-66 Pri-2 Type-Bug-Regression
Owner: khushals...@chromium.org
Status: Assigned (was: Unconfirmed)
Bisect info:

Good commit: 537378
Bad commit: 537379

Culprit CL:
https://chromium.googlesource.com/chromium/src/+/73760a33887fc8333fe071dd0e5e8c17891e9518

khushalsagar@ Looks like it is related to your change, can you please look into this issue. Thanks 
Project Member

Comment 5 by bugdroid1@chromium.org, Feb 26 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/637c7485329228146d8af0555f8473cc9dc21e5b

commit 637c7485329228146d8af0555f8473cc9dc21e5b
Author: Khushal <khushalsagar@chromium.org>
Date: Mon Feb 26 21:54:16 2018

cc: Ensure correct scaling for non-lazy images in GPU cache.

When using a non-lazy (bitmap) image in the GPU cache, we assume the
upload to be scaled at the mip-level required for draw, when we
actually use the original image for the upload. Fix this by considering
non-lazy scaled images as lazy generated. This also ensures we use
lower gpu memory, by caching downscaled uploads.

R=ericrk@chromium.org

Bug:  815045 ,  814219 
Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
Change-Id: I4b7d3f4edbcf0e5ba5574512f662a3fdf53cabd6
Reviewed-on: https://chromium-review.googlesource.com/935441
Reviewed-by: Zhenyao Mo <zmo@chromium.org>
Reviewed-by: Eric Karl <ericrk@chromium.org>
Commit-Queue: Khushal <khushalsagar@chromium.org>
Cr-Commit-Position: refs/heads/master@{#539276}
[modify] https://crrev.com/637c7485329228146d8af0555f8473cc9dc21e5b/cc/tiles/gpu_image_decode_cache.cc
[modify] https://crrev.com/637c7485329228146d8af0555f8473cc9dc21e5b/cc/tiles/gpu_image_decode_cache_unittest.cc
[modify] https://crrev.com/637c7485329228146d8af0555f8473cc9dc21e5b/content/test/gpu/gpu_tests/pixel_expectations.py
[modify] https://crrev.com/637c7485329228146d8af0555f8473cc9dc21e5b/content/test/gpu/gpu_tests/pixel_test_pages.py

Status: Fixed (was: Assigned)
Status: Verified (was: Fixed)
Issue doesn't repro on latest M66 - 66.0.3356.0 as per the steps mentioned in comment#0 . Hence closing this issue. Thanks 
Project Member

Comment 8 by bugdroid1@chromium.org, Feb 27 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4c1f61ac59a284ef92af29b01b4a9c561c33a56d

commit 4c1f61ac59a284ef92af29b01b4a9c561c33a56d
Author: Henrik Boström <hbos@chromium.org>
Date: Tue Feb 27 12:08:14 2018

Revert "cc: Ensure correct scaling for non-lazy images in GPU cache."

This reverts commit 637c7485329228146d8af0555f8473cc9dc21e5b.

Reason for revert: Suspected culprit of consistent Linux MSan Tests failures of GpuImageDecodeCacheTest.NonLazyImageUploadDownscaled since
https://uberchromegw.corp.google.com/i/chromium.memory/builders/Linux%20MSan%20Tests/builds/8195

Original change's description:
> cc: Ensure correct scaling for non-lazy images in GPU cache.
> 
> When using a non-lazy (bitmap) image in the GPU cache, we assume the
> upload to be scaled at the mip-level required for draw, when we
> actually use the original image for the upload. Fix this by considering
> non-lazy scaled images as lazy generated. This also ensures we use
> lower gpu memory, by caching downscaled uploads.
> 
> R=​ericrk@chromium.org
> 
> Bug:  815045 ,  814219 
> Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
> Change-Id: I4b7d3f4edbcf0e5ba5574512f662a3fdf53cabd6
> Reviewed-on: https://chromium-review.googlesource.com/935441
> Reviewed-by: Zhenyao Mo <zmo@chromium.org>
> Reviewed-by: Eric Karl <ericrk@chromium.org>
> Commit-Queue: Khushal <khushalsagar@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#539276}

TBR=zmo@chromium.org,khushalsagar@chromium.org,ericrk@chromium.org

Change-Id: I441305f1ebfa962b3a78e5fa53f2169996fae196
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug:  815045 ,  814219 
Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
Reviewed-on: https://chromium-review.googlesource.com/939361
Reviewed-by: Henrik Boström <hbos@chromium.org>
Commit-Queue: Henrik Boström <hbos@chromium.org>
Cr-Commit-Position: refs/heads/master@{#539421}
[modify] https://crrev.com/4c1f61ac59a284ef92af29b01b4a9c561c33a56d/cc/tiles/gpu_image_decode_cache.cc
[modify] https://crrev.com/4c1f61ac59a284ef92af29b01b4a9c561c33a56d/cc/tiles/gpu_image_decode_cache_unittest.cc
[modify] https://crrev.com/4c1f61ac59a284ef92af29b01b4a9c561c33a56d/content/test/gpu/gpu_tests/pixel_expectations.py
[modify] https://crrev.com/4c1f61ac59a284ef92af29b01b4a9c561c33a56d/content/test/gpu/gpu_tests/pixel_test_pages.py

Cc: khushals...@chromium.org susan.boorgula@chromium.org
 Issue 816046  has been merged into this issue.
Labels: -Restrict-View-Google
Status: Assigned (was: Verified)
Re-opening to reland the change. Also removing RVG, there isn't anything here for this to be restricted.
Project Member

Comment 11 by bugdroid1@chromium.org, Feb 28 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f4eaa28fb1269d683963f44a3777c5c40d0c3667

commit f4eaa28fb1269d683963f44a3777c5c40d0c3667
Author: Khushal <khushalsagar@chromium.org>
Date: Wed Feb 28 02:48:45 2018

Reland cc: Ensure correct scaling for non-lazy images in GPU cache.

This reverts commit 4c1f61ac59a284ef92af29b01b4a9c561c33a56d. The test
was using unitialized memory which broke the MSAN bots. This patch fixes
that.

TBR=ericrk@chromium.org, zmo@chromium.org

Bug:  815045 
Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
Change-Id: I3d15d740dceba3a6cc90f3d9374514d403164ab7
Reviewed-on: https://chromium-review.googlesource.com/939539
Commit-Queue: Khushal <khushalsagar@chromium.org>
Reviewed-by: Khushal <khushalsagar@chromium.org>
Cr-Commit-Position: refs/heads/master@{#539674}
[modify] https://crrev.com/f4eaa28fb1269d683963f44a3777c5c40d0c3667/cc/test/skia_common.cc
[modify] https://crrev.com/f4eaa28fb1269d683963f44a3777c5c40d0c3667/cc/tiles/gpu_image_decode_cache.cc
[modify] https://crrev.com/f4eaa28fb1269d683963f44a3777c5c40d0c3667/cc/tiles/gpu_image_decode_cache_unittest.cc
[modify] https://crrev.com/f4eaa28fb1269d683963f44a3777c5c40d0c3667/content/test/gpu/gpu_tests/pixel_expectations.py
[modify] https://crrev.com/f4eaa28fb1269d683963f44a3777c5c40d0c3667/content/test/gpu/gpu_tests/pixel_test_pages.py

Status: Fixed (was: Assigned)
Project Member

Comment 13 by bugdroid1@chromium.org, Mar 2 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b88f8da05b7da269f29cb37f0a6651df19624127

commit b88f8da05b7da269f29cb37f0a6651df19624127
Author: Khushal <khushalsagar@chromium.org>
Date: Fri Mar 02 17:25:52 2018

gpu_pixel_test: Re-enable rebaselined tests.

R=zmo@chromium.org

Bug:  815045 
Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
Change-Id: Ie79595f6dd57ba4e38d8dcac5e48f7ef59500b0b
Reviewed-on: https://chromium-review.googlesource.com/945142
Reviewed-by: Zhenyao Mo <zmo@chromium.org>
Commit-Queue: Khushal <khushalsagar@chromium.org>
Cr-Commit-Position: refs/heads/master@{#540545}
[modify] https://crrev.com/b88f8da05b7da269f29cb37f0a6651df19624127/content/test/gpu/gpu_tests/pixel_expectations.py

Sign in to add a comment