Rewrite mobmonitor test systeminfo_unittest.testBlockDevicesExisting |
|||
Issue descriptionAs a part of copying mobmonitor from chromite to platform/moblab, we are removing all dependencies on chromite. The test case systeminfo_unittest.testBlockDevicesExisting relies heavily on chromite.cros_build_lib_unittest.RunCommandMock and needs to be redesigned. I disabled the test case for now.
,
Mar 22 2018
,
Apr 28 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/platform/moblab/+/17e5e59b0bc7cd7ad36b0e3ddcaf24e7855d65f6 commit 17e5e59b0bc7cd7ad36b0e3ddcaf24e7855d65f6 Author: Matt Mallett <mattmallett@chromium.org> Date: Sat Apr 28 04:27:35 2018 [moblab] Fix systeminfo_unittest that depended on chromite Cleaning up systeminfo_unittest.testBlockDevice. Previously relied on chromite, and needed to be rewritten to use plain mocks instead. BUG= chromium:815014 TEST=systeminfo_unittest.py Change-Id: I7dfb4c4069b97a5c78a4f01705587407fd4c8b0a Reviewed-on: https://chromium-review.googlesource.com/1033534 Commit-Ready: Matt Mallett <mattmallett@chromium.org> Tested-by: Matt Mallett <mattmallett@chromium.org> Reviewed-by: Keith Haddow <haddowk@chromium.org> [modify] https://crrev.com/17e5e59b0bc7cd7ad36b0e3ddcaf24e7855d65f6/src/mobmonitor/system/systeminfo_unittest.py
,
May 1 2018
|
|||
►
Sign in to add a comment |
|||
Comment 1 by mattmallett@chromium.org
, Feb 23 2018