New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 815006 link

Starred by 6 users

Issue metadata

Status: Fixed
Owner:
Closed: Oct 2
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug

Blocked on:
issue 882488

Blocking:
issue 814791



Sign in to add a comment

Make sure that SOM does not show failure of experimental step

Project Member Reported by nednguyen@chromium.org, Feb 23 2018

Issue description

telemetry_perf_unittests is an experimental step on  Win7 Tests (dbg)(1), yet its failure still appear on SOM
 
no, Ned intentionally filed this one for whatever we want to do on SoM: https://bugs.chromium.org/p/chromium/issues/detail?id=814791#c17
Oh right. 

I think you can exclude this step in gatekeeper config to make SoM ignore it. https://cs.chromium.org/chromium/build/scripts/slave/gatekeeper.json?q=gatekeeper&sq=package:chromium&l=493

I'd rather not have SoM try to extract any information from step names or do any other special case filtering.


The point here is that it'd be nice to be able to mark steps as experimental in src w/o needing a corresponding change to gatekeeper.json every time we do so.
Are gatekeeper and SoM the only two apps that should ignore these steps or are there others?
Ping. This is still coming up and alerting the sheriffs. 
jbudorick, nednguyen: please propose where you want to store these "ignore this step" flags? This is blocked on that.

AFAIK gatekeeper makes the most sense. We aren't going to parse your source code or try to extract this from text in step names.
I don't know much about what data format we send to the test results server, so deferring this to John
Owner: jbudorick@chromium.org
Status: Assigned (was: Untriaged)
i'll exclude telemetry_perf_unittests on gatekeeper for now, but I don't think the maintenance burden of handling these in gatekeeper is acceptable long-term.
Project Member

Comment 12 by bugdroid1@chromium.org, Mar 23 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/tools/build/+/570e82a588399004ddb2dcf5308b527bdc5e8346

commit 570e82a588399004ddb2dcf5308b527bdc5e8346
Author: John Budorick <jbudorick@chromium.org>
Date: Fri Mar 23 16:21:39 2018

gatekeeper: add experimental tests to all chromium tree closers

Bug:  815006 
Change-Id: If175a437ad28b5b33039cc439fd0f2593e0f4641
Reviewed-on: https://chromium-review.googlesource.com/977895
Reviewed-by: Sean McCullough <seanmccullough@chromium.org>
Commit-Queue: John Budorick <jbudorick@chromium.org>

[modify] https://crrev.com/570e82a588399004ddb2dcf5308b527bdc5e8346/scripts/slave/gatekeeper.json

Status: Fixed (was: Assigned)

Comment 14 by st...@chromium.org, May 18 2018

Status: Assigned (was: Fixed)
This is still showing up on SoM https://screenshot.googleplex.com/czZNcmPOvbv.png
Cc: mgiuca@chromium.org
 Issue 849533  has been merged into this issue.
Status: Started (was: Assigned)
updating SoM's handling of gatekeeper configs in https://chromium-review.googlesource.com/c/infra/infra/+/1119106
Status: Fixed (was: Started)
Fix is live in SoM as of today.
 Issue 833669  has been merged into this issue.
Cc: martiniss@chromium.org
 Issue 868535  has been merged into this issue.
Status: Assigned (was: Fixed)
Fix seems to not be effective.
What makes you believe that? The two bugs you just duped in are from a while ago, and might not still be active?
Seems that SoM ignores categories, including things like experimental_tests.
Status: Started (was: Assigned)
teaching SoM about categories in https://chromium-review.googlesource.com/c/infra/infra/+/1184235
Blockedon: 882488
Status: Fixed (was: Started)
New version of SoM containing #26 was pushed on 2018-09-28.

Sign in to add a comment