Keyboard not shown on KEYCODE_DPAD_CENTER in Add Address setting in Android
Reported by
shu...@amazon.com,
Feb 23 2018
|
||
Issue descriptionSteps to reproduce the problem: 1. Go to Settings->Autofill and payments->Addresses->Add Address 2. Observe that the keyboard automatically comes up when the "Add Address" page is loaded 3. Dismiss the keyboard 4. Try invoking the keyboard again, by sending a KEYCODE_DPAD_CENTER key event (can use "adb shell input keyevent KEYCODE_DPAD_CENTER", if such an input device not available) 5. Observe that the keyboard is not shown What is the expected behavior? What went wrong? The keyboard is not shown when the text input fields receives KEYCODE_DPAD_CENTER. Did this work before? N/A Chrome version: 66.0.3351.0 (master) Channel: stable OS Version: 6.0.1 Flash Version:
,
Mar 6 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/762a5d18444ee277737128002b4e3d096c5a37f6 commit 762a5d18444ee277737128002b4e3d096c5a37f6 Author: Shubham Agrawal <shubag@amazon.com> Date: Tue Mar 06 18:09:03 2018 Ensure OSK shown by KEYCODE_DPAD_CENTER for EditorTextField Currently, the AutoCompleteTextView in EditorTextField does not show the OSK upon receiving KEYCODE_DPAD_CENTER. This happens because TextViews only show the OSK for KEYCODE_DPAD_CENTER, if they do not have an onClickListener set. Since AutoCompleteTextViews set an onClickListener in their constructor, they never show the OSK for KEYCODE_DPAD_CENTER. This change sets an onKeyListener on the AutoCompleteTextView in EditorTextField which shows the OSK upon receiving KEYCODE_DPAD_CENTER. With this change, the AutoCompleteTextView shows the OSK for KEYCODE_DPAD_CENTER. BUG= 814981 TEST=added regression test and manually verified the change Change-Id: I85f7e05622e2c23b7a4dd555c7c13919c9e9f90b Reviewed-on: https://chromium-review.googlesource.com/933362 Commit-Queue: Theresa <twellington@chromium.org> Reviewed-by: Rouslan Solomakhin <rouslan@chromium.org> Reviewed-by: Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#541146} [modify] https://crrev.com/762a5d18444ee277737128002b4e3d096c5a37f6/chrome/android/java/src/org/chromium/chrome/browser/payments/ui/EditorTextField.java [modify] https://crrev.com/762a5d18444ee277737128002b4e3d096c5a37f6/chrome/android/javatests/src/org/chromium/chrome/browser/preferences/autofill/AutofillProfilesFragmentTest.java [modify] https://crrev.com/762a5d18444ee277737128002b4e3d096c5a37f6/chrome/android/javatests/src/org/chromium/chrome/browser/preferences/autofill/AutofillTestRule.java
,
Mar 8 2018
|
||
►
Sign in to add a comment |
||
Comment 1 by shu...@amazon.com
, Feb 23 2018